From: Yaowei Bai <bywxiaobai@163.com>
To: akpm@linux-foundation.org, mgorman@suse.de, vbabka@suse.cz,
mhocko@suse.com, js1304@gmail.com, hannes@cmpxchg.org,
alexander.h.duyck@redhat.com, sasha.levin@oracle.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] mm/page_alloc: fix a terrible misleading comment
Date: Sat, 22 Aug 2015 15:40:10 +0800 [thread overview]
Message-ID: <1440229212-8737-1-git-send-email-bywxiaobai@163.com> (raw)
The comment says that the per-cpu batchsize and zone watermarks
are determined by present_pages which is definitely wrong, they
are both calculated from managed_pages. Fix it.
Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 5b5240b..c22b133 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6003,7 +6003,7 @@ void __init mem_init_print_info(const char *str)
* set_dma_reserve - set the specified number of pages reserved in the first zone
* @new_dma_reserve: The number of pages to mark reserved
*
- * The per-cpu batchsize and zone watermarks are determined by present_pages.
+ * The per-cpu batchsize and zone watermarks are determined by managed_pages.
* In the DMA zone, a significant percentage may be consumed by kernel image
* and other unfreeable allocations which can skew the watermarks badly. This
* function may optionally be used to account for unfreeable pages in the
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2015-08-22 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 7:40 Yaowei Bai [this message]
2015-08-22 7:40 ` [PATCH 2/3] mm/page_alloc: add a helper function to check page before alloc/free Yaowei Bai
2015-08-24 10:47 ` Michal Hocko
2015-08-22 7:40 ` [PATCH 3/3] mm/memblock: fix memblock comment Yaowei Bai
2015-08-24 10:50 ` Michal Hocko
2015-08-24 10:44 ` [PATCH 1/3] mm/page_alloc: fix a terrible misleading comment Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440229212-8737-1-git-send-email-bywxiaobai@163.com \
--to=bywxiaobai@163.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).