From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by kanga.kvack.org (Postfix) with ESMTP id 3EF9C6B0254 for ; Thu, 12 Nov 2015 21:24:07 -0500 (EST) Received: by pasz6 with SMTP id z6so86947778pas.2 for ; Thu, 12 Nov 2015 18:24:07 -0800 (PST) Received: from mail-pa0-x22c.google.com (mail-pa0-x22c.google.com. [2607:f8b0:400e:c03::22c]) by mx.google.com with ESMTPS id jb1si23835558pbb.255.2015.11.12.18.24.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Nov 2015 18:24:04 -0800 (PST) Received: by padhx2 with SMTP id hx2so84073010pad.1 for ; Thu, 12 Nov 2015 18:24:04 -0800 (PST) From: Joonsoo Kim Subject: [PATCH 3/3] mm/cma: always check which page cause allocation failure Date: Fri, 13 Nov 2015 11:23:48 +0900 Message-Id: <1447381428-12445-3-git-send-email-iamjoonsoo.kim@lge.com> In-Reply-To: <1447381428-12445-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1447381428-12445-1-git-send-email-iamjoonsoo.kim@lge.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Michal Nazarewicz , Minchan Kim , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim Now, we have tracepoint in test_pages_isolated() to notify pfn which cannot be isolated. But, in alloc_contig_range(), some error path doesn't call test_pages_isolated() so it's still hard to know exact pfn that causes allocation failure. This patch change this situation by calling test_pages_isolated() in almost error path. In allocation failure case, some overhead is added by this change, but, allocation failure is really rare event so it would not matter. In fatal signal pending case, we don't call test_pages_isolated() because this failure is intentional one. Signed-off-by: Joonsoo Kim --- mm/page_alloc.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index d89960d..e78d78f 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6756,8 +6756,12 @@ int alloc_contig_range(unsigned long start, unsigned long end, if (ret) return ret; + /* + * In case of -EBUSY, we'd like to know which page causes problem. + * So, just fall through. We will check it in test_pages_isolated(). + */ ret = __alloc_contig_migrate_range(&cc, start, end); - if (ret) + if (ret && ret != -EBUSY) goto done; /* @@ -6784,8 +6788,8 @@ int alloc_contig_range(unsigned long start, unsigned long end, outer_start = start; while (!PageBuddy(pfn_to_page(outer_start))) { if (++order >= MAX_ORDER) { - ret = -EBUSY; - goto done; + outer_start = start; + break; } outer_start &= ~0UL << order; } -- 1.9.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org