From: Yang Shi <yang.shi@linaro.org>
To: akpm@linux-foundation.org, rostedt@goodmis.org, mingo@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linaro-kernel@lists.linaro.org, yang.shi@linaro.org
Subject: [RFC V5] Add gup trace points support
Date: Wed, 9 Dec 2015 13:22:24 -0800 [thread overview]
Message-ID: <1449696151-4195-1-git-send-email-yang.shi@linaro.org> (raw)
v5:
* Fixed a typo introduced by v4 rebase
* Removed redundant "#define CREATE_TRACE_POINTS" from architecture specifc
gup.c
v4:
* Adopted Steven's suggestion to use "unsigned int" for nr_pages to save
space in ring buffer since it is unlikely to have more than 0xffffffff
pages are touched by gup in one invoke
* Remove unnecessray type cast
v3:
* Adopted suggestion from Dave Hansen to move the gup header include to the last
* Adopted comments from Steven:
- Use DECLARE_EVENT_CLASS and DEFINE_EVENT
- Just keep necessary TP_ARGS
* Moved archtichture specific fall-backable fast version trace point after the
do while loop since it may jump to the slow version.
* Not implement recording return value since Steven plans to have it in generic
tracing code
v2:
* Adopted commetns from Steven
- remove all reference to tsk->comm since it is unnecessary for non-sched
trace points
- reduce arguments for __get_user_pages trace point and update mm/gup.c
accordingly
* Added Ralf's acked-by for patch 4/7.
Some background about why I think this might be useful.
When I was profiling some hugetlb related program, I got page-faults event
doubled when hugetlb is enabled. When I looked into the code, I found page-faults
come from two places, do_page_fault and gup. So, I tried to figure out which
play a role (or both) in my use case. But I can't find existing finer tracing
event for sub page-faults in current mainline kernel.
So, I added the gup trace points support to have finer tracing events for
page-faults. The below events are added:
__get_user_pages
__get_user_pages_fast
fixup_user_fault
Both __get_user_pages and fixup_user_fault call handle_mm_fault.
Just added trace points to raw version __get_user_pages since all variants
will call it finally to do real work.
Although __get_user_pages_fast doesn't call handle_mm_fault, it might be useful
to have it to distinguish between slow and fast version.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2015-12-09 21:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 21:22 Yang Shi [this message]
2015-12-09 21:22 ` [PATCH v5 1/7] trace/events: Add gup trace events Yang Shi
2015-12-09 21:22 ` [PATCH v5 2/7] mm/gup: add gup trace points Yang Shi
2015-12-09 21:22 ` [PATCH v5 3/7] x86: " Yang Shi
2016-01-13 18:11 ` Shi, Yang
2015-12-09 21:22 ` [PATCH v5 4/7] mips: " Yang Shi
2015-12-09 21:22 ` [PATCH v5 5/7] s390: " Yang Shi
2016-01-13 18:12 ` Shi, Yang
2016-01-14 7:45 ` Heiko Carstens
2015-12-09 21:22 ` [PATCH v5 6/7] sh: " Yang Shi
2015-12-09 21:22 ` [PATCH v5 7/7] sparc64: " Yang Shi
2016-01-13 18:13 ` Shi, Yang
2016-01-13 20:21 ` David Miller
2016-01-13 20:44 ` Steven Rostedt
2016-01-12 20:00 ` [RFC V5] Add gup trace points support Shi, Yang
2016-01-12 20:10 ` Steven Rostedt
2016-01-13 18:14 ` Shi, Yang
2016-01-14 14:40 ` Steven Rostedt
2016-02-08 23:15 ` Shi, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449696151-4195-1-git-send-email-yang.shi@linaro.org \
--to=yang.shi@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).