* [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior
@ 2016-03-17 17:40 Lucas Stach
2016-03-24 15:51 ` Vlastimil Babka
0 siblings, 1 reply; 3+ messages in thread
From: Lucas Stach @ 2016-03-17 17:40 UTC (permalink / raw)
To: Joonsoo Kim, linux-mm; +Cc: linux-kernel, kernel, patchwork-lst
Page isolation has not failed if the fin pfn extends beyond the end pfn
and test_pages_isolated checks this correctly. Fix the tracepoint to
report the same result as the actual check function.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
include/trace/events/page_isolation.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/page_isolation.h b/include/trace/events/page_isolation.h
index 6fb644029c80..8738a78e6bf4 100644
--- a/include/trace/events/page_isolation.h
+++ b/include/trace/events/page_isolation.h
@@ -29,7 +29,7 @@ TRACE_EVENT(test_pages_isolated,
TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s",
__entry->start_pfn, __entry->end_pfn, __entry->fin_pfn,
- __entry->end_pfn == __entry->fin_pfn ? "success" : "fail")
+ __entry->end_pfn <= __entry->fin_pfn ? "success" : "fail")
);
#endif /* _TRACE_PAGE_ISOLATION_H */
--
2.7.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior
2016-03-17 17:40 [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior Lucas Stach
@ 2016-03-24 15:51 ` Vlastimil Babka
2016-03-24 15:52 ` Vlastimil Babka
0 siblings, 1 reply; 3+ messages in thread
From: Vlastimil Babka @ 2016-03-24 15:51 UTC (permalink / raw)
To: Lucas Stach, Joonsoo Kim, linux-mm; +Cc: linux-kernel, kernel, patchwork-lst
On 03/17/2016 06:40 PM, Lucas Stach wrote:
> Page isolation has not failed if the fin pfn extends beyond the end pfn
> and test_pages_isolated checks this correctly. Fix the tracepoint to
> report the same result as the actual check function.
Right.
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> include/trace/events/page_isolation.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/page_isolation.h b/include/trace/events/page_isolation.h
> index 6fb644029c80..8738a78e6bf4 100644
> --- a/include/trace/events/page_isolation.h
> +++ b/include/trace/events/page_isolation.h
> @@ -29,7 +29,7 @@ TRACE_EVENT(test_pages_isolated,
>
> TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s",
> __entry->start_pfn, __entry->end_pfn, __entry->fin_pfn,
> - __entry->end_pfn == __entry->fin_pfn ? "success" : "fail")
> + __entry->end_pfn <= __entry->fin_pfn ? "success" : "fail")
> );
>
> #endif /* _TRACE_PAGE_ISOLATION_H */
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior
2016-03-24 15:51 ` Vlastimil Babka
@ 2016-03-24 15:52 ` Vlastimil Babka
0 siblings, 0 replies; 3+ messages in thread
From: Vlastimil Babka @ 2016-03-24 15:52 UTC (permalink / raw)
To: Lucas Stach, Joonsoo Kim, linux-mm, Andrew Morton
Cc: linux-kernel, kernel, patchwork-lst
On 03/24/2016 04:51 PM, Vlastimil Babka wrote:
> On 03/17/2016 06:40 PM, Lucas Stach wrote:
>> Page isolation has not failed if the fin pfn extends beyond the end pfn
>> and test_pages_isolated checks this correctly. Fix the tracepoint to
>> report the same result as the actual check function.
>
> Right.
>
>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
Note you didn't have Andrew in To/Cc.
>> ---
>> include/trace/events/page_isolation.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/trace/events/page_isolation.h b/include/trace/events/page_isolation.h
>> index 6fb644029c80..8738a78e6bf4 100644
>> --- a/include/trace/events/page_isolation.h
>> +++ b/include/trace/events/page_isolation.h
>> @@ -29,7 +29,7 @@ TRACE_EVENT(test_pages_isolated,
>>
>> TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s",
>> __entry->start_pfn, __entry->end_pfn, __entry->fin_pfn,
>> - __entry->end_pfn == __entry->fin_pfn ? "success" : "fail")
>> + __entry->end_pfn <= __entry->fin_pfn ? "success" : "fail")
>> );
>>
>> #endif /* _TRACE_PAGE_ISOLATION_H */
>>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-24 15:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 17:40 [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior Lucas Stach
2016-03-24 15:51 ` Vlastimil Babka
2016-03-24 15:52 ` Vlastimil Babka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).