From: Joe Perches <joe@perches.com>
To: Yaowei Bai <baiyaowei@cmss.chinamobile.com>, akpm@linux-foundation.org
Cc: n-horiguchi@ah.jp.nec.com, kirill.shutemov@linux.intel.com,
rientjes@google.com, iamjoonsoo.kim@lge.com, hannes@cmpxchg.org,
vdavydov@virtuozzo.com, kuleshovmail@gmail.com, vbabka@suse.cz,
mgorman@techsingularity.net, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] mm/lru: is_file/active_lru can be boolean
Date: Tue, 22 Mar 2016 20:17:08 -0700 [thread overview]
Message-ID: <1458703028.22080.7.camel@perches.com> (raw)
In-Reply-To: <1458699969-3432-5-git-send-email-baiyaowei@cmss.chinamobile.com>
On Wed, 2016-03-23 at 10:26 +0800, Yaowei Bai wrote:
> This patch makes is_file/active_lru return bool to improve
> readability due to these particular functions only using either
> one or zero as their return value.
>
> No functional change.
These assignments to int should likely be modified too
$ git grep -w -n is_file_lru
include/linux/mmzone.h:191:static inline int is_file_lru(enum lru_list lru)
mm/vmscan.c:1404: nr_taken, mode, is_file_lru(lru));
mm/vmscan.c:1525: int file = is_file_lru(lru);
mm/vmscan.c:1581: int file = is_file_lru(lru);
mm/vmscan.c:1783: int file = is_file_lru(lru);
mm/vmscan.c:1934: if (is_file_lru(lru))
mm/vmscan.c:2129: int file = is_file_lru(lru);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-03-23 3:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 2:26 [PATCH 0/5] mm: make several functions return bool Yaowei Bai
2016-03-23 2:26 ` [PATCH 1/5] mm/hugetlb: is_vm_hugetlb_page can be boolean Yaowei Bai
2016-03-23 2:26 ` [PATCH 2/5] mm/memory_hotplug: is_mem_section_removable " Yaowei Bai
2016-03-23 2:26 ` [PATCH 3/5] mm/vmalloc: is_vmalloc_addr " Yaowei Bai
2016-03-23 2:26 ` [PATCH 4/5] mm/lru: is_file/active_lru " Yaowei Bai
2016-03-23 3:17 ` Joe Perches [this message]
2016-03-23 11:44 ` Mel Gorman
2016-03-23 2:26 ` [PATCH 5/5] mm/mempolicy: vma_migratable " Yaowei Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458703028.22080.7.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).