From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Hansen <dave.hansen@intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@gentwo.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Jerome Marchand <jmarchan@redhat.com>,
Yang Shi <yang.shi@linaro.org>,
Sasha Levin <sasha.levin@oracle.com>,
Andres Lagar-Cavilla <andreslc@google.com>,
Ning Qu <quning@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv6 10/30] thp: handle file COW faults
Date: Thu, 7 Apr 2016 01:51:00 +0300 [thread overview]
Message-ID: <1459983080-106718-11-git-send-email-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <1459983080-106718-1-git-send-email-kirill.shutemov@linux.intel.com>
File COW for THP is handled on pte level: just split the pmd.
It's not clear how benefitial would be allocation of huge pages on COW
faults. And it would require some code to make them work.
I think at some point we can consider teaching khugepaged to collapse
pages in COW mappings, but allocating huge on fault is probably
overkill.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
mm/memory.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/memory.c b/mm/memory.c
index c41804c0d524..e5c6b4387da3 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3395,6 +3395,11 @@ static int wp_huge_pmd(struct fault_env *fe, pmd_t orig_pmd)
if (fe->vma->vm_ops->pmd_fault)
return fe->vma->vm_ops->pmd_fault(fe->vma, fe->address, fe->pmd,
fe->flags);
+
+ /* COW handled on pte level: split pmd */
+ VM_BUG_ON_VMA(fe->vma->vm_flags & VM_SHARED, fe->vma);
+ split_huge_pmd(fe->vma, fe->pmd, fe->address);
+
return VM_FAULT_FALLBACK;
}
--
2.8.0.rc3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-04-06 22:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 22:50 [PATCHv6 00/30] THP-enabled tmpfs/shmem using compound pages Kirill A. Shutemov
2016-04-06 22:50 ` [PATCHv6 01/30] thp, mlock: update unevictable-lru.txt Kirill A. Shutemov
2016-04-06 22:50 ` [PATCHv6 02/30] mm: do not pass mm_struct into handle_mm_fault Kirill A. Shutemov
2016-04-06 22:50 ` [PATCHv6 03/30] mm: introduce fault_env Kirill A. Shutemov
2016-04-06 22:50 ` [PATCHv6 04/30] mm: postpone page table allocation until we have page to map Kirill A. Shutemov
2016-04-06 22:50 ` [PATCHv6 05/30] rmap: support file thp Kirill A. Shutemov
2016-04-06 22:50 ` [PATCHv6 06/30] mm: introduce do_set_pmd() Kirill A. Shutemov
2016-04-06 22:50 ` [PATCHv6 07/30] thp, vmstats: add counters for huge file pages Kirill A. Shutemov
2016-04-06 22:50 ` [PATCHv6 08/30] thp: support file pages in zap_huge_pmd() Kirill A. Shutemov
2016-04-06 22:50 ` [PATCHv6 09/30] thp: handle file pages in split_huge_pmd() Kirill A. Shutemov
2016-04-06 22:51 ` Kirill A. Shutemov [this message]
2016-04-06 22:51 ` [PATCHv6 11/30] thp: handle file pages in mremap() Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 12/30] thp: skip file huge pmd on copy_huge_pmd() Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 13/30] thp: prepare change_huge_pmd() for file thp Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 14/30] thp: run vma_adjust_trans_huge() outside i_mmap_rwsem Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 15/30] thp: file pages support for split_huge_page() Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 16/30] thp, mlock: do not mlock PTE-mapped file huge pages Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 17/30] vmscan: split file huge pages before paging them out Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 18/30] page-flags: relax policy for PG_mappedtodisk and PG_reclaim Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 19/30] radix-tree: implement radix_tree_maybe_preload_order() Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 20/30] filemap: prepare find and delete operations for huge pages Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 21/30] truncate: handle file thp Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 22/30] mm, rmap: account shmem thp pages Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 23/30] shmem: prepare huge= mount option and sysfs knob Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 24/30] shmem: get_unmapped_area align huge page Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 25/30] shmem: add huge pages support Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 26/30] shmem, thp: respect MADV_{NO,}HUGEPAGE for file mappings Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 27/30] thp: update Documentation/vm/transhuge.txt Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 28/30] thp: extract khugepaged from mm/huge_memory.c Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 29/30] khugepaged: move up_read(mmap_sem) out of khugepaged_alloc_page() Kirill A. Shutemov
2016-04-06 22:51 ` [PATCHv6 30/30] khugepaged: add support of collapse for tmpfs/shmem pages Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459983080-106718-11-git-send-email-kirill.shutemov@linux.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andreslc@google.com \
--cc=cl@gentwo.org \
--cc=dave.hansen@intel.com \
--cc=hughd@google.com \
--cc=jmarchan@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=quning@gmail.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
--cc=yang.shi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).