linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 01/22] mm, page_alloc: Only check PageCompound for high-order pages
Date: Mon, 11 Apr 2016 09:13:24 +0100	[thread overview]
Message-ID: <1460362424-26369-2-git-send-email-mgorman@techsingularity.net> (raw)
In-Reply-To: <1460362424-26369-1-git-send-email-mgorman@techsingularity.net>

order-0 pages by definition cannot be compound so avoid the check in the
fast path for those pages.

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
 mm/page_alloc.c | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 59de90d5d3a3..5d205bcfe10d 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1024,24 +1024,33 @@ void __meminit reserve_bootmem_region(unsigned long start, unsigned long end)
 
 static bool free_pages_prepare(struct page *page, unsigned int order)
 {
-	bool compound = PageCompound(page);
-	int i, bad = 0;
+	int bad = 0;
 
 	VM_BUG_ON_PAGE(PageTail(page), page);
-	VM_BUG_ON_PAGE(compound && compound_order(page) != order, page);
 
 	trace_mm_page_free(page, order);
 	kmemcheck_free_shadow(page, order);
 	kasan_free_pages(page, order);
 
+	/*
+	 * Check tail pages before head page information is cleared to
+	 * avoid checking PageCompound for order-0 pages.
+	 */
+	if (order) {
+		bool compound = PageCompound(page);
+		int i;
+
+		VM_BUG_ON_PAGE(compound && compound_order(page) != order, page);
+
+		for (i = 1; i < (1 << order); i++) {
+			if (compound)
+				bad += free_tail_pages_check(page, page + i);
+			bad += free_pages_check(page + i);
+		}
+	}
 	if (PageAnon(page))
 		page->mapping = NULL;
 	bad += free_pages_check(page);
-	for (i = 1; i < (1 << order); i++) {
-		if (compound)
-			bad += free_tail_pages_check(page, page + i);
-		bad += free_pages_check(page + i);
-	}
 	if (bad)
 		return false;
 
-- 
2.6.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-04-11  8:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11  8:13 [PATCH 00/21] Optimise page alloc/free fast paths Mel Gorman
2016-04-11  8:13 ` Mel Gorman [this message]
2016-04-11  8:13 ` [PATCH 02/22] mm, page_alloc: Use new PageAnonHead helper in the free page fast path Mel Gorman
2016-04-11  8:13 ` [PATCH 03/22] mm, page_alloc: Reduce branches in zone_statistics Mel Gorman
2016-04-11  8:13 ` [PATCH 04/22] mm, page_alloc: Inline zone_statistics Mel Gorman
2016-04-11  8:13 ` [PATCH 05/22] mm, page_alloc: Inline the fast path of the zonelist iterator Mel Gorman
2016-04-11  8:13 ` [PATCH 06/22] mm, page_alloc: Use __dec_zone_state for order-0 page allocation Mel Gorman
2016-04-11  8:13 ` [PATCH 07/22] mm, page_alloc: Avoid unnecessary zone lookups during pageblock operations Mel Gorman
2016-04-11  8:13 ` [PATCH 08/22] mm, page_alloc: Convert alloc_flags to unsigned Mel Gorman
2016-04-11  8:13 ` [PATCH 09/22] mm, page_alloc: Convert nr_fair_skipped to bool Mel Gorman
2016-04-11  8:13 ` [PATCH 10/22] mm, page_alloc: Remove unnecessary local variable in get_page_from_freelist Mel Gorman
2016-04-11  8:13 ` [PATCH 11/22] mm, page_alloc: Remove unnecessary initialisation " Mel Gorman
2016-04-11  8:13 ` [PATCH 12/22] mm, page_alloc: Remove unnecessary initialisation from __alloc_pages_nodemask() Mel Gorman
2016-04-11  8:13 ` [PATCH 13/22] mm, page_alloc: Remove redundant check for empty zonelist Mel Gorman
2016-04-11  8:13 ` [PATCH 14/22] mm, page_alloc: Simplify last cpupid reset Mel Gorman
2016-04-11  8:13 ` [PATCH 15/22] mm, page_alloc: Move might_sleep_if check to the allocator slowpath Mel Gorman
2016-04-11  8:13 ` [PATCH 16/22] mm, page_alloc: Move __GFP_HARDWALL modifications out of the fastpath Mel Gorman
2016-04-11  8:13 ` [PATCH 17/22] mm, page_alloc: Reduce cost of fair zone allocation policy retry Mel Gorman
2016-04-11  8:13 ` [PATCH 18/22] mm, page_alloc: Shortcut watermark checks for order-0 pages Mel Gorman
2016-04-11  8:13 ` [PATCH 19/22] mm, page_alloc: Avoid looking up the first zone in a zonelist twice Mel Gorman
2016-04-11  8:13 ` [PATCH 20/22] mm, page_alloc: Check multiple page fields with a single branch Mel Gorman
2016-04-11  8:13 ` [PATCH 21/22] cpuset: use static key better and convert to new API Mel Gorman
2016-04-11  8:18 ` [PATCH 00/21] Optimise page alloc/free fast paths Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460362424-26369-2-git-send-email-mgorman@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).