From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>, Linux-MM <linux-mm@kvack.org>
Cc: Rik van Riel <riel@surriel.com>, Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 21/28] mm, vmscan: Update classzone_idx if buffer_heads_over_limit
Date: Tue, 12 Apr 2016 11:44:57 +0100 [thread overview]
Message-ID: <1460457904-754-8-git-send-email-mgorman@techsingularity.net> (raw)
In-Reply-To: <1460457904-754-1-git-send-email-mgorman@techsingularity.net>
If buffer heads are over the limit then the direct reclaim gfp_mask
is promoted to __GFP_HIGHMEM so that lowmem is indirectly freed. With
node-based reclaim, it is also required that the classzone_idx be updated
or the pages will be skipped.
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
mm/vmscan.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index e2238ab6ae53..9f2376ad4ce3 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2573,8 +2573,10 @@ static bool shrink_zones(struct zonelist *zonelist, struct scan_control *sc,
* highmem pages could be pinning lowmem pages storing buffer_heads
*/
orig_mask = sc->gfp_mask;
- if (buffer_heads_over_limit)
+ if (buffer_heads_over_limit) {
sc->gfp_mask |= __GFP_HIGHMEM;
+ classzone_idx = gfp_zone(sc->gfp_mask);
+ }
for_each_zone_zonelist_nodemask(zone, z, zonelist,
classzone_idx, sc->nodemask) {
--
2.6.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-04-12 10:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 10:25 [PATCH 00/28] Move LRU page reclaim from zones to nodes v4 Mel Gorman
2016-04-12 10:25 ` [PATCH 01/28] mm, page_alloc: Use ac->classzone_idx instead of zone_idx(preferred_zone) Mel Gorman
2016-04-12 10:25 ` [PATCH 02/28] mm, vmstat: Add infrastructure for per-node vmstats Mel Gorman
2016-04-12 10:25 ` [PATCH 03/28] mm, vmscan: Move lru_lock to the node Mel Gorman
2016-04-12 10:25 ` [PATCH 04/28] mm, vmscan: Move LRU lists to node Mel Gorman
2016-04-12 10:26 ` [PATCH 05/28] mm, vmscan: Begin reclaiming pages on a per-node basis Mel Gorman
2016-04-12 10:26 ` [PATCH 06/28] mm, vmscan: Have kswapd only scan based on the highest requested zone Mel Gorman
2016-04-12 10:26 ` [PATCH 07/28] mm, vmscan: Make kswapd reclaim in terms of nodes Mel Gorman
2016-04-12 10:26 ` [PATCH 08/28] mm, vmscan: Remove balance gap Mel Gorman
2016-04-12 10:26 ` [PATCH 09/28] mm, vmscan: Simplify the logic deciding whether kswapd sleeps Mel Gorman
2016-04-12 10:26 ` [PATCH 10/28] mm, vmscan: By default have direct reclaim only shrink once per node Mel Gorman
2016-04-12 10:26 ` [PATCH 11/28] mm, vmscan: Clear congestion, dirty and need for compaction on a per-node basis Mel Gorman
2016-04-12 10:26 ` [PATCH 12/28] mm: vmscan: Do not reclaim from kswapd if there is any eligible zone Mel Gorman
2016-04-12 10:26 ` [PATCH 13/28] mm, vmscan: Make shrink_node decisions more node-centric Mel Gorman
2016-04-12 10:44 ` [PATCH 14/28] mm, memcg: Move memcg limit enforcement from zones to nodes Mel Gorman
2016-04-12 10:44 ` [PATCH 15/28] mm, workingset: Make working set detection node-aware Mel Gorman
2016-04-12 10:44 ` [PATCH 16/28] mm, page_alloc: Consider dirtyable memory in terms of nodes Mel Gorman
2016-04-12 10:44 ` [PATCH 17/28] mm: Move page mapped accounting to the node Mel Gorman
2016-04-12 10:44 ` [PATCH 18/28] mm: Rename NR_ANON_PAGES to NR_ANON_MAPPED Mel Gorman
2016-04-12 10:44 ` [PATCH 19/28] mm: Move most file-based accounting to the node Mel Gorman
2016-04-12 10:44 ` [PATCH 20/28] mm: Move vmscan writes and file write " Mel Gorman
2016-04-12 10:44 ` Mel Gorman [this message]
2016-04-12 10:44 ` [PATCH 22/28] mm, vmscan: Only wakeup kswapd once per node for the requested classzone Mel Gorman
2016-04-12 10:44 ` [PATCH 23/28] mm: Convert zone_reclaim to node_reclaim Mel Gorman
2016-04-12 10:45 ` [PATCH 24/28] mm, vmscan: Add classzone information to tracepoints Mel Gorman
2016-04-12 10:45 ` [PATCH 25/28] mm, page_alloc: Remove fair zone allocation policy Mel Gorman
2016-04-12 10:45 ` [PATCH 26/28] mm: page_alloc: Cache the last node whose dirty limit is reached Mel Gorman
2016-04-12 10:45 ` [PATCH 27/28] mm: vmstat: Replace __count_zone_vm_events with a zone id equivalent Mel Gorman
2016-04-12 10:46 ` [PATCH 28/28] mm: vmstat: Account per-zone stalls and pages skipped during reclaim Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460457904-754-8-git-send-email-mgorman@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).