From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by kanga.kvack.org (Postfix) with ESMTP id CA8FD6B007E for ; Wed, 11 May 2016 05:22:39 -0400 (EDT) Received: by mail-pa0-f69.google.com with SMTP id xm6so53399812pab.3 for ; Wed, 11 May 2016 02:22:39 -0700 (PDT) Received: from mail-pa0-x244.google.com (mail-pa0-x244.google.com. [2607:f8b0:400e:c03::244]) by mx.google.com with ESMTPS id e184si8362882pfe.144.2016.05.11.02.22.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 May 2016 02:22:39 -0700 (PDT) Received: by mail-pa0-x244.google.com with SMTP id zy2so3772747pac.2 for ; Wed, 11 May 2016 02:22:39 -0700 (PDT) From: Oliver O'Halloran Subject: [PATCH v2] powerpc/mm: Ensure "special" zones are empty Date: Wed, 11 May 2016 19:22:18 +1000 Message-Id: <1462958539-25552-1-git-send-email-oohall@gmail.com> In-Reply-To: <3r3fQw4Xbnz9t79@ozlabs.org> References: <3r3fQw4Xbnz9t79@ozlabs.org> In-Reply-To: <3r3fQw4Xbnz9t79@ozlabs.org> References: <3r3fQw4Xbnz9t79@ozlabs.org> Sender: owner-linux-mm@kvack.org List-ID: To: linuxppc-dev@lists.ozlabs.org Cc: bsingharora@gmail.com, Oliver O'Halloran , linux-mm@kvack.org The mm zone mechanism was traditionally used by arch specific code to partition memory into allocation zones. However there are several zones that are managed by the mm subsystem rather than the architecture. Most architectures set the max PFN of these special zones to zero, however on powerpc we set them to ~0ul. This, in conjunction with a bug in free_area_init_nodes() results in all of system memory being placed in ZONE_DEVICE when enabled. Device memory cannot be used for regular kernel memory allocations so this will cause a kernel panic at boot. Given the planned addition of more mm managed zones (ZONE_CMA) we should aim to be consistent with every other architecture and set the max PFN for these zones to zero. Signed-off-by: Oliver O'Halloran Reviewed-by: Balbir Singh Cc: linux-mm@kvack.org --- arch/powerpc/mm/mem.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c index 879e0bc6f82e..f35e6605c422 100644 --- a/arch/powerpc/mm/mem.c +++ b/arch/powerpc/mm/mem.c @@ -239,8 +239,14 @@ static int __init mark_nonram_nosave(void) static bool zone_limits_final; +/* + * The memory zones past TOP_ZONE are managed by generic mm code. + * These should be set to zero since that's what every other + * architecture does. + */ static unsigned long max_zone_pfns[MAX_NR_ZONES] = { - [0 ... MAX_NR_ZONES - 1] = ~0UL + [0 ... TOP_ZONE ] = ~0UL, + [TOP_ZONE + 1 ... MAX_NR_ZONES - 1] = 0 }; /* -- 2.5.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org