linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: <chenjie6@huawei.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	David.Woodhouse@intel.com, zhihui.gao@huawei.com,
	panxuesong@huawei.com
Cc: akpm@linux-foundation.org, chenjie <chenjie6@huawei.com>
Subject: [PATCH] memory:bugxfix panic on cat or write /dev/kmem
Date: Fri, 24 Jun 2016 01:30:10 +0800	[thread overview]
Message-ID: <1466703010-32242-1-git-send-email-chenjie6@huawei.com> (raw)

From: chenjie <chenjie6@huawei.com>

cat /dev/kmem and echo > /dev/kmem will lead panic

Signed-off-by: chenjie <chenjie6@huawei.com>
---
 drivers/char/mem.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/char/mem.c b/drivers/char/mem.c
index 71025c2..4bdde28 100644
--- a/drivers/char/mem.c
+++ b/drivers/char/mem.c
@@ -412,6 +412,8 @@ static ssize_t read_kmem(struct file *file, char __user *buf,
 			 * by the kernel or data corruption may occur
 			 */
 			kbuf = xlate_dev_kmem_ptr((void *)p);
+			if (!kbuf)
+				return -EFAULT;
 
 			if (copy_to_user(buf, kbuf, sz))
 				return -EFAULT;
@@ -482,6 +484,11 @@ static ssize_t do_write_kmem(unsigned long p, const char __user *buf,
 		 * corruption may occur.
 		 */
 		ptr = xlate_dev_kmem_ptr((void *)p);
+		if (!ptr) {
+			if (written)
+				break;
+			return -EFAULT;
+		}
 
 		copied = copy_from_user(ptr, buf, sz);
 		if (copied) {
-- 
1.8.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2016-06-23  9:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23 17:30 chenjie6 [this message]
2016-06-23 12:42 ` [PATCH] memory:bugxfix panic on cat or write /dev/kmem Michal Hocko
2016-06-25  1:20   ` Chenjie (K)
2016-06-27 11:37     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466703010-32242-1-git-send-email-chenjie6@huawei.com \
    --to=chenjie6@huawei.com \
    --cc=David.Woodhouse@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=panxuesong@huawei.com \
    --cc=zhihui.gao@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).