From: Ganesh Mahendran <opensource.ganesh@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, minchan@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org,
mingo@redhat.com, Ganesh Mahendran <opensource.ganesh@gmail.com>
Subject: [PATCH 3/8] mm/zsmalloc: take obj index back from find_alloced_obj
Date: Fri, 1 Jul 2016 14:41:01 +0800 [thread overview]
Message-ID: <1467355266-9735-3-git-send-email-opensource.ganesh@gmail.com> (raw)
In-Reply-To: <1467355266-9735-1-git-send-email-opensource.ganesh@gmail.com>
the obj index value should be updated after return from
find_alloced_obj()
Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
---
mm/zsmalloc.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 405baa5..5c96ed1 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1744,15 +1744,16 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,
* return handle.
*/
static unsigned long find_alloced_obj(struct size_class *class,
- struct page *page, int index)
+ struct page *page, int *index)
{
unsigned long head;
int offset = 0;
+ int objidx = *index;
unsigned long handle = 0;
void *addr = kmap_atomic(page);
offset = get_first_obj_offset(page);
- offset += class->size * index;
+ offset += class->size * objidx;
while (offset < PAGE_SIZE) {
head = obj_to_head(page, addr + offset);
@@ -1764,9 +1765,11 @@ static unsigned long find_alloced_obj(struct size_class *class,
}
offset += class->size;
- index++;
+ objidx++;
}
+ *index = objidx;
+
kunmap_atomic(addr);
return handle;
}
@@ -1794,11 +1797,11 @@ static int migrate_zspage(struct zs_pool *pool, struct size_class *class,
unsigned long handle;
struct page *s_page = cc->s_page;
struct page *d_page = cc->d_page;
- unsigned long index = cc->index;
+ unsigned int index = cc->index;
int ret = 0;
while (1) {
- handle = find_alloced_obj(class, s_page, index);
+ handle = find_alloced_obj(class, s_page, &index);
if (!handle) {
s_page = get_next_page(s_page);
if (!s_page)
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-01 6:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 6:40 [PATCH 1/8] mm/zsmalloc: modify zs compact trace interface Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 2/8] mm/zsmalloc: add per class compact trace event Ganesh Mahendran
2016-07-03 23:49 ` Minchan Kim
2016-07-04 3:12 ` Ganesh Mahendran
2016-07-01 6:41 ` Ganesh Mahendran [this message]
2016-07-03 23:57 ` [PATCH 3/8] mm/zsmalloc: take obj index back from find_alloced_obj Minchan Kim
2016-07-04 3:23 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 4/8] mm/zsmalloc: use class->objs_per_zspage to get num of max objects Ganesh Mahendran
2016-07-03 23:58 ` Minchan Kim
2016-07-01 6:41 ` [PATCH 5/8] mm/zsmalloc: avoid calculate max objects of zspage twice Ganesh Mahendran
2016-07-04 0:03 ` Minchan Kim
2016-07-04 3:26 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 6/8] mm/zsmalloc: keep comments consistent with code Ganesh Mahendran
2016-07-04 0:05 ` Minchan Kim
2016-07-04 3:32 ` Ganesh Mahendran
2016-07-01 6:41 ` [PATCH 7/8] mm/zsmalloc: add __init,__exit attribute Ganesh Mahendran
2016-07-04 0:09 ` Minchan Kim
2016-07-01 6:41 ` [PATCH 8/8] mm/zsmalloc: use helper to clear page->flags bit Ganesh Mahendran
2016-07-04 0:11 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467355266-9735-3-git-send-email-opensource.ganesh@gmail.com \
--to=opensource.ganesh@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=ngupta@vflare.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).