From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FDB0C678D5 for ; Tue, 7 Mar 2023 10:43:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 302E96B0071; Tue, 7 Mar 2023 05:43:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B32B6B0072; Tue, 7 Mar 2023 05:43:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 155A7280001; Tue, 7 Mar 2023 05:43:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0869A6B0071 for ; Tue, 7 Mar 2023 05:43:02 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DDEDAAB1EB for ; Tue, 7 Mar 2023 10:43:01 +0000 (UTC) X-FDA: 80541764562.08.03C3568 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id C1303C0021 for ; Tue, 7 Mar 2023 10:42:58 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ga+DmfsL; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678185778; a=rsa-sha256; cv=none; b=VaiK3GSy3ZL+c8V1o0x4fz5lYz3Q9g6GxA8UdRTfvjsqcY062GSYSbOoZ0EJz5ySil1xz5 m9g0yG/BmPQwErvW25UDH/gvRLoYa35qZ+r4ELSMpwUkmVwTar1GJSnQHp6CjQjBOEkuHK 2Q++BWNfTRTdi0/sFYegjLcu4RLA7dw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ga+DmfsL; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678185778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hkSFfGl4soWJh275ABriCY4OJqXhUGnQB2a/+uhCoY0=; b=iGhikie1GpTa7Z64dftDGVBhaywrhxGvKq1/q/IfphVK87rxJ1lbwCqyw7GzHfPUPmu3mE /o7mAhyFS7paxMCaZiRHdhP6VARxTrPmDPt7Wt89G0QZoLyVRRprXmfM1mMG4nbRxE4xci KR/snfmc23VJh6ACCOUY408TWs82b10= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678185778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hkSFfGl4soWJh275ABriCY4OJqXhUGnQB2a/+uhCoY0=; b=Ga+DmfsLH/bGC5x6YuRDSY6nFAtYaB1+RtPKnHVp7JAen3iWUZfsWHZx5SDyf75pKaXM1w PHtFPV4J9CNuUPVROJ0JSfTevnaU+etTWHkp/o0iRWP9jF6OzdO/OWd3PT1CSx1q1uhVq9 n4grMkvv0QcSBMxqKbi4Pl51Ez1DL8c= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-482-PvOE4oC9PnSuKpMeVBvJ7w-1; Tue, 07 Mar 2023 05:42:56 -0500 X-MC-Unique: PvOE4oC9PnSuKpMeVBvJ7w-1 Received: by mail-wm1-f70.google.com with SMTP id t1-20020a7bc3c1000000b003dfe223de49so8075105wmj.5 for ; Tue, 07 Mar 2023 02:42:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678185776; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hkSFfGl4soWJh275ABriCY4OJqXhUGnQB2a/+uhCoY0=; b=cadG2fqPivRPrTGp4uUlNcFyqZBfNkdJd8z2VsIF4S3bAYzeoIFg4+frxkvLJwI4r7 1uFnloqCxDJKnyEfK5jDngNsc8cmnyIblmTFU/cF3tBVgIyzd1GSwQiX3ZJdYOp5RtMB ogVTKhS880kbjQ9eUBgZSSbFCSKgZrmDlHo1Yw4QoCgMH8GJ6OhK81i/3LmtpIKH7CL5 qubqfLhCq4i/fEeLleOeGJMjEApL347N/F4IkYYJjkLo/pDJ2fkTYuHnSluEIGCBvZ3b YZnaYYSIoe3F63zFcCrUdzJg8xZCKqXeGt3InxcxYRt9sXNrVUdJa0bXfAUAZWrFlCsD SqLA== X-Gm-Message-State: AO0yUKWFGs1BUZ5tGzemt5dJ9+irou7VAQksENVOg6eEydNKDN8clHBN xvgPD8KWBh8Q1yeHolHlEoipLQzEMF3OEvJEI8rAi6fjm0gigeSOyWOMGtEQi+3FoPSWoP8k7Lz osg4p+DBIoj0= X-Received: by 2002:a05:600c:4687:b0:3e2:201a:5bcc with SMTP id p7-20020a05600c468700b003e2201a5bccmr12423834wmo.33.1678185775726; Tue, 07 Mar 2023 02:42:55 -0800 (PST) X-Google-Smtp-Source: AK7set9qXIxQ9yHJKIfCwELq7tomci3ICaGJvPRazUwNeud11Cy9qjJe48+RLn1VklykElHsR9Tgqw== X-Received: by 2002:a05:600c:4687:b0:3e2:201a:5bcc with SMTP id p7-20020a05600c468700b003e2201a5bccmr12423799wmo.33.1678185775374; Tue, 07 Mar 2023 02:42:55 -0800 (PST) Received: from ?IPV6:2003:cb:c707:a100:e20:41da:c49b:8974? (p200300cbc707a1000e2041dac49b8974.dip0.t-ipconnect.de. [2003:cb:c707:a100:e20:41da:c49b:8974]) by smtp.gmail.com with ESMTPSA id h8-20020a5d5048000000b002c592535839sm12176234wrt.17.2023.03.07.02.42.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Mar 2023 02:42:54 -0800 (PST) Message-ID: <1467f1b3-a529-50d3-9539-1056b2912d48@redhat.com> Date: Tue, 7 Mar 2023 11:42:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 22/41] mm/mmap: Add shadow stack pages to memory accounting To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com Cc: Yu-cheng Yu References: <20230227222957.24501-1-rick.p.edgecombe@intel.com> <20230227222957.24501-23-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230227222957.24501-23-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C1303C0021 X-Rspamd-Server: rspam01 X-Stat-Signature: f9qj7hupf3bxtahrgqxg711p1sjrfo8g X-HE-Tag: 1678185778-402203 X-HE-Meta: U2FsdGVkX1+c4DBBZoiMBDVKtHwF0oWTewdsjP6r3iefrhOwFKuTLCUi9TUdJrXEsvC1Kyt483jm9j3Vvi2F/xbUSKacAAIz3+9WjyQZrNbK7Ph6fn0D5HGUuA83tGl8c4w/mT8b6Q9Mo+sbOj2SJWfy8ijoqvy6JaycClXn5EOrPG82BRFLXo29kfZ1RPhjByI78C4XbuTO6w4adpEZCbSWrjJBmF5lzupo68tp2PHLX3deKtiROihCPxS3eESHqORJtJzGSjzAh/GhDgD6f7XgLBrO+XT1ikoGAnlatrPW1giQwDL7TFDJV0ffu+uiXW1iliK9kpB34tDEVwvGp9ulkAnxIio/HzZZ9QAOoFz7SygzTaDmHnOjgJOfLx+Kd7gS46AaOUWkUSvOifEiJDEEaj3MHbRbyQhh4v5cl3t8Hpnktne5hSrMAkt0Z0kdi7xrBm1K+4DjiVpXKaCG0KDMCX9JV2DDpl0T3h9xTmCvE03g5rXno+2I40cWXgDbtFTyxjS3Cm5H7v4PbCeMuPB2ATVHEh5EBejVSYJFqgQ+06iJVlV+uHWq2YugTQCeGOIobc4729kcNlyXlGx+PwJ3ze43jN19brNrFf0lYqy15bXhoHmP9rOpX456njqbBuvO0VvQLCc8SU7oKaNJs0kxcZG19HCTHP6SHWbAIMhM5XlNA9h2B4cjFIN3grPgJF+KIj7V1F785NaWfKeWToUlks/rsmDutwWwlcXtOV8Uvx2+UJinvGBQnpIE7UqLMMB1JobQ9I1I2UacRohJ3qcWMeMSByDos7Zb3bHlP50CRuiyUuExVlDKNcwQToaYR3OU2DwaKRGk4+8c9KE5WTu4LphSm2+lMTHqZMdwtBBJDMqv9SK6rC7UxkFzlGXlrDisvgB6pHtaPGBKNP7zWyzE78A/VCsoPC1KWHaHgwbF8JslOOLPU5SLc7RgF7H4hpTwkh7t2RvGE3myOcL spJ/vzyj qFlZ3lf4G9WM7XKmzMcnCOuaaeHA/i0g54i4TR7zypKL01f/ywi22/v5Hs32c973MFITb1lCiwioVH5536BLl1a/f8q0n2MrDTKzwbfKfUPTct5l4ltz1AbcleML9PkOhSfV7TW+6tWxxYt8duZHoGo+fgwNB07uTt290dGxhajxz2UeSZn06d9ei4pEfELYTaT/UcZxaJKkD7SkOajeqg2kbJv4haxbNQnHe0aza8iFufbVYo6kwPa7T8s1XqLj3U9pt29vJEO8uYBc66clNTXHGcBFupb2+7P1xQ2Or2AK/vN63qMCaTKbcofbvR5wmxc+MWr668Tfeims+4Wpp4Zq/+NXLI71YnDYzF84nu/q/35SXzwwoReXfQcxz06DBofnxRoESJzhtujAQ9ucoKLGY5nA4MzuVtNdqmoXQpGKoFTB13xWbAUuxQhjVCk3M+7YleMiOUEFVAKmytLkLlbPwzwArYQZqXvq2PHbfv1pxGSHZG5zLp5+SqW+TF8xOKKCWsQV+uyZ8TW8x4f26ALYw2V+BEqrvZkZp7IZ1vhfj848Mj2my4RusFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.02.23 23:29, Rick Edgecombe wrote: > From: Yu-cheng Yu > > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > Account shadow stack pages to stack memory. Do this by adding a > VM_SHADOW_STACK check in is_stack_mapping(). > > Tested-by: Pengfei Xu > Tested-by: John Allen > Tested-by: Kees Cook > Acked-by: Mike Rapoport (IBM) > Reviewed-by: Kees Cook > Signed-off-by: Yu-cheng Yu > Co-developed-by: Rick Edgecombe > Signed-off-by: Rick Edgecombe > Cc: Kees Cook > > --- > v7: > - Change is_stack_mapping() to know about VM_SHADOW_STACK so the > additions in vm_stat_account() can be dropped. (David Hildenbrand) > > v3: > - Remove unneeded VM_SHADOW_STACK check in accountable_mapping() > (Kirill) > > v2: > - Remove is_shadow_stack_mapping() and just change it to directly bitwise > and VM_SHADOW_STACK. > > Yu-cheng v26: > - Remove redundant #ifdef CONFIG_MMU. > > Yu-cheng v25: > - Remove #ifdef CONFIG_ARCH_HAS_SHADOW_STACK for is_shadow_stack_mapping(). > --- > mm/internal.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 7920a8b7982e..1d13d5580f64 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -491,14 +491,14 @@ static inline bool is_exec_mapping(vm_flags_t flags) > } > > /* > - * Stack area - automatically grows in one direction > + * Stack area Maybe "Stack area (including shadow stacks)" Acked-by: David Hildenbrand -- Thanks, David / dhildenb