From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 1/5] mm, vmscan: make shrink_node decisions more node-centric -fix
Date: Fri, 15 Jul 2016 14:09:21 +0100 [thread overview]
Message-ID: <1468588165-12461-2-git-send-email-mgorman@techsingularity.net> (raw)
In-Reply-To: <1468588165-12461-1-git-send-email-mgorman@techsingularity.net>
The patch "mm, vmscan: make shrink_node decisions more node-centric"
checks whether compaction is suitable on empty nodes. This is expensive
rather than wrong but is worth fixing.
This is a fix to the mmotm patch
mm-vmscan-make-shrink_node-decisions-more-node-centric.patch
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
mm/vmscan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 864a3b1e5f8b..4fdb9e419588 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2408,6 +2408,8 @@ static inline bool should_continue_reclaim(struct pglist_data *pgdat,
/* If compaction would go ahead or the allocation would succeed, stop */
for (z = 0; z <= sc->reclaim_idx; z++) {
struct zone *zone = &pgdat->node_zones[z];
+ if (!populated_zone(zone))
+ continue;
switch (compaction_suitable(zone, sc->order, 0, sc->reclaim_idx)) {
case COMPACT_PARTIAL:
--
2.6.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-15 13:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 13:09 [PATCH 0/5] Follow-up fixes to node-lru series v2 Mel Gorman
2016-07-15 13:09 ` Mel Gorman [this message]
2016-07-15 15:42 ` [PATCH 1/5] mm, vmscan: make shrink_node decisions more node-centric -fix Minchan Kim
2016-07-18 16:14 ` Johannes Weiner
2016-07-15 13:09 ` [PATCH 2/5] mm, vmscan: avoid passing in classzone_idx unnecessarily to compaction_ready -fix Mel Gorman
2016-07-15 15:50 ` Minchan Kim
2016-07-18 16:15 ` Johannes Weiner
2016-07-15 13:09 ` [PATCH 3/5] mm, pagevec: Release/reacquire lru_lock on pgdat change Mel Gorman
2016-07-15 15:53 ` Minchan Kim
2016-07-18 16:20 ` Johannes Weiner
2016-07-15 13:09 ` [PATCH 4/5] mm: show node_pages_scanned per node, not zone Mel Gorman
2016-07-16 10:14 ` Minchan Kim
2016-07-15 13:09 ` [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg Mel Gorman
2016-07-15 14:45 ` Minchan Kim
2016-07-15 15:01 ` Mel Gorman
2016-07-15 15:54 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468588165-12461-2-git-send-email-mgorman@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).