From: Ganesh Mahendran <opensource.ganesh@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, mgorman@techsingularity.net,
minchan@kernel.org, hannes@cmpxchg.org, mhocko@suse.com,
riel@redhat.com, dan.j.williams@intel.com,
vdavydov@virtuozzo.com, kirill.shutemov@linux.intel.com,
cl@linux.com, hughd@google.com,
Ganesh Mahendran <opensource.ganesh@gmail.com>
Subject: [PATCH] mm/vmscan: remove pglist_data->inactive_ratio
Date: Tue, 19 Jul 2016 10:07:29 +0800 [thread overview]
Message-ID: <1468894049-786-1-git-send-email-opensource.ganesh@gmail.com> (raw)
In patch [1], the inactive_ratio is now automatically calculated
in inactive_list_is_low(). So there is no need to keep inactive_ratio
in pglist_data, and shown in zoneinfo.
[1] mm: vmscan: reduce size of inactive file list
Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
---
include/linux/mmzone.h | 6 ------
mm/vmscan.c | 2 +-
mm/vmstat.c | 6 ++----
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index a3b7f45..b3ade54 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -700,12 +700,6 @@ typedef struct pglist_data {
/* Fields commonly accessed by the page reclaim scanner */
struct lruvec lruvec;
- /*
- * The target ratio of ACTIVE_ANON to INACTIVE_ANON pages on
- * this node's LRU. Maintained by the pageout code.
- */
- unsigned int inactive_ratio;
-
unsigned long flags;
ZONE_PADDING(_pad2_)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 429bf3a..3c1de58 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1915,7 +1915,7 @@ static void shrink_active_list(unsigned long nr_to_scan,
* page has a chance to be referenced again before it is reclaimed.
*
* The inactive_ratio is the target ratio of ACTIVE to INACTIVE pages
- * on this LRU, maintained by the pageout code. A zone->inactive_ratio
+ * on this LRU, maintained by the pageout code. A inactive_ratio
* of 3 means 3:1 or 25% of the pages are kept on the inactive list.
*
* total target max
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 91ecca9..74a0eca 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1491,11 +1491,9 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat,
}
seq_printf(m,
"\n node_unreclaimable: %u"
- "\n start_pfn: %lu"
- "\n node_inactive_ratio: %u",
+ "\n start_pfn: %lu",
!pgdat_reclaimable(zone->zone_pgdat),
- zone->zone_start_pfn,
- zone->zone_pgdat->inactive_ratio);
+ zone->zone_start_pfn);
seq_putc(m, '\n');
}
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2016-07-19 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 2:07 Ganesh Mahendran [this message]
2016-07-19 7:34 ` [PATCH] mm/vmscan: remove pglist_data->inactive_ratio Michal Hocko
2016-07-21 8:39 ` Ganesh Mahendran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468894049-786-1-git-send-email-opensource.ganesh@gmail.com \
--to=opensource.ganesh@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).