From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f200.google.com (mail-io0-f200.google.com [209.85.223.200]) by kanga.kvack.org (Postfix) with ESMTP id 28BAE6B0253 for ; Wed, 3 Aug 2016 17:49:10 -0400 (EDT) Received: by mail-io0-f200.google.com with SMTP id m130so475981971ioa.1 for ; Wed, 03 Aug 2016 14:49:10 -0700 (PDT) Received: from mail-io0-x244.google.com (mail-io0-x244.google.com. [2607:f8b0:4001:c06::244]) by mx.google.com with ESMTPS id m69si9820606ioo.203.2016.08.03.14.49.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Aug 2016 14:49:09 -0700 (PDT) Received: by mail-io0-x244.google.com with SMTP id y195so19034601iod.0 for ; Wed, 03 Aug 2016 14:49:09 -0700 (PDT) From: Nicholas Krause Subject: [PATCH] fs:Fix kmemleak leak warning in getname_flags about working on unitialized memory Date: Wed, 3 Aug 2016 17:48:16 -0400 Message-Id: <1470260896-31767-1-git-send-email-xerofoify@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: viro@zeniv.linux.org.uk Cc: akpm@linux-foundation.org, msalter@redhat.com, kuleshovmail@gmail.com, david.vrabel@citrix.com, vbabka@suse.cz, ard.biesheuvel@linaro.org, jgross@suse.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org This fixes a kmemleak leak warning complaining about working on unitializied memory as found in the function, getname_flages. Seems that we are indeed working on unitialized memory, as the filename char pointer is never made to point to the filname structure's result member for holding it's name, fix this by using memcpy to copy the filname structure pointer's, name to the char pointer passed to this function. Signed-off-by: Nicholas Krause --- fs/namei.c | 1 + mm/early_ioremap.c | 1 + 2 files changed, 2 insertions(+) diff --git a/fs/namei.c b/fs/namei.c index c386a32..6b18d57 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -196,6 +196,7 @@ getname_flags(const char __user *filename, int flags, int *empty) } } + memcpy((char *)result->name, filename, len); result->uptr = filename; result->aname = NULL; audit_getname(result); diff --git a/mm/early_ioremap.c b/mm/early_ioremap.c index 6d5717b..92c5235 100644 --- a/mm/early_ioremap.c +++ b/mm/early_ioremap.c @@ -215,6 +215,7 @@ early_ioremap(resource_size_t phys_addr, unsigned long size) void __init * early_memremap(resource_size_t phys_addr, unsigned long size) { + dump_stack(); return (__force void *)__early_ioremap(phys_addr, size, FIXMAP_PAGE_NORMAL); } -- 2.7.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org