* [PATCH 1/8] mm/swap: Fix kernel message in swap_info_get()
@ 2016-09-27 17:17 Tim Chen
2016-10-07 8:11 ` Rik van Riel
0 siblings, 1 reply; 2+ messages in thread
From: Tim Chen @ 2016-09-27 17:17 UTC (permalink / raw)
To: Andrew Morton
Cc: dave.hansen, andi.kleen, aaron.lu, linux-mm, linux-kernel,
Huang Ying, Hugh Dickins, Shaohua Li, Minchan Kim, Rik van Riel,
Andrea Arcangeli, Kirill A . Shutemov, Vladimir Davydov,
Johannes Weiner, Michal Hocko
From: "Huang, Ying" <ying.huang@intel.com>
swap_info_get() is used not only in swap free code path but also in
page_swapcount(), etc. So the original kernel message in
swap_info_get() is not correct now. Fix it via replacing "swap_free" to
"swap_info_get" in the message.
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
---
mm/swapfile.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 8f1b97d..f23d243 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -753,16 +753,16 @@ static struct swap_info_struct *swap_info_get(swp_entry_t entry)
return p;
bad_free:
- pr_err("swap_free: %s%08lx\n", Unused_offset, entry.val);
+ pr_err("swap_info_get: %s%08lx\n", Unused_offset, entry.val);
goto out;
bad_offset:
- pr_err("swap_free: %s%08lx\n", Bad_offset, entry.val);
+ pr_err("swap_info_get: %s%08lx\n", Bad_offset, entry.val);
goto out;
bad_device:
- pr_err("swap_free: %s%08lx\n", Unused_file, entry.val);
+ pr_err("swap_info_get: %s%08lx\n", Unused_file, entry.val);
goto out;
bad_nofile:
- pr_err("swap_free: %s%08lx\n", Bad_file, entry.val);
+ pr_err("swap_info_get: %s%08lx\n", Bad_file, entry.val);
out:
return NULL;
}
--
2.5.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/8] mm/swap: Fix kernel message in swap_info_get()
2016-09-27 17:17 [PATCH 1/8] mm/swap: Fix kernel message in swap_info_get() Tim Chen
@ 2016-10-07 8:11 ` Rik van Riel
0 siblings, 0 replies; 2+ messages in thread
From: Rik van Riel @ 2016-10-07 8:11 UTC (permalink / raw)
To: tim.c.chen, Andrew Morton
Cc: dave.hansen, andi.kleen, aaron.lu, linux-mm, linux-kernel,
Huang Ying, Hugh Dickins, Shaohua Li, Minchan Kim,
Andrea Arcangeli, Kirill A . Shutemov, Vladimir Davydov,
Johannes Weiner, Michal Hocko
On Tue, 2016-09-27 at 10:17 -0700, Tim Chen wrote:
> From: "Huang, Ying" <ying.huang@intel.com>
>
> swap_info_get() is used not only in swap free code path but also in
> page_swapcount(), etc.A A So the original kernel message in
> swap_info_get() is not correct now.A A Fix it via replacing "swap_free"
> to
> "swap_info_get" in the message.
>
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-07 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-27 17:17 [PATCH 1/8] mm/swap: Fix kernel message in swap_info_get() Tim Chen
2016-10-07 8:11 ` Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).