From: Christoph Hellwig <hch@lst.de>
To: akpm@linux-foundation.org
Cc: joelaf@google.com, jszhang@marvell.com, chris@chris-wilson.co.uk,
joaodias@google.com, linux-mm@kvack.org,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/7] mm: mark all calls into the vmalloc subsystem as potentially sleeping
Date: Sat, 22 Oct 2016 17:17:18 +0200 [thread overview]
Message-ID: <1477149440-12478-6-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1477149440-12478-1-git-send-email-hch@lst.de>
We will take a sleeping lock in later in this series, so this adds the
proper safeguards.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Jisheng Zhang <jszhang@marvell.com>
---
mm/vmalloc.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index bcc1a64..0e7f523 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -365,7 +365,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
BUG_ON(offset_in_page(size));
BUG_ON(!is_power_of_2(align));
- might_sleep_if(gfpflags_allow_blocking(gfp_mask));
+ might_sleep();
va = kmalloc_node(sizeof(struct vmap_area),
gfp_mask & GFP_RECLAIM_MASK, node);
@@ -1037,6 +1037,8 @@ void vm_unmap_aliases(void)
if (unlikely(!vmap_initialized))
return;
+ might_sleep();
+
for_each_possible_cpu(cpu) {
struct vmap_block_queue *vbq = &per_cpu(vmap_block_queue, cpu);
struct vmap_block *vb;
@@ -1080,6 +1082,7 @@ void vm_unmap_ram(const void *mem, unsigned int count)
unsigned long addr = (unsigned long)mem;
struct vmap_area *va;
+ might_sleep();
BUG_ON(!addr);
BUG_ON(addr < VMALLOC_START);
BUG_ON(addr > VMALLOC_END);
@@ -1431,6 +1434,8 @@ struct vm_struct *remove_vm_area(const void *addr)
{
struct vmap_area *va;
+ might_sleep();
+
va = find_vmap_area((unsigned long)addr);
if (va && va->flags & VM_VM_AREA) {
struct vm_struct *vm = va->vm;
--
2.1.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-22 15:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 15:17 reduce latency in __purge_vmap_area_lazy Christoph Hellwig
2016-10-22 15:17 ` [PATCH 1/7] mm: remove free_unmap_vmap_area_noflush Christoph Hellwig
2016-10-22 15:17 ` [PATCH 2/7] mm: remove free_unmap_vmap_area_addr Christoph Hellwig
2016-10-22 15:17 ` [PATCH 3/7] mm: refactor __purge_vmap_area_lazy Christoph Hellwig
2016-10-22 15:17 ` [PATCH 4/7] mm: defer vmalloc from atomic context Christoph Hellwig
2016-10-24 15:44 ` Andrey Ryabinin
2016-11-05 3:43 ` Joel Fernandes
2016-11-07 15:01 ` Andrey Ryabinin
2016-11-07 15:09 ` Christoph Hellwig
2016-11-08 15:03 ` Andrey Ryabinin
2016-11-08 15:05 ` [PATCH 1/3] mm/vmalloc: add vfree_atomic() Andrey Ryabinin
2016-11-08 15:05 ` [PATCH 2/3] kernel/fork: use vfree_atomic() to free thread stack Andrey Ryabinin
2016-11-08 15:05 ` [PATCH 3/3] x86/ldt: use vfree_atomic() to free ldt entries Andrey Ryabinin
2016-11-07 16:50 ` [PATCH 4/7] mm: defer vmalloc from atomic context Joel Fernandes
2016-10-22 15:17 ` Christoph Hellwig [this message]
2016-10-22 15:17 ` [PATCH 6/7] mm: turn vmap_purge_lock into a mutex Christoph Hellwig
2016-10-22 15:17 ` [PATCH 7/7] mm: add preempt points into __purge_vmap_area_lazy Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477149440-12478-6-git-send-email-hch@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=joaodias@google.com \
--cc=joelaf@google.com \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).