From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kubakici@wp.pl>, Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-mm@kvack.org
Subject: Re: [RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements)
Date: Thu, 03 Nov 2016 16:48:28 +0100 [thread overview]
Message-ID: <1478188108.4041.7.camel@sipsolutions.net> (raw)
In-Reply-To: <20161102234755.4381f528@jkicinski-Precision-T1700>
Hi,
Sorry for not chipping in earlier - LPC is taking my time.
> > > > Looks like we are missing a kfree(family->attrbuf); on error
> > > > path, but it is not related to Johannes' recent patches.
Actually, I think it *is* related to my patch - I inserted the code
there in the wrong place or so. I'll find a fix for that when I'm back
home, or you (Cong) can submit yours. It wasn't likely that this was
the problem though, since that's just an error path that should never
happen (we have <30 genl families, and a 16-bit space for their IDs)
> I realized that kmemleak is not scanning the __ro_after_init
> section...
> Following patch solves the false positives but I wonder if it's the
> right/acceptable solution.
Hah, makes sense to me, but I guess we really want Catalin to comment
:)
johannes
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-03 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1477312805-7110-1-git-send-email-johannes@sipsolutions.net>
[not found] ` <20161101172840.6d7d6278@jkicinski-Precision-T1700>
[not found] ` <CAM_iQpVeB+2M1MPxjRx++E=q4mDuo7XQqfQn3-160PqG8bNLdQ@mail.gmail.com>
[not found] ` <20161101185630.3c7d326f@jkicinski-Precision-T1700>
[not found] ` <CAM_iQpV_0gyrJC0U6Qk9VSSaNOphe_0tq5o2kt8-r0UybLU5FA@mail.gmail.com>
2016-11-02 23:47 ` [RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements) Jakub Kicinski
2016-11-03 5:40 ` Cong Wang
2016-11-03 15:48 ` Johannes Berg [this message]
2016-11-03 20:49 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478188108.4041.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=catalin.marinas@arm.com \
--cc=kubakici@wp.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).