From: Joe Perches <joe@perches.com>
To: Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andrey Konovalov <andreyknvl@google.com>,
Alexander Potapenko <glider@google.com>,
kasan-dev <kasan-dev@googlegroups.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Kostya Serebryany <kcc@google.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] stacktrace: fix print_stack_trace printing timestamp twice
Date: Fri, 25 Nov 2016 11:35:57 -0800 [thread overview]
Message-ID: <1480102557.19726.33.camel@perches.com> (raw)
In-Reply-To: <CACT4Y+YB1QBzzdBbPWrq6u2M3B7WuavHZn6KswJi0Qi2DhqDLA@mail.gmail.com>
On Fri, 2016-11-25 at 18:40 +0100, Dmitry Vyukov wrote:
> But should we add KERN_CONT to print_ip_sym instead of duplicating it
> everywhere? Or add print_ip_sym_cont?
There are only a couple dozen uses of print_ip_sym.
It might be better to use "[<%p>] %pS" directly
everywhere and remove print_ip_sym instead to
avoid the KERN_CONT and avoid all possible
interleaved output.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-25 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 19:37 [PATCH 0/2] kasan,stacktrace: improve error reports Andrey Konovalov
2016-11-08 19:37 ` [PATCH 1/2] stacktrace: fix print_stack_trace printing timestamp twice Andrey Konovalov
2016-11-09 16:10 ` Andrey Ryabinin
2016-11-25 17:40 ` Dmitry Vyukov
2016-11-25 19:35 ` Joe Perches [this message]
2016-11-08 19:37 ` [PATCH 2/2] kasan: improve error reports Andrey Konovalov
2016-11-09 16:23 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480102557.19726.33.camel@perches.com \
--to=joe@perches.com \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).