From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-team@lge.com, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Minchan Kim <minchan@kernel.org>
Subject: [PATCH v1 03/10] mm: remove SWAP_MLOCK check for SWAP_SUCCESS in ttu
Date: Mon, 13 Mar 2017 09:35:46 +0900 [thread overview]
Message-ID: <1489365353-28205-4-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1489365353-28205-1-git-send-email-minchan@kernel.org>
If the page is mapped and rescue in try_to_unmap_one,
page_mapcount(page) == 0 cannot be true so page_mapcount check
in try_to_unmap is enough to return SWAP_SUCCESS.
IOW, SWAP_MLOCK check is redundant so remove it.
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
mm/rmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/rmap.c b/mm/rmap.c
index d47af09..1cfb3a3 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -1530,7 +1530,7 @@ int try_to_unmap(struct page *page, enum ttu_flags flags)
else
ret = rmap_walk(page, &rwc);
- if (ret != SWAP_MLOCK && !page_mapcount(page))
+ if (!page_mapcount(page))
ret = SWAP_SUCCESS;
return ret;
}
--
2.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-13 0:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 0:35 [PATCH v1 00/10] make try_to_unmap simple Minchan Kim
2017-03-13 0:35 ` [PATCH v1 01/10] mm: remove unncessary ret in page_referenced Minchan Kim
2017-03-13 6:23 ` Hillf Danton
2017-03-13 0:35 ` [PATCH v1 02/10] mm: remove SWAP_DIRTY in ttu Minchan Kim
2017-03-13 6:34 ` Hillf Danton
2017-03-14 7:34 ` Minchan Kim
2017-03-13 0:35 ` Minchan Kim [this message]
2017-03-13 0:35 ` [PATCH v1 04/10] mm: make the try_to_munlock void function Minchan Kim
2017-03-13 0:35 ` [PATCH v1 05/10] mm: remove SWAP_MLOCK in ttu Minchan Kim
2017-03-13 0:35 ` [PATCH v1 06/10] mm: remove SWAP_AGAIN " Minchan Kim
2017-03-13 0:35 ` [PATCH v1 07/10] mm: make ttu's return boolean Minchan Kim
2017-03-13 0:35 ` [PATCH v1 08/10] mm: make rmap_walk void function Minchan Kim
2017-03-13 0:35 ` [PATCH v1 09/10] mm: make rmap_one boolean function Minchan Kim
2017-03-13 19:45 ` Andrew Morton
2017-03-14 7:37 ` Minchan Kim
2017-03-13 0:35 ` [PATCH v1 10/10] mm: remove SWAP_[SUCCESS|AGAIN|FAIL] Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489365353-28205-4-git-send-email-minchan@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@lge.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).