From: Aaron Lu <aaron.lu@intel.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Dave Hansen <dave.hansen@intel.com>,
Tim Chen <tim.c.chen@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ying Huang <ying.huang@intel.com>, Aaron Lu <aaron.lu@intel.com>
Subject: [PATCH v2 5/5] mm: add debugfs interface for parallel free tuning
Date: Wed, 15 Mar 2017 17:00:04 +0800 [thread overview]
Message-ID: <1489568404-7817-6-git-send-email-aaron.lu@intel.com> (raw)
In-Reply-To: <1489568404-7817-1-git-send-email-aaron.lu@intel.com>
Make it possible to set different values for async_free_threshold and
max_gather_batch_count through debugfs.
With this, we can do tests for different purposes:
1 Restore vanilla kernel bahaviour for performance comparison.
Set max_gather_batch_count to a value like 20 to effectively restore
the behaviour of vanilla kernel since this will make page gathered
always smaller than async_free_threshold(effectively disable parallel
free);
2 Debug purpose.
Set async_free_threshold to a very small value(like 128) to trigger
parallel free even on ordinary processes, ideal for debug purpose with
a virtual machine that doesn't have much memory assigned to it;
3 Performance tuning.
Use a different value for async_free_threshold and max_gather_batch_count
other than the default to test if parallel free performs better or worse.
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
mm/memory.c | 33 +++++++++++++++++++++++++++++++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 83b38823aaba..3a971cc1fc3b 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -183,6 +183,35 @@ static void check_sync_rss_stat(struct task_struct *task)
#ifdef HAVE_GENERIC_MMU_GATHER
+static unsigned long async_free_threshold = ASYNC_FREE_THRESHOLD;
+static unsigned long max_gather_batch_count = MAX_GATHER_BATCH_COUNT;
+
+#ifdef CONFIG_DEBUG_FS
+static int __init tlb_mmu_parallel_free_debugfs(void)
+{
+ umode_t mode = 0644;
+ struct dentry *dir;
+
+ dir = debugfs_create_dir("parallel_free", NULL);
+ if (!dir)
+ return -ENOMEM;
+
+ if (!debugfs_create_ulong("async_free_threshold", mode, dir,
+ &async_free_threshold))
+ goto fail;
+ if (!debugfs_create_ulong("max_gather_batch_count", mode, dir,
+ &max_gather_batch_count))
+ goto fail;
+
+ return 0;
+
+fail:
+ debugfs_remove_recursive(dir);
+ return -ENOMEM;
+}
+late_initcall(tlb_mmu_parallel_free_debugfs);
+#endif
+
static bool tlb_next_batch(struct mmu_gather *tlb)
{
struct mmu_gather_batch *batch;
@@ -193,7 +222,7 @@ static bool tlb_next_batch(struct mmu_gather *tlb)
return true;
}
- if (tlb->batch_count == MAX_GATHER_BATCH_COUNT)
+ if (tlb->batch_count == max_gather_batch_count)
return false;
batch = (void *)__get_free_pages(GFP_NOWAIT | __GFP_NOWARN, 0);
@@ -307,7 +336,7 @@ static void tlb_flush_mmu_free(struct mmu_gather *tlb)
{
struct batch_free_struct *batch_free = NULL;
- if (tlb->page_nr >= ASYNC_FREE_THRESHOLD)
+ if (tlb->page_nr >= async_free_threshold)
batch_free = kmalloc(sizeof(*batch_free),
GFP_NOWAIT | __GFP_NOWARN);
--
2.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-15 9:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 8:59 [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu
2017-03-15 9:00 ` [PATCH v2 1/5] mm: add tlb_flush_mmu_free_batches Aaron Lu
2017-03-15 9:00 ` [PATCH v2 2/5] mm: parallel free pages Aaron Lu
2017-03-15 9:42 ` Hillf Danton
2017-03-15 11:54 ` Aaron Lu
2017-03-15 9:00 ` [PATCH v2 3/5] mm: use a dedicated workqueue for the free workers Aaron Lu
2017-03-22 6:33 ` Minchan Kim
2017-03-22 8:41 ` Aaron Lu
2017-03-22 8:55 ` Minchan Kim
2017-03-22 13:43 ` Aaron Lu
2017-03-23 5:53 ` Minchan Kim
2017-03-23 15:38 ` Dave Hansen
2017-03-24 12:37 ` Aaron Lu
2017-03-15 9:00 ` [PATCH v2 4/5] mm: add force_free_pages in zap_pte_range Aaron Lu
2017-03-15 9:00 ` Aaron Lu [this message]
2017-03-15 14:18 ` [PATCH v2 0/5] mm: support parallel free of memory Michal Hocko
2017-03-15 15:44 ` Aaron Lu
2017-03-15 16:28 ` Michal Hocko
2017-03-15 21:38 ` Tim Chen
2017-03-16 9:07 ` Michal Hocko
2017-03-16 18:36 ` Tim Chen
2017-03-17 7:47 ` Michal Hocko
2017-03-17 8:07 ` Minchan Kim
2017-03-17 12:33 ` Aaron Lu
2017-03-17 12:59 ` Michal Hocko
2017-03-17 13:16 ` Peter Zijlstra
2017-03-17 12:53 ` Peter Zijlstra
2017-03-17 13:05 ` Michal Hocko
2017-03-21 14:54 ` Dave Hansen
2017-03-22 8:02 ` Aaron Lu
2017-03-24 7:04 ` Aaron Lu
2017-03-21 15:18 ` Tim Chen
2017-03-16 6:54 ` Aaron Lu
2017-03-16 7:34 ` Aaron Lu
2017-03-16 13:51 ` Aaron Lu
2017-03-16 14:14 ` Aaron Lu
2017-03-15 14:56 ` Vlastimil Babka
2017-03-15 15:50 ` Aaron Lu
2017-03-17 3:10 ` Aaron Lu
2017-03-16 19:38 ` Alex Thorlton
2017-03-17 2:21 ` Aaron Lu
2017-03-20 19:15 ` Alex Thorlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489568404-7817-6-git-send-email-aaron.lu@intel.com \
--to=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).