From: zhongjiang <zhongjiang@huawei.com>
To: akpm@linux-foundation.org
Cc: minchan@kernel.org, vinayakm.list@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] mm: correct the comment when reclaimed pages exceed the scanned pages
Date: Wed, 7 Jun 2017 16:31:06 +0800 [thread overview]
Message-ID: <1496824266-25235-1-git-send-email-zhongjiang@huawei.com> (raw)
The commit e1587a494540 ("mm: vmpressure: fix sending wrong events on
underflow") declare that reclaimed pages exceed the scanned pages due
to the thp reclaim. it is incorrect because THP will be spilt to normal
page and loop again. which will result in the scanned pages increment.
Signed-off-by: zhongjiang <zhongjiang@huawei.com>
---
mm/vmpressure.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/vmpressure.c b/mm/vmpressure.c
index 6063581..0e91ba3 100644
--- a/mm/vmpressure.c
+++ b/mm/vmpressure.c
@@ -116,8 +116,9 @@ static enum vmpressure_levels vmpressure_calc_level(unsigned long scanned,
/*
* reclaimed can be greater than scanned in cases
- * like THP, where the scanned is 1 and reclaimed
- * could be 512
+ * like reclaimed slab pages, shrink_node just add
+ * reclaimed page without a related increment to
+ * scanned pages.
*/
if (reclaimed >= scanned)
goto out;
--
1.7.12.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-06-07 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 8:31 zhongjiang [this message]
2017-06-08 4:47 ` [PATCH] mm: correct the comment when reclaimed pages exceed the scanned pages zhong jiang
2017-06-08 6:46 ` Minchan Kim
2017-06-09 1:57 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496824266-25235-1-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=vinayakm.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).