From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 907D7C54E58 for ; Thu, 21 Mar 2024 02:16:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED5E56B007B; Wed, 20 Mar 2024 22:16:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E85F06B0082; Wed, 20 Mar 2024 22:16:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D26266B0083; Wed, 20 Mar 2024 22:16:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C074A6B007B for ; Wed, 20 Mar 2024 22:16:13 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7EC1CA0AB5 for ; Thu, 21 Mar 2024 02:16:13 +0000 (UTC) X-FDA: 81919431426.21.D772A9E Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by imf02.hostedemail.com (Postfix) with ESMTP id 9399F80005 for ; Thu, 21 Mar 2024 02:16:11 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GuwMHVgZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of seakeel@gmail.com designates 209.85.167.180 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710987371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lZZ0eBF1nVodLuO+Mf6tnyhoW2fNmSS0bAvLpCiGBQs=; b=bqhO7o5+tF+wlg/NqpTSoGJHqS5reX3Y7GUYeR9r5vOFJGRhjbWzGc9mU6/ATlOZwr+Qp0 aCNjbBbWPlAHo3FyPZ2lE6frL6E6hgb1ASkUv0waH5i/uLqVuhrqs0DRiFUik02qP633vz JqCkgxHrYws7Gp4oxShzAaZKw6oW2OU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GuwMHVgZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of seakeel@gmail.com designates 209.85.167.180 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710987371; a=rsa-sha256; cv=none; b=SgNEdQb0uJtom2pkHYtRUsXJDk+TbvalrZvrIeEDf9a3HRH4T1hPQFpHF77NentSqEOyIr g+u0uxNG/rpjMCXFsWc/5s8QTaH1kyREi1jmlbTkwfK5Y97JcOnRNbgsPkdKGtLzA2Jp15 2p4Am/qesT1bH2w5ygXdDaJYVxuhKeM= Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3c3aa9ca414so247410b6e.2 for ; Wed, 20 Mar 2024 19:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710987370; x=1711592170; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lZZ0eBF1nVodLuO+Mf6tnyhoW2fNmSS0bAvLpCiGBQs=; b=GuwMHVgZQ3ZLtCZdNDi5wrKg/zoKi6VdmBfCdPG5bXSSyuFe+AySVP9dvcxBH7OwFY tibK89CwDQ3s3O5Alttt5BfKPBi/SXnkVDQ0tfnAFgrm4D7CYyNE3SfSeDES423lgsAs LxKyEPHiRkXkCyKDUwvWXc5Qg8nPKUmdlQ2ZNGXItLtd8W/pjcCUHmjQQCI+idPxtJFZ YTpjZLHS+nHDXjMDrtqFGxlbdcsT5vf84TrF6hhlNqUqrSqdJ6hNLwrXxEFC6va7krZA NXcLGbh/sNv5s9wyruZzaXfl1278dpW0/UqSQtw+sCrx6HNiS/W67JJxV60IZzyQQPwK 7A3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710987370; x=1711592170; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lZZ0eBF1nVodLuO+Mf6tnyhoW2fNmSS0bAvLpCiGBQs=; b=I1FrMHhUUmjStD0C4Sns6aFFn+445U/hnLKAC63kVvgBUQKggUOpOQWdtPTMQe1k3G naJYl+u7BU1Ti8sYlseZAwKeMAoRJ/s3tALMD0bocAroYNgPnTMLXQIX+N0GxW9YWFzW WEolxCSURQVATSbenVtQQyM+8iLv2oyN/2sfD1+mecy5OClJe9of/sh/dIbFFtRz9MSk czaJ2haE0RWBvZNSJMFpB4zU4f01FBVnDa66CgIkm1+aLVlyzivIVGXLv1e5XIWy+xb9 C9ozDWy4b7Y3M4o4DPqFMf2tyZXYITYcfeFN2iEuIFBW68+oCCqrFL+vVLrPmA7dOo1V eZIw== X-Forwarded-Encrypted: i=1; AJvYcCViawTOi1qm/PgMFnDyNHjg9fyCt0wrL381HVZRY+u3Y4VTxmtQV/0MjsmMrBEBuu/3RLB352GVCMeMfNrt8VkSkzo= X-Gm-Message-State: AOJu0Yx1/MVxd38n6nwHE+bi8QM1P0pJ9XZfg+Y23lAjU55jHTgNSC5P s8E33KTHgIA0VeHoNYbTakuRJPkWhwAQbEZH3zzv47Aw1apX06qF/lj6+/M5 X-Google-Smtp-Source: AGHT+IGX9Hf4aM8VLWNa/s52FKlPfTb0CfuKELwn7sB6KrWJ9G2rS7tuQj9ARTH3dU1o8nyF9AlDNw== X-Received: by 2002:a05:6a21:9102:b0:1a3:1246:c43e with SMTP id tn2-20020a056a21910200b001a31246c43emr873720pzb.28.1710986882260; Wed, 20 Mar 2024 19:08:02 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.25]) by smtp.gmail.com with ESMTPSA id q2-20020a17090a178200b0029bacd0f271sm2564887pja.31.2024.03.20.19.07.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Mar 2024 19:08:01 -0700 (PDT) Message-ID: <1499f4f3-db06-4330-b2d6-fde57a3fbe04@gmail.com> Date: Thu, 21 Mar 2024 10:07:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/11] mm/ksm: Convert get_ksm_page to return a folio Content-Language: en-US To: Matthew Wilcox , alexs@kernel.org Cc: Izik Eidus , Andrea Arcangeli , Hugh Dickins , Chris Wright , kasong@tencent.com, Andrew Morton , "open list:MEMORY MANAGEMENT" , open list References: <20240320074049.4130552-1-alexs@kernel.org> <20240320074049.4130552-2-alexs@kernel.org> From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9399F80005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: guf7dkoycgnya3mna8aryojqrahybgzh X-HE-Tag: 1710987371-21670 X-HE-Meta: U2FsdGVkX18G6/bUxuna75DjCHz96IIrylpYT2/lRMWBeyf6U+T7MgT17dzJqnt6TTDjqbHjYUzSXQESbVaqS6cbBnavs2vC3fs2QrkFRACmVs/W40i+XgcKsoeGMH+W8o09Tf4GghTcr03+hEgtpP7IHeGqjPoxJKBNPwTicgw5RE1IswsDRc/e+zAHXagTryMO2dnxIhi86OhxdIuiXcGJrvt7qzcqriXPvK11xF8H06qHJ6tqoVKIlquPopjnTUiMfW9iNg7f8r+eWa4ra+cGLD5E6F3xmtIhWD3nGTB/c216KiJ1cK2ZgH9N5KX6o0gqSv2oiVZhElRoRkXjwbVqVKrjtJBH9oodL8IZhI3wJyOu9vM8JAVu4tDaH7z6hoJfsFCSvtOfzNFxgX3tPwHue4LEERsE92wMoPrzLVOg/P6/EoB0h+geqWcxXLkynsHFsliUyJ2MMZyEbCoddOGqAeDz/tfEN/qA2vV+pbcx0TkYv3rd4Rk3+3NkDa89qlXY7+rvh0p7YXHPwUO3VTvhzwXxT6Xju7NqX9xwoS4DXZW3jkZ9eWs0Y9iLdK8KHEi06dKxMwOndzFQWEi04FTBkOXOido4chTytL3Ud17mI3YNHewPsZL8l30gIt9otHhg9MX4dClz0HFqUw+a4ZroOcg59/4dLlqthpcR1MCXWvCZJ2D3xpc8ocfqVDq2CNETbis5My/rnujpX6Nz/ksIkXsuCfozyPuyTFzD8R8ZqQ0A94QX+pX3uwlPJE7gDilPm21e6uv2/jy/couGsrvvtyOaSw6Pc1URkN3YdYVYEj0Pq5T+cwKH9VYg7K4VxOlKmKWTz1H4kCLbM8CDBrmlCcDIVqS0lqW9YRXWLmRz5TQnhr3bEL4MDGATi1Q6ESdKiRB8DtHEGfC8g+YhkFOy9XO5DUIKAs61LgguvR7uvDZZ5vUUFu0lYsGNjAMkJOlZKayfLliWAb5WyFI Q5OJgMvF WL5g+reaQGHLFNqj43Qkg04RmRqEJHdfytRwj5zk5Pxx1g/s0RPhQsRQXNJJF2CPT/Lv8B+0qZykLkK1DOBHVfTxbcWEhfr9kA/bbWrsCeiCTKWuz04n5adQbOjaDT/Wx9DgjvhUsXZ077WFueTYKhDDlfprSuZZK99yp2/FAtWPhlb71FFgHAHhEWmBe6IGcz3bKkeiqZYXAsCPnUjc1kXSA2sfNBEmk7Xz19XTqCFUxHOo0Ggc4ul41ceuTZC1rfkdPbzsniPOJHshHFezj4bM2nimqg7gSSIUKUst3nUdXTtjl+BC8mwd/dV2QONWg/M48PsF1h/FgHvgD/soq/xqLxmYS149ozWn6SLI8cvUuJSplxRBQZXInPi3Ri7IMksIPCCZX1p56IxPgQwuU66ZuvxQYBpDEya0T6EVzFcXkw8Ap+ASWClGlrpDhq9hcgPmbtnNBje0yarr/cJ+av6hP5kahQV9GTnU+3Zx+fO6eojepLsfS/fW/yz85qRReeJ4dl0kge/+AmmxwQwsUBZztWTUyZ8/w61fQHJqCBLFnCjxNC7SVzPprk8rs2Dj9SRGV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/20/24 8:54 PM, Matthew Wilcox wrote: > On Wed, Mar 20, 2024 at 03:40:37PM +0800, alexs@kernel.org wrote: >> -static struct page *get_ksm_page(struct ksm_stable_node *stable_node, >> +static void *get_ksm_page(struct ksm_stable_node *stable_node, >> enum get_ksm_page_flags flags) > > I am really not a fan of returning void * instead of a page or a > folio. Particularly since you rename this function at the end anyway! > > You should do it like this: > > In this patch, convert get_ksm_page() to get_ksm_folio() and add: > > static struct page *get_ksm_page(struct ksm_stable_node *stable_node, > enum get_ksm_page_flags flags) > { > struct folio *folio = get_ksm_folio(node, flags); > return &folio->page; > } > > Then convert each call-site to get_ksm_folio(), and finally delete > get_ksm_page(). That way you're always converting each caller to > the exact code you want it to look like, and your reiewrs don't have to > keep three patches in their head at once as they review each place. > > Also, I think this should be ksm_get_folio(), not get_ksm_folio(). > Seems to fit better. > >> @@ -949,32 +949,32 @@ static struct page *get_ksm_page(struct ksm_stable_node *stable_node, >> * in the ref_freeze section of __remove_mapping(); but Anon >> * page->mapping reset to NULL later, in free_pages_prepare(). > > Could you fix page->mapping to folio->mapping in the comment? > Thanks for comment! I will take your suggestion and resend soon. Best regards!