From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E94BDC83F17 for ; Wed, 9 Jul 2025 22:57:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 513B76B016F; Wed, 9 Jul 2025 18:57:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C4506B0170; Wed, 9 Jul 2025 18:57:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DA3D6B0171; Wed, 9 Jul 2025 18:57:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2D30C6B016F for ; Wed, 9 Jul 2025 18:57:37 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 71D02160303 for ; Wed, 9 Jul 2025 22:57:36 +0000 (UTC) X-FDA: 83646239712.23.1A5A55A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id B888580012 for ; Wed, 9 Jul 2025 22:57:34 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=S7cYflf0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752101854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t2WYBJ9L+BAK3pUn6aQDa1f63uRx2NQAMej6VXAYA1E=; b=rmcpgETi1S6DAOlPMvuODnBTiCJstwb4RxuKdvec1JlKH1UJL07esW2NnCbjyZd4vxdMtQ ibaB4g2NgmMRykt1G9y7PALYT6rgtPA5h2O5KFfrGE2L5RL9mZndyHNlRxeQPlIFntzUGF koZZhSjFZDdFTGe5KxDwclx/Sr+z5hw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752101854; a=rsa-sha256; cv=none; b=CzWfHWOFL/lwKHfyqK+TxnnZzFtBNDcpqpIIW3pMq01nitzfO0MSJ2z83BIl+18xizg0ye Md7FIOfCBh97wc/7fLLzD2rLboQOQkWEI7lkZVdRw7eXkb8actxSY/IEDO5YvAbUPduusj Qum3PF5vezrilYZgys3b2xI/mtb3/a4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=S7cYflf0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 15797A549E2; Wed, 9 Jul 2025 22:57:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97755C4CEF5; Wed, 9 Jul 2025 22:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752101853; bh=yIfy5HUzoyFJKEp5fkslceaEoSylMXWxfkSP2uLnMiQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S7cYflf0KTzsZR4tKzfZFtcW+3qGAL3ExFyE074MtSuQYNOrB1C69bINAhSinNkjE r4ddJoQpd5yMl18+jJcVyI8QX5Ww5mQ4RFiH0SLrvHHbbmgYSYgZQUwDqre7b4omPt AXbRIYDNoa0SlpK1PhJMven2CA2HKGp46fhNxrUcaB4gu86ZtxJBjfPiXhdp776ZC7 jwo87NhW+U8rFGRlM+3YyWhUtaNwIzyOWXlV0cnN3CPwvrYq0fTmNtRUBKqIJtJesv 06iiatxhk0qDSfJGBDAN+gmiLq0iqZXpNfBfgh4/x8hIBmozQE8GqAkHbVLrd4eGJZ aikDtradsoJeA== Message-ID: <14b08e7c-c2e8-435c-a1dd-bd51cfb42060@kernel.org> Date: Thu, 10 Jul 2025 00:57:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 1/4] mm/vmalloc: allow to set node and align in vrealloc To: Alexei Starovoitov Cc: Vitaly Wool , linux-mm , Andrew Morton , LKML , Uladzislau Rezki , Alice Ryhl , Vlastimil Babka , rust-for-linux , Lorenzo Stoakes , "Liam R . Howlett" , Kent Overstreet , linux-bcachefs@vger.kernel.org, bpf , Herbert Xu , Jann Horn , Pedro Falcato References: <20250709172345.1031907-1-vitaly.wool@konsulko.se> <20250709172416.1031970-1-vitaly.wool@konsulko.se> From: Danilo Krummrich Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B888580012 X-Stat-Signature: gp9kc6qffr8rzspmqo6j64ncaa1widks X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752101854-751790 X-HE-Meta: U2FsdGVkX19rzr7+/+uPLv3nnSuouA/kbrqft3jIqSqEYHoOk/sRvDXpeXkgHJkOramXRafC1Y0aQPWYY/GBxpcY+m37kF5wn/G4Ur1m2K33eLG5X9EVaBnSCla8cnH+Bebua+AXtJL+fZg9OlmSFvodzQ6lrg3dJlbE4v4fNlJtsZqMroTTk9qc6Z+1vcqJ/MuINu+EeBZVSdYJ8jTrEOVfaQOLE/gEFvllJoyP8dzQUzgm5ZFn4WEETKj81cslVXv7XHXkBz+m6SL2uJclCU7tboT/q+MIhUHDTOHK4H0iaZTaQuo1cjsCyvZS2NX6H7IaFhUy9chWSqCKTqNt0CmA2gD/odRl7Bklk0szFdQwQNNJ03YtB+SYyUaQs4kKp+w3b16cF0dp9mYtNnW8Cd2CLPKz2WCcaVUHXtPVpxTVRD2kSVaOl1wIlkJeyk77Ip1u6kAwvKo0E3EQHiWv1cep5HoGytfP/IlY7c4NvnBFTEPgSDsZW0OmBkdW99iLVsRKBAWx2qWOLzT4teIfLqRx+3vqQ8elvArGlXmez74C3Sqb0cTpBQBmAdKtMQ/ilFFJvBI2+af7bbd2CcdNrVXhDuWYIOjxE2YsTcxpnQZNTglEBZNiLXvB87IPGeM7vsWHlwKs6iMG6Tz8K3mDi6s8YfZGiPJMUEemIObOUYJ2qf8fNuxGG0ri5WS+E1nM0uLH9QMc7wRsqPdphfUs0NWOxJd2GPE3QaxYIlZnvqL1afxCyS/ma9Ss/SMsyKa+LiDyfcHlNH+W46XDqeW3LTID6HKh8zp6G9bhz174GptP8RUZxxG73jaOiNoJvlKp5WzzqrP6aaIJVMxi31O8XHkuKhm/eSSfFxvxsyCG0zibdTL8LKJMz1xcCCDnid2z/GMlU9Umt8qwIBYWIB7KlDQgMI52Ek0rIV01jzkAGHFO1DY54ugFwBusWtsu3PG95FJyjdBCMsAx0/1O34P Al0zUeYw 7koulgq8X/U48C6Iu9d83dXstMwHZhl8f/+ClZzYlPaMoe+TYWbU2WBm4q5fP+/t6LOFG34+0dPBt38JqWSrsJmFqyA3WDwEbQFbYxk5bJf1f8RT7Ud7LY2cVNFkawqqAOl5vh+UAclxprqshwU9iZU5JaI7K903h4j5yS4cKQj6HlR3R3u3vpopWEHsGioOjN5RDl210B+Kxamrey8dRsgxNgET5I1qv0NiFF+vOvKLjPwFZq8H6BeEr7teVklmfqHseAjvv6J2URmtfMrDgN3okJy0GDZb8igYmD/8J4QwKO95pfqO6ou+hV+tuFlxQ13ENyeCdTOEX3U9/PkGM7JOf0LztZOYOsScu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/10/25 12:53 AM, Alexei Starovoitov wrote: > On Wed, Jul 9, 2025 at 10:25 AM Vitaly Wool wrote: >> >> >> -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) >> +void *vrealloc_node_align_noprof(const void *p, size_t size, unsigned long align, >> + gfp_t flags, int node) >> { > > imo this is a silly pattern to rename functions because they > got new arguments. > The names of the args are clear enough "align" and "node". > I see no point in adding the same suffixes to a function name. > In the future this function will receive another argument and > the function would be renamed again?! > "_noprof" suffix makes sense, since it's there for alloc_hooks, > but "_node_align_" is unnecessary. Do you have an alternative proposal given that we also have vrealloc() and vrealloc_node()?