From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10BC4C54E71 for ; Fri, 22 Mar 2024 17:55:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FF676B0083; Fri, 22 Mar 2024 13:55:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AECF6B0085; Fri, 22 Mar 2024 13:55:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 728126B0087; Fri, 22 Mar 2024 13:55:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 636846B0083 for ; Fri, 22 Mar 2024 13:55:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E801D141668 for ; Fri, 22 Mar 2024 17:54:59 +0000 (UTC) X-FDA: 81925425918.06.A6A88C6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 831B1A0023 for ; Fri, 22 Mar 2024 17:54:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bnftoyHB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711130097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QWtlMLncVgXdNdQuKDFm1Nwigzs6rR7s8i+ituIt+FE=; b=LmRv/Am7IyiIdFq3ixyRQFE8hJnxc8ggrC0b06viULtVIzLqlq1n+Dn8HlikVoKkgC6JJq zRxCkmMkLkJL2nra3c1P4mq6Sl/oUzUvvXZbN9T+fiimrzSMJIE36Oz+irRe7tRZvFpd6Y /2V7n2xSIrgc5yJ5Nz3QOezgLQRXbDY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bnftoyHB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711130097; a=rsa-sha256; cv=none; b=uGxCqRg4WL6rlHZkYRLROc43hu44WExnbs4JudJy2wbpRR6pB5YMo4ycnRRThOFF6foKJT 8Y5ebS6PGbM91smBRVXcZcSHpM3iLV1A4md67cmriG6SBPcthWfFI3qlgDvxvAhewVSIIY O3eMDeeKINt1okJQimtn9J9FohiuPBM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711130096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QWtlMLncVgXdNdQuKDFm1Nwigzs6rR7s8i+ituIt+FE=; b=bnftoyHBgXa6NNOqzWNcl8H77SnXCHYAUiu+HFk6iOV3u1KieQqcYAG2+fouQ3wSqzNFst NJEIiMPPDyVR30BTi4S0qk1K56wNnBmDBBR4wcfqe1SudUT4j7LYvXH7RBT6EKjerJwVkz rNMjMBR+JZxESt7yUIRkO1J1BrAlwZM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-365-I0S6kY6FNp2VMjHtBv-XCQ-1; Fri, 22 Mar 2024 13:54:55 -0400 X-MC-Unique: I0S6kY6FNp2VMjHtBv-XCQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4140cc9cdcfso12560415e9.2 for ; Fri, 22 Mar 2024 10:54:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711130094; x=1711734894; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QWtlMLncVgXdNdQuKDFm1Nwigzs6rR7s8i+ituIt+FE=; b=Zx+0ykV6ITgwCG2H9EO00YS35A/GGaW/Qwc1KTTPzZjjerAFmZN+xxzbm/iHN/YlFx JlY8Rxozn9WDggPRhoYnbZFBsJX5pqZjM1WK5HCy0BRmw49jmdRJGBqoJeIfNDEFipGf FXN0haiSneVyi6shHwWgKdJxL8QHcPornsTLzq1WKMJdl+2IATARpnLDs7JZNEp3299M 61ZdMgEMC7LvAMfXmtjJs2PCXEHp8PCMjbmsyKChMpgE03sQpJjyeU06hwyfyH/+ZVwx DfxjuBM73MLZa2yiJPuAnMvVnVYcnXNxQgHO3YSdNvxssIj28CpfZiJcyndh26qlrN11 Y0UQ== X-Forwarded-Encrypted: i=1; AJvYcCUjkqE//K9YmyajzgyZoj7JYv0F3X3s1PbpI5IGRtrgBDWKMhY9Qelp5aM4eP4DGnhzhnui+lO3cAJVj9V3qYapMWo= X-Gm-Message-State: AOJu0YyYeM01UUTbVTPNtIcxXyNuMTOjsztjnOuWkxQSLj9/6c6zTkWp 1KfN+Hc0zoxnwizRwAKVK6nh0Nda+qNYfPoApIfoOjA1KwRtDumFI2eVSEntof1G9TUgxXj27YO pzk5wl9fh551C/qfOa1pVwyYykYavESBRkJ8KXCiXcvfiK4aX X-Received: by 2002:a05:600c:1c85:b0:414:1400:9773 with SMTP id k5-20020a05600c1c8500b0041414009773mr99198wms.0.1711130093929; Fri, 22 Mar 2024 10:54:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNQk/EOefQ86FNN4PieH3ofB9n0kL7Srb8t2pN+EiepxOCaLSJapVrlFGd2PN9WhVtkuvEzg== X-Received: by 2002:a05:600c:1c85:b0:414:1400:9773 with SMTP id k5-20020a05600c1c8500b0041414009773mr99179wms.0.1711130093526; Fri, 22 Mar 2024 10:54:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7e00:9339:4017:7111:82d0? (p200300cbc71b7e0093394017711182d0.dip0.t-ipconnect.de. [2003:cb:c71b:7e00:9339:4017:7111:82d0]) by smtp.gmail.com with ESMTPSA id l15-20020adfa38f000000b0033e03a6b1ecsm2571021wrb.18.2024.03.22.10.54.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 10:54:53 -0700 (PDT) Message-ID: <14c72ad9-d05c-4b77-b1e8-a8b4a454f977@redhat.com> Date: Fri, 22 Mar 2024 18:54:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: run_vmtests.sh: Fix hugetlb mem size calculation To: peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , Muhammad Usama Anjum , Nico Pache , Muchun Song References: <20240321215047.678172-1-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240321215047.678172-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 831B1A0023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: mn9ssct4485mhqc5khdrcq99i7nryfp1 X-HE-Tag: 1711130097-211610 X-HE-Meta: U2FsdGVkX1+0BP7/YTxYT3fuIljDimthWkubLawzxj7pyxxmxVD6Zf1cF4B+DASyXtCDHjqTAdT9IMRo5Iye4MDa4KQ2Z0aGKqn6NJsquNRlM1FafxOz29OeOsbDmlzDEMSa9RNWEl73LMcffT3m8Fze26H2ohFsI1Rw9CP8gaub+2X7IfkRIn6JVKscV5wn9C3IJlR6IDa8tOkN9aaX1Mf/sRJUxEtlOuyYVb1X8bD7Lgy5tTKay3n42A/80FDV85VZV+Ph51GLv8idl66W5eh2D0yPRkzcsWJkxYO5sZrPGBL1W8cqQv37Ncv1Le77fgUHi8MJWdtC7RZ4mxV557JfC5uIoOKTBUUGchp4jgQGp1OpTJJ0BCknJWJUZBgmsjV8GzzX8N1xqgpcT/DKNQV2RnAmXHuf6V4AruMYOMcRrmCB+YmrGNx2b1h17u2TPNzS/yITTl2ahquL7vSFdJe3apyPZhjkNxK6x1NTP2uFXZ7U5Fe2OZgwD84CS91yX4LcCjnsMtThk4MCI7GNDMjSstnzypgRjhW/O5Mjhkp11TTTDjPJQAinxbtTackXSr3rluwpLEiRpYAQZeq7DBPlKViFbDNGa4i/KIl8re539DrfJin5w3P9Ux2xJAS0Hny4DVT1YE+CZQQU0tEc49OyLLBniXlsZHg60j4DRGiqBM9ISEv4YEEa4FYWFnIWRaohPqzjkoxMuNuvLsJAWSD8S/jW7CiBGEZBWp3+N+70d17oMrHkIcZ35UlTdOy9pQUlrZFD+EvipoPw1aa0F5SB1QDK0Q71tIgGdv5QJOn8TS8SfM7zzPLR/7cX6vU64NiEJbHGmudukFVLKalpLB0bgxuGaiTmaK7zH+CFfwC82O0fPWxFJY+KYexoFvI0Yr5S0TemXSDjq5goAhAJk5APBXVTd01RFSbTqaiCOak5zvaKRUPmmCu6nV3HTlHpwLkm8VJGQuEG3C+u2Kq Fuwc0Z41 tMHNAxmHVNDVjmWTpXdasRHPMTSzspH7eJujrSyWlW6N3Qlumv2coFZZ7aGwRzJHYVKN2XiH0qApALc3vB9KgvZoOJuLkU7/t+YnSFBYQl9hlj81R3VPOmVYFQWSW9wnJe495aFlZF/Bracfd+35BSzm5LYLk8cIMhDnzytP3nf1Vu41oqWhYbMiFcIuwHAW2Q9kvjlNXn8Il2hxPSkHgCXXlXVxFYr6kKQeAHTX60X41ghb+uJIyI24tRmqla+EsbKRR7HpyoLU5Q9lxIvWt7pqr4xCdW+SxBpOdPunPMGcl2ZCc9x0j9p7zJOcktZ+LHVzsCCG4IB5aq5bMWyMXXSyFUWPg6gDcXheiVD2UZhN00MNN7nfgGw+YQ5lHLyH/6qyn2RiZT6wodyTLjl8snG/nGSpnyb9phdxWRRCVw7ui9XZl5rypEUikvcfmyDCuZbBa53OO1Oku/j74Vu1m0KzmTcYG7sPVvp42wjNVZadIYNkly4mbW5AlRagvPtkeiBOYqpwlinbn9wNUhnEIUG2U7wKKLCaipUgOrl41x9MuRYQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.03.24 22:50, peterx@redhat.com wrote: > From: Peter Xu > > The script calculates a mininum required size of hugetlb memories, but > it'll stop working with <1MB huge page sizes, reporting all zeros even if > huge pages are available. > > In reality, the calculation doesn't really need to be as comlicated either. > Make it simpler and work for KB-level hugepages too. > > Cc: Muhammad Usama Anjum > Cc: David Hildenbrand > Cc: Nico Pache > Cc: Muchun Song > Signed-off-by: Peter Xu > --- > tools/testing/selftests/mm/run_vmtests.sh | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index c2c542fe7b17..b1b78e45d613 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -152,9 +152,13 @@ done < /proc/meminfo > # both of these requirements into account and attempt to increase > # number of huge pages available. > nr_cpus=$(nproc) > -hpgsize_MB=$((hpgsize_KB / 1024)) > -half_ufd_size_MB=$((((nr_cpus * hpgsize_MB + 127) / 128) * 128)) > -needmem_KB=$((half_ufd_size_MB * 2 * 1024)) > +uffd_min_KB=$((hpgsize_KB * nr_cpus * 2)) > +hugetlb_min_KB=$((256 * 1024)) > +if [[ $uffd_min_KB -gt $hugetlb_min_KB ]]; then > + needmem_KB=$uffd_min_KB > +else > + needmem_KB=$hugetlb_min_KB > +fi > > # set proper nr_hugepages > if [ -n "$freepgs" ] && [ -n "$hpgsize_KB" ]; then Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb