From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team <kernel-team@lge.com>,
Minchan Kim <minchan@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
"Huang, Ying" <ying.huang@intel.com>
Subject: [PATCH 4/5] mm:swap: respect page_cluster for readahead
Date: Tue, 12 Sep 2017 11:37:12 +0900 [thread overview]
Message-ID: <1505183833-4739-4-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1505183833-4739-1-git-send-email-minchan@kernel.org>
page_cluster 0 means "we don't want readahead" so in the case,
let's skip the readahead detection logic.
Cc: "Huang, Ying" <ying.huang@intel.com>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
include/linux/swap.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/swap.h b/include/linux/swap.h
index 0f54b491e118..739d94397c47 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -427,7 +427,8 @@ extern bool has_usable_swap(void);
static inline bool swap_use_vma_readahead(void)
{
- return READ_ONCE(swap_vma_readahead) && !atomic_read(&nr_rotate_swap);
+ return page_cluster > 0 && READ_ONCE(swap_vma_readahead)
+ && !atomic_read(&nr_rotate_swap);
}
/* Swap 50% full? Release swapcache more aggressively.. */
--
2.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-12 2:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 2:37 [PATCH 1/5] zram: set BDI_CAP_STABLE_WRITES once Minchan Kim
2017-09-12 2:37 ` [PATCH 2/5] bdi: introduce BDI_CAP_SYNCHRONOUS_IO Minchan Kim
2017-09-12 2:37 ` [PATCH 3/5] mm:swap: introduce SWP_SYNCHRONOUS_IO Minchan Kim
2017-09-12 4:48 ` Sergey Senozhatsky
2017-09-12 2:37 ` Minchan Kim [this message]
2017-09-12 5:23 ` [PATCH 4/5] mm:swap: respect page_cluster for readahead Huang, Ying
2017-09-12 6:25 ` Minchan Kim
2017-09-12 6:44 ` Huang, Ying
2017-09-12 6:52 ` Minchan Kim
2017-09-12 7:29 ` Huang, Ying
2017-09-12 7:56 ` Minchan Kim
2017-09-12 8:07 ` Huang, Ying
2017-09-12 8:22 ` Minchan Kim
2017-09-12 8:32 ` Huang, Ying
2017-09-12 23:34 ` Minchan Kim
2017-09-13 0:55 ` Huang, Ying
2017-09-12 2:37 ` [PATCH 5/5] mm:swap: skip swapcache for swapin of synchronous device Minchan Kim
2017-09-12 6:04 ` Sergey Senozhatsky
2017-09-12 6:31 ` Minchan Kim
2017-09-12 20:22 ` kbuild test robot
2017-09-13 0:16 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505183833-4739-4-git-send-email-minchan@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=idryomov@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).