Re: [PATCH v5 9/9] block: Assign a lock_class per gendisk used for wait_for_completion()

Jens Axboe
2017-10-25T18:20:47Z

On 10/25/2017 03:13 AM, Ingo Molnar wrote:
>
> * Byungchul Park <byungchul.park@lge.com> wrote:
>
>> Darrick posted the following warning and Dave Chinner analyzed it:
>>
>>> ======================================================
>>> WARNING: possible circular locking dependency detected
>>> 4.14.0-rc1-fixes #1 Tainted: G W
>
>> Reported-by: Darrick J. Wong <darrick.wong@oracle.com>
>> Analyzed-by: Dave Chinner <david@fromorbit.com>
>> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
>> ---
>> block/bio.c | 2 +-
>> block/genhd.c | 10 ++--------
>> include/linux/genhd.h | 22 ++++++++++++++++++++--
>> 3 files changed, 23 insertions(+), 11 deletions(-)
>
> Ok, this patch looks good to me now, I'll wait to get an Ack or Nak from Jens for
> these changes.
>
> Jens: this patch has some dependencies in prior lockdep changes, so I'd like to
> carry it in the locking tree for a v4.15 merge.

Looks fine to me, you can add my reviewed-by and carry it in your tree.

--
Jens Axboe