* [aaron:for_lkp_skl_2sp2_test 151/225] drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1188:34: error: '__GFP_COLD' undeclared; did you mean '__GFP_COMP'?
@ 2018-01-04 9:25 kbuild test robot
2018-01-04 9:56 ` Mel Gorman
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-01-04 9:25 UTC (permalink / raw)
To: Mel Gorman
Cc: kbuild-all, Aaron Lu, Andrew Morton, Linux Memory Management List
[-- Attachment #1: Type: text/plain, Size: 5899 bytes --]
tree: aaron/for_lkp_skl_2sp2_test
head: 6c9381b65892222cbe2214fb22af9043f9ce1065
commit: cebd3951aaa6936a2dd70e925a5d5667b896da23 [151/225] mm: remove __GFP_COLD
config: x86_64-randconfig-x009-201800 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
git checkout cebd3951aaa6936a2dd70e925a5d5667b896da23
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
In file included from include/linux/percpu_counter.h:15:0,
from include/linux/quota.h:40,
from include/linux/fs.h:222,
from include/linux/compat.h:17,
from include/linux/filter.h:11,
from include/trace/events/bpf.h:10,
from include/linux/bpf_trace.h:4,
from drivers/net/ethernet/netronome/nfp/nfp_net_common.c:46:
drivers/net/ethernet/netronome/nfp/nfp_net_common.c: In function 'nfp_net_rx_alloc_one':
>> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1188:34: error: '__GFP_COLD' undeclared (first use in this function); did you mean '__GFP_COMP'?
page = alloc_page(GFP_KERNEL | __GFP_COLD);
^
include/linux/gfp.h:500:36: note: in definition of macro 'alloc_pages'
alloc_pages_node(numa_node_id(), gfp_mask, order)
^~~~~~~~
>> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1188:10: note: in expansion of macro 'alloc_page'
page = alloc_page(GFP_KERNEL | __GFP_COLD);
^~~~~~~~~~
drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1188:34: note: each undeclared identifier is reported only once for each function it appears in
page = alloc_page(GFP_KERNEL | __GFP_COLD);
^
include/linux/gfp.h:500:36: note: in definition of macro 'alloc_pages'
alloc_pages_node(numa_node_id(), gfp_mask, order)
^~~~~~~~
>> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1188:10: note: in expansion of macro 'alloc_page'
page = alloc_page(GFP_KERNEL | __GFP_COLD);
^~~~~~~~~~
drivers/net/ethernet/netronome/nfp/nfp_net_common.c: In function 'nfp_net_napi_alloc_one':
drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1215:34: error: '__GFP_COLD' undeclared (first use in this function); did you mean '__GFP_COMP'?
page = alloc_page(GFP_ATOMIC | __GFP_COLD);
^
include/linux/gfp.h:500:36: note: in definition of macro 'alloc_pages'
alloc_pages_node(numa_node_id(), gfp_mask, order)
^~~~~~~~
drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1215:10: note: in expansion of macro 'alloc_page'
page = alloc_page(GFP_ATOMIC | __GFP_COLD);
^~~~~~~~~~
vim +1188 drivers/net/ethernet/netronome/nfp/nfp_net_common.c
ecd63a0217 Jakub Kicinski 2016-11-03 1169
4c3523623d Jakub Kicinski 2015-12-01 1170 /**
c0f031bc88 Jakub Kicinski 2016-10-31 1171 * nfp_net_rx_alloc_one() - Allocate and map page frag for RX
783496b0dd Jakub Kicinski 2017-03-10 1172 * @dp: NFP Net data path struct
4c3523623d Jakub Kicinski 2015-12-01 1173 * @dma_addr: Pointer to storage for DMA address (output param)
4c3523623d Jakub Kicinski 2015-12-01 1174 *
c0f031bc88 Jakub Kicinski 2016-10-31 1175 * This function will allcate a new page frag, map it for DMA.
4c3523623d Jakub Kicinski 2015-12-01 1176 *
c0f031bc88 Jakub Kicinski 2016-10-31 1177 * Return: allocated page frag or NULL on failure.
4c3523623d Jakub Kicinski 2015-12-01 1178 */
d78005a50f Jakub Kicinski 2017-04-27 1179 static void *nfp_net_rx_alloc_one(struct nfp_net_dp *dp, dma_addr_t *dma_addr)
4c3523623d Jakub Kicinski 2015-12-01 1180 {
c0f031bc88 Jakub Kicinski 2016-10-31 1181 void *frag;
4c3523623d Jakub Kicinski 2015-12-01 1182
5f0ca2fb71 Jakub Kicinski 2017-10-10 1183 if (!dp->xdp_prog) {
2195c2637f Jakub Kicinski 2017-03-10 1184 frag = netdev_alloc_frag(dp->fl_bufsz);
5f0ca2fb71 Jakub Kicinski 2017-10-10 1185 } else {
5f0ca2fb71 Jakub Kicinski 2017-10-10 1186 struct page *page;
5f0ca2fb71 Jakub Kicinski 2017-10-10 1187
5f0ca2fb71 Jakub Kicinski 2017-10-10 @1188 page = alloc_page(GFP_KERNEL | __GFP_COLD);
5f0ca2fb71 Jakub Kicinski 2017-10-10 1189 frag = page ? page_address(page) : NULL;
5f0ca2fb71 Jakub Kicinski 2017-10-10 1190 }
c0f031bc88 Jakub Kicinski 2016-10-31 1191 if (!frag) {
79c12a752c Jakub Kicinski 2017-03-10 1192 nn_dp_warn(dp, "Failed to alloc receive page frag\n");
4c3523623d Jakub Kicinski 2015-12-01 1193 return NULL;
4c3523623d Jakub Kicinski 2015-12-01 1194 }
4c3523623d Jakub Kicinski 2015-12-01 1195
c487e6b199 Jakub Kicinski 2017-03-10 1196 *dma_addr = nfp_net_dma_map_rx(dp, frag);
79c12a752c Jakub Kicinski 2017-03-10 1197 if (dma_mapping_error(dp->dev, *dma_addr)) {
9dc6b116e2 Jakub Kicinski 2017-03-10 1198 nfp_net_free_frag(frag, dp->xdp_prog);
79c12a752c Jakub Kicinski 2017-03-10 1199 nn_dp_warn(dp, "Failed to map DMA RX buffer\n");
4c3523623d Jakub Kicinski 2015-12-01 1200 return NULL;
4c3523623d Jakub Kicinski 2015-12-01 1201 }
4c3523623d Jakub Kicinski 2015-12-01 1202
c0f031bc88 Jakub Kicinski 2016-10-31 1203 return frag;
4c3523623d Jakub Kicinski 2015-12-01 1204 }
4c3523623d Jakub Kicinski 2015-12-01 1205
:::::: The code at line 1188 was first introduced by commit
:::::: 5f0ca2fb71e28df146f590eebfe32b41171b737f nfp: handle page allocation failures
:::::: TO: Jakub Kicinski <jakub.kicinski@netronome.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29271 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [aaron:for_lkp_skl_2sp2_test 151/225] drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1188:34: error: '__GFP_COLD' undeclared; did you mean '__GFP_COMP'?
2018-01-04 9:25 [aaron:for_lkp_skl_2sp2_test 151/225] drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1188:34: error: '__GFP_COLD' undeclared; did you mean '__GFP_COMP'? kbuild test robot
@ 2018-01-04 9:56 ` Mel Gorman
2018-01-04 13:13 ` Lu, Aaron
0 siblings, 1 reply; 3+ messages in thread
From: Mel Gorman @ 2018-01-04 9:56 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, Aaron Lu, Andrew Morton, Linux Memory Management List
On Thu, Jan 04, 2018 at 05:25:47PM +0800, kbuild test robot wrote:
> tree: aaron/for_lkp_skl_2sp2_test
> head: 6c9381b65892222cbe2214fb22af9043f9ce1065
> commit: cebd3951aaa6936a2dd70e925a5d5667b896da23 [151/225] mm: remove __GFP_COLD
> config: x86_64-randconfig-x009-201800 (attached as .config)
> compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
> reproduce:
> git checkout cebd3951aaa6936a2dd70e925a5d5667b896da23
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
This looks like a backport of some description. __GFP_COLD is removed in
all cases in mainline so I'm guessing this is specific to Aaron's tree.
The fix is to eliminate __GFP_COLD and just use GFP_KERNEL.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [aaron:for_lkp_skl_2sp2_test 151/225] drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1188:34: error: '__GFP_COLD' undeclared; did you mean '__GFP_COMP'?
2018-01-04 9:56 ` Mel Gorman
@ 2018-01-04 13:13 ` Lu, Aaron
0 siblings, 0 replies; 3+ messages in thread
From: Lu, Aaron @ 2018-01-04 13:13 UTC (permalink / raw)
To: Wu, Fengguang, mgorman@suse.de
Cc: kbuild-all@01.org, linux-mm@kvack.org, akpm@linux-foundation.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1128 bytes --]
On Thu, 2018-01-04 at 09:56 +0000, Mel Gorman wrote:
> On Thu, Jan 04, 2018 at 05:25:47PM +0800, kbuild test robot wrote:
> > tree: aaron/for_lkp_skl_2sp2_test
> > head: 6c9381b65892222cbe2214fb22af9043f9ce1065
> > commit: cebd3951aaa6936a2dd70e925a5d5667b896da23 [151/225] mm:
> > remove __GFP_COLD
> > config: x86_64-randconfig-x009-201800 (attached as .config)
> > compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
> > reproduce:
> > git checkout cebd3951aaa6936a2dd70e925a5d5667b896da23
> > # save the attached .config to linux build tree
> > make ARCH=x86_64
> >
>
> This looks like a backport of some description. __GFP_COLD is removed
> in
> all cases in mainline so I'm guessing this is specific to Aaron's
> tree.
> The fix is to eliminate __GFP_COLD and just use GFP_KERNEL.
Sorry for the noise.
I'm rebasing some patches to find a regression on an old branch, I
didn't realize this would trigger the robot.
Please ignore all messages from my tree, sorry again.N‹§²æìr¸›zǧu©ž²Æ {\b†éì¹»\x1c®&Þ–)îÆi¢žØ^n‡r¶‰šŽŠÝ¢j$½§$¢¸\x05¢¹¨è§~Š'.)îÄÃ,yèm¶ŸÿÃ\f%Š{±šj+ƒðèž×¦j)Z†·Ÿ
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-04 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-04 9:25 [aaron:for_lkp_skl_2sp2_test 151/225] drivers/net/ethernet/netronome/nfp/nfp_net_common.c:1188:34: error: '__GFP_COLD' undeclared; did you mean '__GFP_COMP'? kbuild test robot
2018-01-04 9:56 ` Mel Gorman
2018-01-04 13:13 ` Lu, Aaron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).