From: David Woodhouse <dwmw2@infradead.org>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Vegard Nossum <vegard.nossum@oracle.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
Andy Lutomirski <luto@amacapital.net>,
Quentin Casasnovas <quentin.casasnovas@oracle.com>,
Kees Cook <keescook@google.com>, Willy Tarreau <w@1wt.eu>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Laura Abbott <labbott@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: Always print RLIMIT_DATA warning
Date: Wed, 07 Feb 2018 13:03:10 +0000 [thread overview]
Message-ID: <1518008590.3677.126.camel@infradead.org> (raw)
In-Reply-To: <CALYGNiOUZXiOeWSYMgeF3792NNWAgpcxnAOMQ_Wb-d1-Xo_k0Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
On Tue, 2018-02-06 at 20:48 +0300, Konstantin Khlebnikov wrote:
> On Tue, Feb 6, 2018 at 7:45 PM, David Woodhouse <dwmw@amazon.co.uk> wrote:
> >
> > The documentation for ignore_rlimit_data says that it will print a warning
> > at first misuse. Yet it doesn't seem to do that. Fix the code to print
> > the warning even when we allow the process to continue.
>
> Ack. But I think this was a misprint in docs.
> Anyway, this knob is a kludge so we might warn once even if it is set.
Right. I think we definitely should. Otherwise, once set, there's no
real path to ever being able to *unset* it. Nothing well ever get
fixed.
> So, somebody still have problems with this change?
> I remember concerns about that "warn_once" isn't enough to detect
> what's going wrong.
> And probably we should invent "warn_sometimes".
That was covered by "should probably also do what Linus suggested…":
> > ---
> > We should probably also do what Linus suggested in
> > https://lkml.org/lkml/2016/9/16/585
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
prev parent reply other threads:[~2018-02-07 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 16:45 [PATCH] mm: Always print RLIMIT_DATA warning David Woodhouse
2018-02-06 17:27 ` Cyrill Gorcunov
2018-02-06 17:30 ` David Woodhouse
2018-02-06 17:48 ` Konstantin Khlebnikov
2018-02-07 13:03 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518008590.3677.126.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=keescook@google.com \
--cc=koct9i@gmail.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=quentin.casasnovas@oracle.com \
--cc=torvalds@linux-foundation.org \
--cc=vdavydov@virtuozzo.com \
--cc=vegard.nossum@oracle.com \
--cc=w@1wt.eu \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).