* [RFC PATCH v3 4/9] fs/btrfs/extent_io: update usage of zone modifiers
2018-05-23 14:57 [RFC PATCH v3 0/9] get rid of GFP_ZONE_TABLE/BAD Huaisheng Ye
@ 2018-05-23 14:57 ` Huaisheng Ye
0 siblings, 0 replies; 2+ messages in thread
From: Huaisheng Ye @ 2018-05-23 14:57 UTC (permalink / raw)
To: akpm, linux-mm
Cc: mhocko, willy, hch, vbabka, mgorman, kstewart, gregkh, colyli,
chengnt, hehy1, linux-kernel, iommu, xen-devel, linux-btrfs,
Huaisheng Ye, Chris Mason, Josef Bacik, David Sterba,
Christoph Hellwig
From: Huaisheng Ye <yehs1@lenovo.com>
Use __GFP_ZONE_MASK to replace (__GFP_DMA32 | __GFP_HIGHMEM).
In function alloc_extent_state, it is obvious that __GFP_DMA is not
the expecting zone type.
___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 have been deleted from GFP
bitmasks, the bottom three bits of GFP mask is reserved for storing
encoded zone number.
__GFP_DMA, __GFP_HIGHMEM and __GFP_DMA32 should not be operated with
each others by OR.
Use GFP_NORMAL() to clear bottom 3 bits of GFP bitmaks.
Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
Cc: Chris Mason <clm@fb.com>
Cc: Josef Bacik <jbacik@fb.com>
Cc: David Sterba <dsterba@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>
---
fs/btrfs/extent_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index e99b329..f41fc61 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -220,7 +220,7 @@ static struct extent_state *alloc_extent_state(gfp_t mask)
* The given mask might be not appropriate for the slab allocator,
* drop the unsupported bits
*/
- mask &= ~(__GFP_DMA32|__GFP_HIGHMEM);
+ mask = GFP_NORMAL(mask);
state = kmem_cache_alloc(extent_state_cache, mask);
if (!state)
return state;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [RFC PATCH v3 4/9] fs/btrfs/extent_io: update usage of zone modifiers
@ 2018-05-23 16:57 Huaisheng Ye
0 siblings, 0 replies; 2+ messages in thread
From: Huaisheng Ye @ 2018-05-23 16:57 UTC (permalink / raw)
To: akpm, linux-mm
Cc: mhocko, willy, hch, vbabka, mgorman, kstewart, gregkh, colyli,
chengnt, hehy1, linux-kernel, iommu, xen-devel, linux-btrfs,
Huaisheng Ye, Chris Mason, Josef Bacik, David Sterba,
Christoph Hellwig
From: Huaisheng Ye <yehs1@lenovo.com>
Use __GFP_ZONE_MASK to replace (__GFP_DMA32 | __GFP_HIGHMEM).
In function alloc_extent_state, it is obvious that __GFP_DMA is not
the expecting zone type.
___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 have been deleted from GFP
bitmasks, the bottom three bits of GFP mask is reserved for storing
encoded zone number.
__GFP_DMA, __GFP_HIGHMEM and __GFP_DMA32 should not be operated with
each others by OR.
Use GFP_NORMAL() to clear bottom 3 bits of GFP bitmaks.
Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
Cc: Chris Mason <clm@fb.com>
Cc: Josef Bacik <jbacik@fb.com>
Cc: David Sterba <dsterba@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>
---
fs/btrfs/extent_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index e99b329..f41fc61 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -220,7 +220,7 @@ static struct extent_state *alloc_extent_state(gfp_t mask)
* The given mask might be not appropriate for the slab allocator,
* drop the unsupported bits
*/
- mask &= ~(__GFP_DMA32|__GFP_HIGHMEM);
+ mask = GFP_NORMAL(mask);
state = kmem_cache_alloc(extent_state_cache, mask);
if (!state)
return state;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-23 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-23 16:57 [RFC PATCH v3 4/9] fs/btrfs/extent_io: update usage of zone modifiers Huaisheng Ye
-- strict thread matches above, loose matches on Subject: below --
2018-05-23 14:57 [RFC PATCH v3 0/9] get rid of GFP_ZONE_TABLE/BAD Huaisheng Ye
2018-05-23 14:57 ` [RFC PATCH v3 4/9] fs/btrfs/extent_io: update usage of zone modifiers Huaisheng Ye
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).