From: Miles Chen <miles.chen@mediatek.com>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR
Date: Tue, 29 Jan 2019 11:45:57 +0800 [thread overview]
Message-ID: <1548733557.9796.13.camel@mtkswgap22> (raw)
In-Reply-To: <alpine.DEB.2.21.1901281739230.216488@chino.kir.corp.google.com>
On Mon, 2019-01-28 at 17:41 -0800, David Rientjes wrote:
> On Thu, 24 Jan 2019, miles.chen@mediatek.com wrote:
>
> > From: Miles Chen <miles.chen@mediatek.com>
> >
> > When debugging slab errors in slub.c, sometimes we have to trigger
> > a panic in order to get the coredump file. Add a debug option
> > SLAB_WARN_ON_ERROR to toggle WARN_ON() when the option is set.
> >
>
> Wouldn't it be better to enable/disable this for all slab caches instead
> of individual caches at runtime? I'm not sure excluding some caches
> because you know they'll WARN and trigger panic_on_warn unnecessarily is
> valid since it could be enabled for that cache as well through this
> interface.
We can enable this option only for specific slab(s).
e.g., slub_debug=W,dentry
or
enable this option for all slabs
e.g., slub_debug=W
prev parent reply other threads:[~2019-01-29 3:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 7:00 [PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR miles.chen
2019-01-24 7:00 ` miles.chen
2019-01-28 20:29 ` Andrew Morton
2019-01-29 5:46 ` Christopher Lameter
2019-01-29 7:53 ` Miles Chen
2019-01-29 19:46 ` Christopher Lameter
2019-01-30 1:43 ` Miles Chen
2019-01-29 1:41 ` David Rientjes
2019-01-29 3:45 ` Miles Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548733557.9796.13.camel@mtkswgap22 \
--to=miles.chen@mediatek.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).