Re: [PATCH] mm: mempolicy: make mbind() return -EIO when MPOL_MF_STRICT is specified

Oscar Salvador
2019-03-20T18:48:53Z

On Wed, 2019-03-20 at 11:31 -0700, Yang Shi wrote:
> No, this is not correct. queue_pages_pmd() may return 0, which means
> THP
> gets split. If it returns 0 the code should just fall through instead
> of
> returning.

Right, I overlooked that.

> It sounds not correct to me. We need check if there is existing page
> on
> the node which is not allowed by the policy. This is what
> queue_pages_required() does.

Bleh, I guess it was too early in the morning.
That is the whole point of it actually, so that was quite wrong.

Sorry for trying to mislead you ;-)

Reviewed-by: Oscar Salvador <osalvador@suse.de>

--
Oscar Salvador
SUSE L3