From: Yang Shi <yang.shi@linux.alibaba.com>
To: ktkhai@virtuozzo.com, kirill.shutemov@linux.intel.com,
hannes@cmpxchg.org, mhocko@suse.com, hughd@google.com,
shakeelb@google.com, rientjes@google.com,
akpm@linux-foundation.org
Cc: yang.shi@linux.alibaba.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] mm: thp: remove THP destructor
Date: Fri, 7 Jun 2019 14:07:38 +0800 [thread overview]
Message-ID: <1559887659-23121-4-git-send-email-yang.shi@linux.alibaba.com> (raw)
In-Reply-To: <1559887659-23121-1-git-send-email-yang.shi@linux.alibaba.com>
The THP destructor is used to delete THP from per node deferred split
queue, now the operation is moved out of it, so the destructor is not
used anymore, remove it.
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Shakeel Butt <shakeelb@google.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
---
include/linux/mm.h | 3 ---
mm/huge_memory.c | 6 ------
mm/page_alloc.c | 3 ---
3 files changed, 12 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 0e8834a..e543984 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -740,9 +740,6 @@ enum compound_dtor_id {
#ifdef CONFIG_HUGETLB_PAGE
HUGETLB_PAGE_DTOR,
#endif
-#ifdef CONFIG_TRANSPARENT_HUGEPAGE
- TRANSHUGE_PAGE_DTOR,
-#endif
NR_COMPOUND_DTORS,
};
extern compound_page_dtor * const compound_page_dtors[];
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 3307697..50f4720 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -511,7 +511,6 @@ void prep_transhuge_page(struct page *page)
*/
INIT_LIST_HEAD(page_deferred_list(page));
- set_compound_page_dtor(page, TRANSHUGE_PAGE_DTOR);
}
static unsigned long __thp_get_unmapped_area(struct file *filp, unsigned long len,
@@ -2818,11 +2817,6 @@ void del_thp_from_deferred_split_queue(struct page *page)
}
}
-void free_transhuge_page(struct page *page)
-{
- free_compound_page(page);
-}
-
void deferred_split_huge_page(struct page *page)
{
struct deferred_split *ds_queue = get_deferred_split_queue(page);
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index a82104a..6009214 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -261,9 +261,6 @@ bool pm_suspended_storage(void)
#ifdef CONFIG_HUGETLB_PAGE
free_huge_page,
#endif
-#ifdef CONFIG_TRANSPARENT_HUGEPAGE
- free_transhuge_page,
-#endif
};
int min_free_kbytes = 1024;
--
1.8.3.1
next prev parent reply other threads:[~2019-06-07 6:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 6:07 [v2 PATCH 0/4] Make deferred split shrinker memcg aware Yang Shi
2019-06-07 6:07 ` [PATCH 1/4] mm: thp: extract split_queue_* into a struct Yang Shi
2019-06-07 6:07 ` [PATCH 2/4] mm: thp: make deferred split shrinker memcg aware Yang Shi
2019-06-10 8:21 ` Kirill Tkhai
2019-06-10 17:23 ` Yang Shi
2019-06-12 2:47 ` Kirill A. Shutemov
2019-06-12 5:06 ` Yang Shi
2019-06-12 10:09 ` Kirill A. Shutemov
2019-06-12 17:13 ` Yang Shi
2019-06-07 6:07 ` Yang Shi [this message]
2019-06-07 6:07 ` [PATCH 4/4] mm: shrinker: make shrinker not depend on memcg kmem Yang Shi
2019-06-12 2:52 ` Kirill A. Shutemov
2019-06-12 5:07 ` Yang Shi
2019-06-12 10:11 ` Kirill A. Shutemov
2019-06-12 17:20 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559887659-23121-4-git-send-email-yang.shi@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).