From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93FBFC47404 for ; Wed, 9 Oct 2019 19:01:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5091D20B7C for ; Wed, 9 Oct 2019 19:01:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="le8nht8V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5091D20B7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EEA398E0005; Wed, 9 Oct 2019 15:01:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A5F8E0003; Wed, 9 Oct 2019 15:01:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAFEA8E0005; Wed, 9 Oct 2019 15:01:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id B8FB98E0003 for ; Wed, 9 Oct 2019 15:01:39 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 5E650443F for ; Wed, 9 Oct 2019 19:01:39 +0000 (UTC) X-FDA: 76025165118.16.key29_659faab0b1b4e X-HE-Tag: key29_659faab0b1b4e X-Filterd-Recvd-Size: 4526 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Oct 2019 19:01:38 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id u40so4906549qth.11 for ; Wed, 09 Oct 2019 12:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=zyJNPUO8SR13gwhPPuRsCYVFigxr5vFEtoiMAF+pTcw=; b=le8nht8VxnYTzOSkpJf3tIBHgFbpSo/65c1ne6bXsQySJ9KRGTidIZR4ef8XB0cR1N reLEIqHz4qRppKjezR8mrsBiQpj+Gmz9B5xRKddds5O99WUCojsd9CORjq9ifGEUT1uq E3Q+owvHZBUDFX7TRGykI9RGhZZARO9bzTFo2OtZfH7m+DyDE6SDrByoWDXwOjRztSmc aiMJ3NLaJeCZZfM3fKqiMF7vQ0Wk1UNr+ENnmywoB/Y8hO+Xh3QU8wnE2DHk5DaI0lci lRCrNbHjd8IGDGmO18/r2IqJImqFTon8X7buHdNqzdbAJzuqa6vtx4zbkffHCNph5JJ1 Z3wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=zyJNPUO8SR13gwhPPuRsCYVFigxr5vFEtoiMAF+pTcw=; b=AYY2diqh7Ph3XL4zrVhlIMJigif/XwGFdO9NNg9lAoK2EOH8ypGnJQtFT3mAlYkltg 7HXRAUQJ0W6MBjYT4ZoB5Tgjz2g9K4AWcXwCblBM5S73TjdY7Jw5vdfAvmKeMKbuKOKB LdUkq2TD1NxarGiOwn+1x+fs+WCBdWuU76xxxMIAdAr420pRtkYZGYruJ6nLIhuArfNL xTo16JqCsd1pQSr2DnUFXlT2HBPaKvjOfvvWD/BQ4MmYVePG2c9qS0ztwLvbGUMBaeTd arN+d9911yJDBJkYyfjeiOknDn6TAcUzwj+GBXOvGGiXwmNmH0uP8TJ1im1p+CyfRRUI RZNg== X-Gm-Message-State: APjAAAU+9UxIPu7CSdQamUBkkn/rDlfSDyFOkauuaszVMxvpcVxEWVWZ iNuFQela8gHMFIRsz1+fVyKOTw== X-Google-Smtp-Source: APXvYqzBUIiw2fZAxoWgjCR1nQJvGz/d5oPhvmMH7fcfEItfZ2RRHGF77Ln9zflTmJdGXq5E8VIGLA== X-Received: by 2002:ad4:4583:: with SMTP id x3mr5495436qvu.162.1570647697459; Wed, 09 Oct 2019 12:01:37 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id u43sm1554431qte.19.2019.10.09.12.01.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Oct 2019 12:01:36 -0700 (PDT) Message-ID: <1570647695.5937.16.camel@lca.pw> Subject: Re: [PATCH] shmem: make shmem default size a define value From: Qian Cai To: "Gary B. Genett" , Vlastimil Babka Cc: Hugh Dickins , linux-mm@kvack.org Date: Wed, 09 Oct 2019 15:01:35 -0400 In-Reply-To: <20191009184604.GA5162@spider> References: <20191009184604.GA5162@spider> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2019-10-09 at 11:46 -0700, Gary B. Genett wrote: > The default size of the shmem filesystem is currently set to 50% of > memory using a magic token. This change makes it a define value, so > that it is clearly denoted as a global value, and to make it easier to > track down and identify. > > No behavior is changed, and no additional processing is created. > > Signed-off-by: Gary B. Genett > --- > mm/shmem.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index cd570cc79c76..bc758cfb4cb6 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -95,6 +95,9 @@ static struct vfsmount *shm_mnt; > /* Symlink up to this size is kmalloc'ed instead of using a swappable page */ > #define SHORT_SYMLINK_LEN 128 > > +/* Default size of shmem filesystem */ > +#define SHMEM_SIZE_DEFAULT (totalram_pages() / 2) > + > /* > * shmem_fallocate communicates with shmem_fault or shmem_writepage via > * inode->i_private (with i_mutex making sure that it has only one user at > @@ -125,14 +128,14 @@ struct shmem_options { > #ifdef CONFIG_TMPFS > static unsigned long shmem_default_max_blocks(void) > { > - return totalram_pages() / 2; > + return SHMEM_SIZE_DEFAULT; > } > > static unsigned long shmem_default_max_inodes(void) > { > unsigned long nr_pages = totalram_pages(); This is now unused. > > - return min(nr_pages - totalhigh_pages(), nr_pages / 2); > + return min(nr_pages - totalhigh_pages(), SHMEM_SIZE_DEFAULT); > } > #endif > > -- > 2.15.2