From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C425CECE58D for ; Fri, 11 Oct 2019 21:32:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 71FC2206CD for ; Fri, 11 Oct 2019 21:32:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="CPWmZcCt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71FC2206CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 210128E0005; Fri, 11 Oct 2019 17:32:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BFDB6B0005; Fri, 11 Oct 2019 17:32:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AFE68E0005; Fri, 11 Oct 2019 17:32:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id E1D596B0003 for ; Fri, 11 Oct 2019 17:32:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 8D3E040CA for ; Fri, 11 Oct 2019 21:32:48 +0000 (UTC) X-FDA: 76032803616.06.fly10_52af143ad8003 X-HE-Tag: fly10_52af143ad8003 X-Filterd-Recvd-Size: 6278 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Oct 2019 21:32:48 +0000 (UTC) Received: by mail-qt1-f182.google.com with SMTP id m61so15926857qte.7 for ; Fri, 11 Oct 2019 14:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=zjHrVEkh/YVtLs3egsKv3KDVrdQjiHSUSIsKjPxA+7U=; b=CPWmZcCtBiFFoLIUosDrpaTvTrN5NthRx3OufdfwE4W20DrJolmCTjLoFLFAbUsxzC ON0o7NeN8z7DUHFpGu3i9M9vvy//eJPN7x3cognAyZpe9I7E8bDl8g6uGxTnDb6CTn4n PQAgHvghMyGGNUy3F7742cGbJxC8NX4Dnx61g1H3UlSy6pj2Wl7GRiKM0vbLVcBylgJS KvA/fhYGtwCLr1GF6w2TjPsleIVh4wddPmzTYy8r3CphZk4OxihIN079+QWBZuh0uFU1 RIqo1n5RrggJlp/c43UzJF4rATTl/gHyhZuURc/AaqNNJIXkd6kRYw8o5jc/SSHUTY+K y88A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=zjHrVEkh/YVtLs3egsKv3KDVrdQjiHSUSIsKjPxA+7U=; b=jlAtumEYKyc/GhQVxKqCiqQgipFwUQs/o0ssXdAwiNuB5+FwKr0YxJ2r0QwFg9Izcn 5ynXmhMTZhLH+jODS7lOWpLwzJWoh8Ji2U5LiaLOdZu0daDNeLPjlpxAjOl6apxMXJs5 OwJ7xqwS77dFl+VbT/L04ROhNQiOumFetaqnnQd00UZErhHxIvpsDNX++F/QC+fOXd0D 62tAC0SPWWmZ3r74t1AXBK7nVHzo5hKQ83cu9Ni428c8Zr6YsY27w49c0xfb4XkUk3jo Cfbfxz/56Ty6KeECmcYpZ8tpcL5/EMplDxXjL5TL+xsfYQ3lT0WqylYGpTvusIMy+s8c YlrQ== X-Gm-Message-State: APjAAAVgqVa2H+egFSJDnq4ejCwRECIw0DELoLwFXYhHD7hXXQ/yFEoj 2gyRf4dqVdwOIMICP3hyHsg+xA== X-Google-Smtp-Source: APXvYqzIPIRfcmkYvr6Oi5fs8oZ5wfbmCQ03HFEoOqu7kX30Xj96HR9Ph7LfTyh1wPzCuCJqvchNQw== X-Received: by 2002:a0c:fde4:: with SMTP id m4mr8399463qvu.163.1570829567240; Fri, 11 Oct 2019 14:32:47 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id 4sm4785293qtf.87.2019.10.11.14.32.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Oct 2019 14:32:46 -0700 (PDT) Message-ID: <1570829564.5937.36.camel@lca.pw> Subject: memory offline infinite loop after soft offline From: Qian Cai To: Naoya Horiguchi Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , Michal Hocko , Mike Kravetz Date: Fri, 11 Oct 2019 17:32:44 -0400 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.001267, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: # /opt/ltp/runtest/bin/move_pages12 move_pages12.c:263: INFO: Free RAM 258988928 kB move_pages12.c:281: INFO: Increasing 2048kB hugepages pool on node 0 to 4 move_pages12.c:291: INFO: Increasing 2048kB hugepages pool on node 8 to 4 move_pages12.c:207: INFO: Allocating and freeing 4 hugepages on node 0 move_pages12.c:207: INFO: Allocating and freeing 4 hugepages on node 8 move_pages12.c:197: PASS: Bug not reproduced move_pages12.c:197: PASS: Bug not reproduced for mem in $(ls -d /sys/devices/system/memory/memory*); do =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0echo offline > $mem/state =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0echo online > $mem/state done That LTP move_pages12 test will first madvise(MADV_SOFT_OFFLINE) for a ra= nge. Then, one of "echo offline" will trigger an infinite loop in __offline_pa= ges() here, /* check again */ ret =3D walk_system_ram_range(start_pfn, end_pfn - start_pfn, =C2=A0=C2=A0=C2=A0=C2=A0NULL, check_pages_isolated_cb); } while (ret); because check_pages_isolated_cb() always return -EBUSY from test_pages_isolated(), pfn =3D __test_page_isolated_in_pageblock(start_pfn, end_pfn, skip_hwpoisoned_pages); ... return pfn < end_pfn ? -EBUSY : 0; The root cause is in __test_page_isolated_in_pageblock() where "pfn" is a= lways less than "end_pfn" because the associated page is not a PageBuddy. while (pfn < end_pfn) { ... else break; return pfn; Adding a dump_page() for that pfn shows, [=C2=A0=C2=A0101.665160][ T8885] pfn =3D 77501, end_pfn =3D 78000 [=C2=A0=C2=A0101.665245][ T8885] page:c00c000001dd4040 refcount:0 mapcoun= t:0 mapping:0000000000000000 index:0x0 [=C2=A0=C2=A0101.665329][ T8885] flags: 0x3fffc000000000() [=C2=A0=C2=A0101.665391][ T8885] raw: 003fffc000000000 0000000000000000 f= fffffff01dd0500 0000000000000000 [=C2=A0=C2=A0101.665498][ T8885] raw: 0000000000000000 0000000000000000 0= 0000000ffffffff 0000000000000000 [=C2=A0=C2=A0101.665588][ T8885] page dumped because: soft_offline [=C2=A0=C2=A0101.665639][ T8885] page_owner tracks the page as freed [=C2=A0=C2=A0101.665697][ T8885] page last allocated via order 5, migrate= type Movable, gfp_mask 0x346cca(GFP_HIGHUSER_MOVABLE|__GFP_NOWARN|__GFP_RETRY_MAYFAIL|__GFP_COMP= |__GFP_ THISNODE) [=C2=A0=C2=A0101.665924][ T8885]=C2=A0=C2=A0prep_new_page+0x3c0/0x440 [=C2=A0=C2=A0101.665962][ T8885]=C2=A0=C2=A0get_page_from_freelist+0x2568= /0x2bb0 [=C2=A0=C2=A0101.666059][ T8885]=C2=A0=C2=A0__alloc_pages_nodemask+0x1b4/= 0x670 [=C2=A0=C2=A0101.666115][ T8885]=C2=A0=C2=A0alloc_fresh_huge_page+0x244/0= x6e0 [=C2=A0=C2=A0101.666183][ T8885]=C2=A0=C2=A0alloc_migrate_huge_page+0x30/= 0x70 [=C2=A0=C2=A0101.666254][ T8885]=C2=A0=C2=A0alloc_new_node_page+0xc4/0x38= 0 [=C2=A0=C2=A0101.666325][ T8885]=C2=A0=C2=A0migrate_pages+0x3b4/0x19e0 [=C2=A0=C2=A0101.666375][ T8885]=C2=A0=C2=A0do_move_pages_to_node.isra.29= .part.30+0x44/0xa0 [=C2=A0=C2=A0101.666464][ T8885]=C2=A0=C2=A0kernel_move_pages+0x498/0xfc0 [=C2=A0=C2=A0101.666520][ T8885]=C2=A0=C2=A0sys_move_pages+0x28/0x40 [=C2=A0=C2=A0101.666643][ T8885]=C2=A0=C2=A0system_call+0x5c/0x68 [=C2=A0=C2=A0101.666665][ T8885] page last free stack trace: [=C2=A0=C2=A0101.666704][ T8885]=C2=A0=C2=A0__free_pages_ok+0xa4c/0xd40 [=C2=A0=C2=A0101.666773][ T8885]=C2=A0=C2=A0update_and_free_page+0x2dc/0x= 5b0 [=C2=A0=C2=A0101.666821][ T8885]=C2=A0=C2=A0free_huge_page+0x2dc/0x740 [=C2=A0=C2=A0101.666875][ T8885]=C2=A0=C2=A0__put_compound_page+0x64/0xc0 [=C2=A0=C2=A0101.666926][ T8885]=C2=A0=C2=A0putback_active_hugepage+0x228= /0x390 [=C2=A0=C2=A0101.666990][ T8885]=C2=A0=C2=A0migrate_pages+0xa78/0x19e0 [=C2=A0=C2=A0101.667048][ T8885]=C2=A0=C2=A0soft_offline_page+0x314/0x105= 0 [=C2=A0=C2=A0101.667117][ T8885]=C2=A0=C2=A0sys_madvise+0x1068/0x1080 [=C2=A0=C2=A0101.667185][ T8885]=C2=A0=C2=A0system_call+0x5c/0x68