linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: gregkh@linuxfoundation.org,linux-mm@kvack.org,sashal@kernel.org,willy@infradead.org,yangyingliang@huawei.com,zhongjiang@huawei.com
Cc: <stable-commits@vger.kernel.org>
Subject: Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.4-stable tree
Date: Tue, 19 Nov 2019 05:59:03 +0100	[thread overview]
Message-ID: <157413954315490@kroah.com> (raw)
In-Reply-To: <20191118032610.182862-3-zhongjiang@huawei.com>


This is a note to let you know that I've just added the patch titled

    memfd: Use radix_tree_deref_slot_protected to avoid the warning.

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


From zhongjiang@huawei.com  Tue Nov 19 05:57:26 2019
From: zhong jiang <zhongjiang@huawei.com>
Date: Mon, 18 Nov 2019 11:26:09 +0800
Subject: memfd: Use radix_tree_deref_slot_protected to avoid the warning.
To: <sashal@kernel.org>, <gregkh@linuxfoundation.org>, <stable@vger.kernel.org>, <willy@infradead.org>
Cc: <linux-mm@kvack.org>, <yangyingliang@huawei.com>
Message-ID: <20191118032610.182862-3-zhongjiang@huawei.com>

From: zhong jiang <zhongjiang@huawei.com>

The commit eb4058d8daf8 ("memfd: Fix locking when tagging pins")
introduces the following warning messages.

*WARNING: suspicious RCU usage in memfd_wait_for_pins*

It is because we still use radix_tree_deref_slot without read_rcu_lock.
We should use radix_tree_deref_slot_protected instead in the case.

Cc: stable@vger.kernel.org
Fixes: eb4058d8daf8 ("memfd: Fix locking when tagging pins")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 mm/shmem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1862,7 +1862,7 @@ static void shmem_tag_pins(struct addres
 	spin_lock_irq(&mapping->tree_lock);
 restart:
 	radix_tree_for_each_slot(slot, &mapping->page_tree, &iter, start) {
-		page = radix_tree_deref_slot(slot);
+		page = radix_tree_deref_slot_protected(slot, &mapping->tree_lock);
 		if (!page || radix_tree_exception(page)) {
 			if (radix_tree_deref_retry(page))
 				goto restart;


Patches currently in stable-queue which might be from zhongjiang@huawei.com are

queue-4.4/misc-genwqe-should-return-proper-error-value.patch
queue-4.4/memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch


  parent reply	other threads:[~2019-11-19  4:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18  3:26 [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18  3:26 ` [PATCH 4.19] " zhong jiang
2019-11-18 12:25   ` Matthew Wilcox
2019-11-19  5:00   ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.19-stable tree gregkh
2019-11-18  3:26 ` [PATCH 4.4] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18 12:25   ` Matthew Wilcox
2019-11-19  4:59   ` gregkh [this message]
2019-11-18  3:26 ` [PATCH 4.9] " zhong jiang
2019-11-18 12:25   ` Matthew Wilcox
2019-11-19  4:59   ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.9-stable tree gregkh
2019-11-18 12:24 ` [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning Matthew Wilcox
2019-11-19  4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.14-stable tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157413954315490@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-mm@kvack.org \
    --cc=sashal@kernel.org \
    --cc=stable-commits@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=yangyingliang@huawei.com \
    --cc=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).