From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ZbOS=4O=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,
	SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 82299C4BA13
	for <linux-mm@archiver.kernel.org>; Wed, 26 Feb 2020 17:06:07 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 251A02467F
	for <linux-mm@archiver.kernel.org>; Wed, 26 Feb 2020 17:06:07 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="VjeQVJp/"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 251A02467F
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id A8EF46B0005; Wed, 26 Feb 2020 12:06:06 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id A41956B0008; Wed, 26 Feb 2020 12:06:06 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 908466B000A; Wed, 26 Feb 2020 12:06:06 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232])
	by kanga.kvack.org (Postfix) with ESMTP id 709C86B0005
	for <linux-mm@kvack.org>; Wed, 26 Feb 2020 12:06:06 -0500 (EST)
Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay05.hostedemail.com (Postfix) with ESMTP id AB889181AEF07
	for <linux-mm@kvack.org>; Wed, 26 Feb 2020 17:06:05 +0000 (UTC)
X-FDA: 76532905890.28.comb93_51f177927ca2d
Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251])
	by smtpin28.hostedemail.com (Postfix) with ESMTP id 42C748E7B
	for <linux-mm@kvack.org>; Wed, 26 Feb 2020 17:02:44 +0000 (UTC)
X-HE-Tag: comb93_51f177927ca2d
X-Filterd-Recvd-Size: 26494
Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194])
	by imf50.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Wed, 26 Feb 2020 17:02:42 +0000 (UTC)
Received: by mail-qk1-f194.google.com with SMTP id e16so87566qkl.6
        for <linux-mm@kvack.org>; Wed, 26 Feb 2020 09:02:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=lca.pw; s=google;
        h=message-id:subject:from:to:cc:date:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=xNn7CxQ+hq//pn/PulZRifgvcQBvCI4+PQUJoEu/xug=;
        b=VjeQVJp/oJaqz7FlhY8YwGK+rS6Lo1HEGw+YrrRnT5qSdFPVs3+TlXx2+jhWvDtadw
         z47wfAnWALLFfLFXohiWEQpvguzD+x+yH6ZkyfaJSDlswp8mXD7+1w4XOv3nBFq+7pZF
         n9/YuRGd69Kj3PhRCU+d+7gbeE8UrPqKu0a7aAYV6ZQS81bvwxuraaK23TCwtR7NIM+s
         W7Qc+gkOtozcx0XJ4RVZyHwX7dd9N8Q62RAnX/cXsnKQlJBbDiLl+uaR4dLIP+3XQBz/
         Uo3TYIGFQrl67CNZnxo60CCEiEWV+Vf0C6DV+WTL5gNm9XG6uXiM8DfiuSHnENcgonWd
         TK8Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=xNn7CxQ+hq//pn/PulZRifgvcQBvCI4+PQUJoEu/xug=;
        b=db1NXui14sQelmyxu1Xh/M1ID8Nwhlqpr8NB0fxMwYl8I7i7gKLWB9WLhfJnkB1RHb
         DXurJUXtqA25E5IH6RjDgG7BfsFpHU7NruJmqlaNY8JHefAZXRNFRj+MoUycarq/+IbX
         izZ2H9hr1Vy+9R989zjfOSLKh9lFsCIoIVWRq8yA4qQGm5VxR+f5TnbJJBc8drcG9rZE
         PGoCRwRBsvcdyt1YIO6QLu/JwvlzaRWzPebYELmJVSHh3pjc+REM1O4fv50J2+Ya2U/0
         2+CV7NZDcEpLLMBOgrS0f0RhE2YxdlLfo8bsC9X5S9pVvYtb0C24MWd2kkvwwIMG2M54
         GmwQ==
X-Gm-Message-State: APjAAAU/+6Q5fnmcb3Tj/MUT/5Idio71FqAOEV+WajY2TSbslKu0QITj
	fxAZz3U7eBWBEmQlORbjeJiV2w==
X-Google-Smtp-Source: APXvYqzQOrfTZe8cBJKFlDC1mkvU8Sj82vKZB8oUY5VfcwoY574xphoXvMbSz/pZXfvGElrnfKVEaw==
X-Received: by 2002:a37:4c81:: with SMTP id z123mr68087qka.320.1582736561890;
        Wed, 26 Feb 2020 09:02:41 -0800 (PST)
Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206])
        by smtp.gmail.com with ESMTPSA id c10sm1450622qkb.4.2020.02.26.09.02.39
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 26 Feb 2020 09:02:41 -0800 (PST)
Message-ID: <1582736558.7365.131.camel@lca.pw>
Subject: Re: [PATCH v3 1/3] loop: Use worker per cgroup instead of kworker
From: Qian Cai <cai@lca.pw>
To: Dan Schatzberg <schatzberg.dan@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>, Li Zefan
 <lizefan@huawei.com>, Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko
 <mhocko@kernel.org>, Vladimir Davydov <vdavydov.dev@gmail.com>, Andrew
 Morton <akpm@linux-foundation.org>, Hugh Dickins <hughd@google.com>, Roman
 Gushchin <guro@fb.com>, Shakeel Butt <shakeelb@google.com>, Chris Down
 <chris@chrisdown.name>, Yang Shi <yang.shi@linux.alibaba.com>, Thomas
 Gleixner <tglx@linutronix.de>, "open list:BLOCK LAYER"
 <linux-block@vger.kernel.org>,  open list <linux-kernel@vger.kernel.org>,
 "open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,  "open
 list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)"
 <linux-mm@kvack.org>
Date: Wed, 26 Feb 2020 12:02:38 -0500
In-Reply-To: <eab018412a0c9feb573d757b1bbd5f58b33e2a8d.1582581887.git.schatzberg.dan@gmail.com>
References: <cover.1582581887.git.schatzberg.dan@gmail.com>
	 <eab018412a0c9feb573d757b1bbd5f58b33e2a8d.1582581887.git.schatzberg.dan@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) 
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On Mon, 2020-02-24 at 17:17 -0500, Dan Schatzberg wrote:
> Existing uses of loop device may have multiple cgroups reading/writing
> to the same device. Simply charging resources for I/O to the backing
> file could result in priority inversion where one cgroup gets
> synchronously blocked, holding up all other I/O to the loop device.
>=20
> In order to avoid this priority inversion, we use a single workqueue
> where each work item is a "struct loop_worker" which contains a queue o=
f
> struct loop_cmds to issue. The loop device maintains a tree mapping blk
> css_id -> loop_worker. This allows each cgroup to independently make
> forward progress issuing I/O to the backing file.
>=20
> There is also a single queue for I/O associated with the rootcg which
> can be used in cases of extreme memory shortage where we cannot allocat=
e
> a loop_worker.
>=20
> The locking for the tree and queues is fairly heavy handed - we acquire
> the per-loop-device spinlock any time either is accessed. The existing
> implementation serializes all I/O through a single thread anyways, so I
> don't believe this is any worse.
>=20
> Signed-off-by: Dan Schatzberg <schatzberg.dan@gmail.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

The locking in loop_free_idle_workers() will trigger this with sysfs read=
ing,

[ 7080.047167] LTP: starting read_all_sys (read_all -d /sys -q -r 10)
[ 7239.842276] cpufreq transition table exceeds PAGE_SIZE. Disabling

[ 7247.054961] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D
[ 7247.054971] WARNING: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detecte=
d
[ 7247.054983] 5.6.0-rc3-next-20200226 #2 Tainted: G=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0O=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0
[ 7247.054992] -----------------------------------------------------
[ 7247.055002] read_all/8513 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire=
:
[ 7247.055014] c0000006844864c8 (&fs->seq){+.+.}, at: file_path+0x24/0x40
[ 7247.055041]=C2=A0
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0and this task is already holding:
[ 7247.055061] c0002006bab8b928 (&(&lo->lo_lock)->rlock){..-.}, at:
loop_attr_do_show_backing_file+0x3c/0x120 [loop]
[ 7247.055078] which would create a new lock dependency:
[ 7247.055105]=C2=A0=C2=A0(&(&lo->lo_lock)->rlock){..-.} -> (&fs->seq){+.=
+.}
[ 7247.055125]=C2=A0
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0but this new dependency connects a SOFTIRQ-irq-safe lock:
[ 7247.055155]=C2=A0=C2=A0(&(&lo->lo_lock)->rlock){..-.}
[ 7247.055156]=C2=A0
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0... which became SOFTIRQ-irq-safe at:
[ 7247.055196]=C2=A0=C2=A0=C2=A0lock_acquire+0x130/0x360
[ 7247.055221]=C2=A0=C2=A0=C2=A0_raw_spin_lock_irq+0x68/0x90
[ 7247.055230]=C2=A0=C2=A0=C2=A0loop_free_idle_workers+0x44/0x3f0 [loop]
[ 7247.055242]=C2=A0=C2=A0=C2=A0call_timer_fn+0x110/0x5f0
[ 7247.055260]=C2=A0=C2=A0=C2=A0run_timer_softirq+0x8f8/0x9f0
[ 7247.055278]=C2=A0=C2=A0=C2=A0__do_softirq+0x34c/0x8c8
[ 7247.055288]=C2=A0=C2=A0=C2=A0irq_exit+0x16c/0x1d0
[ 7247.055298]=C2=A0=C2=A0=C2=A0timer_interrupt+0x1f0/0x680
[ 7247.055308]=C2=A0=C2=A0=C2=A0decrementer_common+0x124/0x130
[ 7247.055328]=C2=A0=C2=A0=C2=A0arch_local_irq_restore.part.8+0x34/0x90
[ 7247.055352]=C2=A0=C2=A0=C2=A0cpuidle_enter_state+0x11c/0x8f0
[ 7247.055361]=C2=A0=C2=A0=C2=A0cpuidle_enter+0x50/0x70
[ 7247.055389]=C2=A0=C2=A0=C2=A0call_cpuidle+0x4c/0x90
[ 7247.055398]=C2=A0=C2=A0=C2=A0do_idle+0x378/0x470
[ 7247.055414]=C2=A0=C2=A0=C2=A0cpu_startup_entry+0x3c/0x40
[ 7247.055442]=C2=A0=C2=A0=C2=A0start_secondary+0x7a8/0xa80
[ 7247.055461]=C2=A0=C2=A0=C2=A0start_secondary_prolog+0x10/0x14
[ 7247.055478]=C2=A0
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0to a SOFTIRQ-irq-unsafe lock:
[ 7247.055506]=C2=A0=C2=A0(&fs->seq){+.+.}
[ 7247.055507]=C2=A0
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0... which became SOFTIRQ-irq-unsafe at:
[ 7247.055541] ...
[ 7247.055542]=C2=A0=C2=A0=C2=A0lock_acquire+0x130/0x360
[ 7247.055577]=C2=A0=C2=A0=C2=A0set_fs_pwd+0x98/0x140
[ 7247.055593]=C2=A0=C2=A0=C2=A0ksys_chdir+0x8c/0x100
[ 7247.055611]=C2=A0=C2=A0=C2=A0devtmpfsd+0xac/0xe0
[ 7247.055629]=C2=A0=C2=A0=C2=A0kthread+0x1a8/0x1b0
[ 7247.055645]=C2=A0=C2=A0=C2=A0ret_from_kernel_thread+0x5c/0x74
[ 7247.055663]=C2=A0
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0other info that might help us debug this:

[ 7247.055685]=C2=A0=C2=A0Possible interrupt unsafe locking scenario:

[ 7247.055695]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU1
[ 7247.055712]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0----=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0----
[ 7247.055719]=C2=A0=C2=A0=C2=A0lock(&fs->seq);
[ 7247.055748]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0local_irq_disabl=
e();
[ 7247.055776]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lock(&(&lo->lo_l=
ock)->rlock);
[ 7247.055805]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lock(&fs->seq);
[ 7247.055825]=C2=A0=C2=A0=C2=A0<Interrupt>
[ 7247.055840]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lock(&(&lo->lo_lock)->rlock);
[ 7247.055867]=C2=A0
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0*** DEADLOCK ***

[ 7247.055896] 5 locks held by read_all/8513:
[ 7247.055913]=C2=A0=C2=A0#0: c000001afc46d708 (&p->lock){+.+.}, at: seq_=
read+0x60/0x620
[ 7247.055944]=C2=A0=C2=A0#1: c000000f6ce00e80 (&of->mutex){+.+.}, at:
kernfs_seq_start+0x40/0x130
[ 7247.055981]=C2=A0=C2=A0#2: c0002011b81e0010 (kn->count#685){.+.+}, at:
kernfs_seq_start+0x4c/0x130
[ 7247.056013]=C2=A0=C2=A0#3: c0002006bab8b928 (&(&lo->lo_lock)->rlock){.=
.-.}, at:
loop_attr_do_show_backing_file+0x3c/0x120 [loop]
[ 7247.056048]=C2=A0=C2=A0#4: c000000001500888 (rcu_read_lock){....}, at:
d_path+0xa0/0x3f0
[ 7247.056072]=C2=A0
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0the dependencies between SOFTIRQ-irq-safe lock and the hol=
ding
lock:
[ 7247.056104] -> (&(&lo->lo_lock)->rlock){..-.} ops: 196198 {
[ 7247.056144]=C2=A0=C2=A0=C2=A0=C2=A0IN-SOFTIRQ-W at:
[ 7247.056161]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lock_ac=
quire+0x130/0x360
[ 7247.056180]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0_raw_sp=
in_lock_irq+0x68/0x90
[ 7247.056208]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0loop_fr=
ee_idle_workers+0x44/0x3f0 [loop]
[ 7247.056238]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0call_ti=
mer_fn+0x110/0x5f0
[ 7247.056271]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0run_tim=
er_softirq+0x8f8/0x9f0
[ 7247.056290]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0__do_so=
ftirq+0x34c/0x8c8
[ 7247.056318]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0irq_exi=
t+0x16c/0x1d0
[ 7247.056337]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0timer_i=
nterrupt+0x1f0/0x680
[ 7247.056366]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0decreme=
nter_common+0x124/0x130
[ 7247.056394]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0arch_lo=
cal_irq_restore.part.8+0x34/0x90
[ 7247.056432]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cpuidle=
_enter_state+0x11c/0x8f0
[ 7247.056460]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cpuidle=
_enter+0x50/0x70
[ 7247.056480]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0call_cp=
uidle+0x4c/0x90
[ 7247.056498]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0do_idle=
+0x378/0x470
[ 7247.056516]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cpu_sta=
rtup_entry+0x3c/0x40
[ 7247.056535]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0start_s=
econdary+0x7a8/0xa80
[ 7247.056554]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0start_s=
econdary_prolog+0x10/0x14
[ 7247.056572]=C2=A0=C2=A0=C2=A0=C2=A0INITIAL USE at:
[ 7247.056589]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lock_acquire+=
0x130/0x360
[ 7247.056618]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0_raw_spin_loc=
k_irq+0x68/0x90
[ 7247.056671]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0loop_queue_rq=
+0xf4/0x540 [loop]
[ 7247.056737]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0__blk_mq_try_=
issue_directly+0x1ac/0x2e0
[ 7247.056850]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0blk_mq_reques=
t_issue_directly+0x64/0xb0
[ 7247.056924]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0blk_mq_try_is=
sue_list_directly+0x90/0x140
[ 7247.056988]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0blk_mq_sched_=
insert_requests+0x1c0/0x4b0
[ 7247.057070]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0blk_mq_flush_=
plug_list+0x1d0/0x4b0
[ 7247.057155]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0blk_flush_plu=
g_list+0x148/0x1a0
[ 7247.057221]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0blk_finish_pl=
ug+0x50/0x6c
[ 7247.057285]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0read_pages+0x=
ac/0x320
[ 7247.057344]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0__do_page_cac=
he_readahead+0x198/0x350
[ 7247.057428]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0force_page_ca=
che_readahead+0xcc/0x1b0
[ 7247.057505]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0generic_file_=
buffered_read+0x7d4/0xdd0
[ 7247.057577]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0blkdev_read_i=
ter+0x50/0x80
[ 7247.057658]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0new_sync_read=
+0x15c/0x1f0
[ 7247.057723]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0vfs_read+0xac=
/0x170
[ 7247.057786]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ksys_read+0x7=
c/0x140
[ 7247.057856]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0system_call+0=
x5c/0x68
[ 7247.057902]=C2=A0=C2=A0}
[ 7247.057935]=C2=A0=C2=A0... key=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0at: =
[<c00800000fa6bbc8>]
__key.50783+0x0/0xffffffffffffc9b8 [loop]
[ 7247.058028]=C2=A0=C2=A0... acquired at:
[ 7247.058074]=C2=A0=C2=A0=C2=A0=C2=A0lock_acquire+0x130/0x360
[ 7247.058126]=C2=A0=C2=A0=C2=A0=C2=A0d_path+0x194/0x3f0
[ 7247.058174]=C2=A0=C2=A0=C2=A0=C2=A0file_path+0x24/0x40
[ 7247.058225]=C2=A0=C2=A0=C2=A0=C2=A0loop_attr_do_show_backing_file+0x5c=
/0x120 [loop]
[ 7247.058305]=C2=A0=C2=A0=C2=A0=C2=A0dev_attr_show+0x44/0xb0
[ 7247.058354]=C2=A0=C2=A0=C2=A0=C2=A0sysfs_kf_seq_show+0xbc/0x1d0
[ 7247.058421]=C2=A0=C2=A0=C2=A0=C2=A0kernfs_seq_show+0x44/0x60
[ 7247.058458]=C2=A0=C2=A0=C2=A0=C2=A0seq_read+0x1c4/0x620
[ 7247.058504]=C2=A0=C2=A0=C2=A0=C2=A0kernfs_fop_read+0x40/0x2b0
[ 7247.058559]=C2=A0=C2=A0=C2=A0=C2=A0__vfs_read+0x3c/0x70
[ 7247.058607]=C2=A0=C2=A0=C2=A0=C2=A0vfs_read+0xac/0x170
[ 7247.058659]=C2=A0=C2=A0=C2=A0=C2=A0ksys_read+0x7c/0x140
[ 7247.058722]=C2=A0=C2=A0=C2=A0=C2=A0system_call+0x5c/0x68

[ 7247.058778]=C2=A0
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0the dependencies between the lock to be acquired
[ 7247.058779]=C2=A0=C2=A0and SOFTIRQ-irq-unsafe lock:
[ 7247.058924] -> (&fs->seq){+.+.} ops: 22599070 {
[ 7247.058992]=C2=A0=C2=A0=C2=A0=C2=A0HARDIRQ-ON-W at:
[ 7247.059043]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lock_ac=
quire+0x130/0x360
[ 7247.059108]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0set_fs_=
pwd+0x98/0x140
[ 7247.059179]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ksys_ch=
dir+0x8c/0x100
[ 7247.059262]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0devtmpf=
sd+0xac/0xe0
[ 7247.059318]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0kthread=
+0x1a8/0x1b0
[ 7247.059369]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ret_fro=
m_kernel_thread+0x5c/0x74
[ 7247.059453]=C2=A0=C2=A0=C2=A0=C2=A0SOFTIRQ-ON-W at:
[ 7247.059498]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lock_ac=
quire+0x130/0x360
[ 7247.059545]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0set_fs_=
pwd+0x98/0x140
[ 7247.059614]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ksys_ch=
dir+0x8c/0x100
[ 7247.059675]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0devtmpf=
sd+0xac/0xe0
[ 7247.059745]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0kthread=
+0x1a8/0x1b0
[ 7247.059804]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ret_fro=
m_kernel_thread+0x5c/0x74
[ 7247.059884]=C2=A0=C2=A0=C2=A0=C2=A0INITIAL USE at:
[ 7247.059929]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lock_acquire+=
0x130/0x360
[ 7247.059994]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0set_root+0x11=
8/0x220
[ 7247.060066]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0nd_jump_root+=
0x100/0x170
[ 7247.060111]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0path_init+0x6=
40/0x7b0
[ 7247.060193]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0path_lookupat=
+0x3c/0x1b0
[ 7247.060257]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0filename_look=
up.part.60+0xa0/0x170
[ 7247.060323]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0do_mount+0xa8=
/0xc00
[ 7247.060381]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0devtmpfsd+0x9=
4/0xe0
[ 7247.060436]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0kthread+0x1a8=
/0x1b0
[ 7247.060481]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ret_from_kern=
el_thread+0x5c/0x74
[ 7247.060563]=C2=A0=C2=A0}
[ 7247.060597]=C2=A0=C2=A0... key=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0at: =
[<c00000000509c9e8>] __key.27999+0x0/0x10
[ 7247.060676]=C2=A0=C2=A0... acquired at:
[ 7247.060723]=C2=A0=C2=A0=C2=A0=C2=A0lock_acquire+0x130/0x360
[ 7247.060768]=C2=A0=C2=A0=C2=A0=C2=A0d_path+0x194/0x3f0
[ 7247.060810]=C2=A0=C2=A0=C2=A0=C2=A0file_path+0x24/0x40
[ 7247.060869]=C2=A0=C2=A0=C2=A0=C2=A0loop_attr_do_show_backing_file+0x5c=
/0x120 [loop]
[ 7247.060931]=C2=A0=C2=A0=C2=A0=C2=A0dev_attr_show+0x44/0xb0
[ 7247.060988]=C2=A0=C2=A0=C2=A0=C2=A0sysfs_kf_seq_show+0xbc/0x1d0
[ 7247.061042]=C2=A0=C2=A0=C2=A0=C2=A0kernfs_seq_show+0x44/0x60
[ 7247.061116]=C2=A0=C2=A0=C2=A0=C2=A0seq_read+0x1c4/0x620
[ 7247.061155]=C2=A0=C2=A0=C2=A0=C2=A0kernfs_fop_read+0x40/0x2b0
[ 7247.061204]=C2=A0=C2=A0=C2=A0=C2=A0__vfs_read+0x3c/0x70
[ 7247.061249]=C2=A0=C2=A0=C2=A0=C2=A0vfs_read+0xac/0x170
[ 7247.061292]=C2=A0=C2=A0=C2=A0=C2=A0ksys_read+0x7c/0x140
[ 7247.061341]=C2=A0=C2=A0=C2=A0=C2=A0system_call+0x5c/0x68

> ---
>  drivers/block/loop.c | 207 +++++++++++++++++++++++++++++++++++++------
>  drivers/block/loop.h |  11 ++-
>  2 files changed, 188 insertions(+), 30 deletions(-)
>=20
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 739b372a5112..a9b05cacc393 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -70,7 +70,6 @@
>  #include <linux/writeback.h>
>  #include <linux/completion.h>
>  #include <linux/highmem.h>
> -#include <linux/kthread.h>
>  #include <linux/splice.h>
>  #include <linux/sysfs.h>
>  #include <linux/miscdevice.h>
> @@ -83,6 +82,8 @@
> =20
>  #include <linux/uaccess.h>
> =20
> +#define LOOP_IDLE_WORKER_TIMEOUT (60 * HZ)
> +
>  static DEFINE_IDR(loop_index_idr);
>  static DEFINE_MUTEX(loop_ctl_mutex);
> =20
> @@ -891,27 +892,100 @@ static void loop_config_discard(struct loop_devi=
ce *lo)
> =20
>  static void loop_unprepare_queue(struct loop_device *lo)
>  {
> -	kthread_flush_worker(&lo->worker);
> -	kthread_stop(lo->worker_task);
> -}
> -
> -static int loop_kthread_worker_fn(void *worker_ptr)
> -{
> -	current->flags |=3D PF_LESS_THROTTLE | PF_MEMALLOC_NOIO;
> -	return kthread_worker_fn(worker_ptr);
> +	destroy_workqueue(lo->workqueue);
>  }
> =20
>  static int loop_prepare_queue(struct loop_device *lo)
>  {
> -	kthread_init_worker(&lo->worker);
> -	lo->worker_task =3D kthread_run(loop_kthread_worker_fn,
> -			&lo->worker, "loop%d", lo->lo_number);
> -	if (IS_ERR(lo->worker_task))
> +	lo->workqueue =3D alloc_workqueue("loop%d",
> +					WQ_UNBOUND | WQ_FREEZABLE |
> +					WQ_MEM_RECLAIM,
> +					lo->lo_number);
> +	if (IS_ERR(lo->workqueue))
>  		return -ENOMEM;
> -	set_user_nice(lo->worker_task, MIN_NICE);
> +
>  	return 0;
>  }
> =20
> +struct loop_worker {
> +	struct rb_node rb_node;
> +	struct work_struct work;
> +	struct list_head cmd_list;
> +	struct list_head idle_list;
> +	struct loop_device *lo;
> +	struct cgroup_subsys_state *css;
> +	unsigned long last_ran_at;
> +};
> +
> +static void loop_workfn(struct work_struct *work);
> +static void loop_rootcg_workfn(struct work_struct *work);
> +static void loop_free_idle_workers(struct timer_list *timer);
> +
> +static void loop_queue_work(struct loop_device *lo, struct loop_cmd *c=
md)
> +{
> +	struct rb_node **node =3D &(lo->worker_tree.rb_node), *parent =3D NUL=
L;
> +	struct loop_worker *cur_worker, *worker =3D NULL;
> +	struct work_struct *work;
> +	struct list_head *cmd_list;
> +
> +	spin_lock_irq(&lo->lo_lock);
> +
> +	if (!cmd->css)
> +		goto queue_work;
> +
> +	node =3D &lo->worker_tree.rb_node;
> +
> +	while (*node) {
> +		parent =3D *node;
> +		cur_worker =3D container_of(*node, struct loop_worker, rb_node);
> +		if (cur_worker->css =3D=3D cmd->css) {
> +			worker =3D cur_worker;
> +			break;
> +		} else if ((long)cur_worker->css < (long)cmd->css) {
> +			node =3D &(*node)->rb_left;
> +		} else {
> +			node =3D &(*node)->rb_right;
> +		}
> +	}
> +	if (worker)
> +		goto queue_work;
> +
> +	worker =3D kzalloc(sizeof(struct loop_worker), GFP_NOWAIT | __GFP_NOW=
ARN);
> +	/*
> +	 * In the event we cannot allocate a worker, just queue on the
> +	 * rootcg worker
> +	 */
> +	if (!worker)
> +		goto queue_work;
> +
> +	worker->css =3D cmd->css;
> +	css_get(worker->css);
> +	INIT_WORK(&worker->work, loop_workfn);
> +	INIT_LIST_HEAD(&worker->cmd_list);
> +	INIT_LIST_HEAD(&worker->idle_list);
> +	worker->lo =3D lo;
> +	rb_link_node(&worker->rb_node, parent, node);
> +	rb_insert_color(&worker->rb_node, &lo->worker_tree);
> +queue_work:
> +	if (worker) {
> +		/*
> +		 * We need to remove from the idle list here while
> +		 * holding the lock so that the idle timer doesn't
> +		 * free the worker
> +		 */
> +		if (!list_empty(&worker->idle_list))
> +			list_del_init(&worker->idle_list);
> +		work =3D &worker->work;
> +		cmd_list =3D &worker->cmd_list;
> +	} else {
> +		work =3D &lo->rootcg_work;
> +		cmd_list =3D &lo->rootcg_cmd_list;
> +	}
> +	list_add_tail(&cmd->list_entry, cmd_list);
> +	queue_work(lo->workqueue, work);
> +	spin_unlock_irq(&lo->lo_lock);
> +}
> +
>  static void loop_update_rotational(struct loop_device *lo)
>  {
>  	struct file *file =3D lo->lo_backing_file;
> @@ -993,6 +1067,12 @@ static int loop_set_fd(struct loop_device *lo, fm=
ode_t mode,
> =20
>  	set_device_ro(bdev, (lo_flags & LO_FLAGS_READ_ONLY) !=3D 0);
> =20
> +	INIT_WORK(&lo->rootcg_work, loop_rootcg_workfn);
> +	INIT_LIST_HEAD(&lo->rootcg_cmd_list);
> +	INIT_LIST_HEAD(&lo->idle_worker_list);
> +	lo->worker_tree =3D RB_ROOT;
> +	timer_setup(&lo->timer, loop_free_idle_workers,
> +		TIMER_DEFERRABLE);
>  	lo->use_dio =3D false;
>  	lo->lo_device =3D bdev;
>  	lo->lo_flags =3D lo_flags;
> @@ -1101,6 +1181,7 @@ static int __loop_clr_fd(struct loop_device *lo, =
bool release)
>  	int err =3D 0;
>  	bool partscan =3D false;
>  	int lo_number;
> +	struct loop_worker *pos, *worker;
> =20
>  	mutex_lock(&loop_ctl_mutex);
>  	if (WARN_ON_ONCE(lo->lo_state !=3D Lo_rundown)) {
> @@ -1117,9 +1198,28 @@ static int __loop_clr_fd(struct loop_device *lo,=
 bool release)
>  	/* freeze request queue during the transition */
>  	blk_mq_freeze_queue(lo->lo_queue);
> =20
> +	/*
> +	 * Ordering here is a bit tricky:
> +	 *
> +	 * 1) flush/destroy workqueue without lock held so outstanding
> +	 * I/O is issued and all active workers go idle
> +	 *
> +	 * 2) Grab lock, free all idle workers
> +	 *
> +	 * 3) unlock, del_timer_sync so if timer raced it will be a no-op
> +	 */
> +	loop_unprepare_queue(lo);
>  	spin_lock_irq(&lo->lo_lock);
>  	lo->lo_backing_file =3D NULL;
> +	list_for_each_entry_safe(worker, pos, &lo->idle_worker_list,
> +				idle_list) {
> +		list_del(&worker->idle_list);
> +		rb_erase(&worker->rb_node, &lo->worker_tree);
> +		css_put(worker->css);
> +		kfree(worker);
> +	}
>  	spin_unlock_irq(&lo->lo_lock);
> +	del_timer_sync(&lo->timer);
> =20
>  	loop_release_xfer(lo);
>  	lo->transfer =3D NULL;
> @@ -1154,7 +1254,6 @@ static int __loop_clr_fd(struct loop_device *lo, =
bool release)
> =20
>  	partscan =3D lo->lo_flags & LO_FLAGS_PARTSCAN && bdev;
>  	lo_number =3D lo->lo_number;
> -	loop_unprepare_queue(lo);
>  out_unlock:
>  	mutex_unlock(&loop_ctl_mutex);
>  	if (partscan) {
> @@ -1932,7 +2031,7 @@ static blk_status_t loop_queue_rq(struct blk_mq_h=
w_ctx *hctx,
>  	} else
>  #endif
>  		cmd->css =3D NULL;
> -	kthread_queue_work(&lo->worker, &cmd->work);
> +	loop_queue_work(lo, cmd);
> =20
>  	return BLK_STS_OK;
>  }
> @@ -1958,26 +2057,82 @@ static void loop_handle_cmd(struct loop_cmd *cm=
d)
>  	}
>  }
> =20
> -static void loop_queue_work(struct kthread_work *work)
> +static void loop_set_timer(struct loop_device *lo)
> +{
> +	timer_reduce(&lo->timer, jiffies + LOOP_IDLE_WORKER_TIMEOUT);
> +}
> +
> +static void loop_process_work(struct loop_worker *worker,
> +			struct list_head *cmd_list, struct loop_device *lo)
>  {
> -	struct loop_cmd *cmd =3D
> -		container_of(work, struct loop_cmd, work);
> +	int orig_flags =3D current->flags;
> +	struct loop_cmd *cmd;
> =20
> -	loop_handle_cmd(cmd);
> +	current->flags |=3D PF_LESS_THROTTLE | PF_MEMALLOC_NOIO;
> +	spin_lock_irq(&lo->lo_lock);
> +	while (!list_empty(cmd_list)) {
> +		cmd =3D container_of(
> +			cmd_list->next, struct loop_cmd, list_entry);
> +		list_del(cmd_list->next);
> +		spin_unlock_irq(&lo->lo_lock);
> +
> +		loop_handle_cmd(cmd);
> +		cond_resched();
> +
> +		spin_lock_irq(&lo->lo_lock);
> +	}
> +
> +	/*
> +	 * We only add to the idle list if there are no pending cmds
> +	 * *and* the worker will not run again which ensures that it
> +	 * is safe to free any worker on the idle list
> +	 */
> +	if (worker && !work_pending(&worker->work)) {
> +		worker->last_ran_at =3D jiffies;
> +		list_add_tail(&worker->idle_list, &lo->idle_worker_list);
> +		loop_set_timer(lo);
> +	}
> +	spin_unlock_irq(&lo->lo_lock);
> +	current->flags =3D orig_flags;
>  }
> =20
> -static int loop_init_request(struct blk_mq_tag_set *set, struct reques=
t *rq,
> -		unsigned int hctx_idx, unsigned int numa_node)
> +static void loop_workfn(struct work_struct *work)
>  {
> -	struct loop_cmd *cmd =3D blk_mq_rq_to_pdu(rq);
> +	struct loop_worker *worker =3D
> +		container_of(work, struct loop_worker, work);
> +	loop_process_work(worker, &worker->cmd_list, worker->lo);
> +}
> =20
> -	kthread_init_work(&cmd->work, loop_queue_work);
> -	return 0;
> +static void loop_rootcg_workfn(struct work_struct *work)
> +{
> +	struct loop_device *lo =3D
> +		container_of(work, struct loop_device, rootcg_work);
> +	loop_process_work(NULL, &lo->rootcg_cmd_list, lo);
> +}
> +
> +static void loop_free_idle_workers(struct timer_list *timer)
> +{
> +	struct loop_device *lo =3D container_of(timer, struct loop_device, ti=
mer);
> +	struct loop_worker *pos, *worker;
> +
> +	spin_lock_irq(&lo->lo_lock);
> +	list_for_each_entry_safe(worker, pos, &lo->idle_worker_list,
> +				idle_list) {
> +		if (time_is_after_jiffies(worker->last_ran_at +
> +						LOOP_IDLE_WORKER_TIMEOUT))
> +			break;
> +		list_del(&worker->idle_list);
> +		rb_erase(&worker->rb_node, &lo->worker_tree);
> +		css_put(worker->css);
> +		kfree(worker);
> +	}
> +	if (!list_empty(&lo->idle_worker_list))
> +		loop_set_timer(lo);
> +	spin_unlock_irq(&lo->lo_lock);
>  }
> =20
>  static const struct blk_mq_ops loop_mq_ops =3D {
>  	.queue_rq       =3D loop_queue_rq,
> -	.init_request	=3D loop_init_request,
>  	.complete	=3D lo_complete_rq,
>  };
> =20
> diff --git a/drivers/block/loop.h b/drivers/block/loop.h
> index af75a5ee4094..87fd0e372227 100644
> --- a/drivers/block/loop.h
> +++ b/drivers/block/loop.h
> @@ -14,7 +14,6 @@
>  #include <linux/blk-mq.h>
>  #include <linux/spinlock.h>
>  #include <linux/mutex.h>
> -#include <linux/kthread.h>
>  #include <uapi/linux/loop.h>
> =20
>  /* Possible states of device */
> @@ -54,8 +53,12 @@ struct loop_device {
> =20
>  	spinlock_t		lo_lock;
>  	int			lo_state;
> -	struct kthread_worker	worker;
> -	struct task_struct	*worker_task;
> +	struct workqueue_struct *workqueue;
> +	struct work_struct      rootcg_work;
> +	struct list_head        rootcg_cmd_list;
> +	struct list_head        idle_worker_list;
> +	struct rb_root          worker_tree;
> +	struct timer_list       timer;
>  	bool			use_dio;
>  	bool			sysfs_inited;
> =20
> @@ -65,7 +68,7 @@ struct loop_device {
>  };
> =20
>  struct loop_cmd {
> -	struct kthread_work work;
> +	struct list_head list_entry;
>  	bool use_aio; /* use AIO interface to handle I/O */
>  	atomic_t ref; /* only for aio */
>  	long ret;