Re: [PATCH] arm64/hugetlb: Reserve CMA areas for gigantic pages on 16K and 64K configs

kernel test robot
2020-06-23T09:25:50Z

[-- Attachment #1: Type: text/plain, Size: 2609 bytes --]

Hi Anshuman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.8-rc2]
[also build test ERROR on next-20200623]
[cannot apply to arm64/for-next/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/arm64-hugetlb-Reserve-CMA-areas-for-gigantic-pages-on-16K-and-64K-configs/20200623-142507
base: 48778464bb7d346b47157d21ffde2af6b2d39110
config: arm64-allnoconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

arch/arm64/mm/init.c: In function 'bootmem_init':
>> arch/arm64/mm/init.c:428:2: error: implicit declaration of function 'arm64_hugetlb_cma_reserve'; did you mean 'hugetlb_cma_reserve'? [-Werror=implicit-function-declaration]
428 | arm64_hugetlb_cma_reserve();
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| hugetlb_cma_reserve
cc1: some warnings being treated as errors

vim +428 arch/arm64/mm/init.c

408
409 void __init bootmem_init(void)
410 {
411 unsigned long min, max;
412
413 min = PFN_UP(memblock_start_of_DRAM());
414 max = PFN_DOWN(memblock_end_of_DRAM());
415
416 early_memtest(min << PAGE_SHIFT, max << PAGE_SHIFT);
417
418 max_pfn = max_low_pfn = max;
419 min_low_pfn = min;
420
421 arm64_numa_init();
422
423 /*
424 * must be done after arm64_numa_init() which calls numa_init() to
425 * initialize node_online_map that gets used in hugetlb_cma_reserve()
426 * while allocating required CMA size across online nodes.
427 */
> 428 arm64_hugetlb_cma_reserve();
429
430 /*
431 * Sparsemem tries to allocate bootmem in memory_present(), so must be
432 * done after the fixed reservations.
433 */
434 memblocks_present();
435
436 sparse_init();
437 zone_sizes_init(min, max);
438
439 memblock_dump_all();
440 }
441

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8161 bytes --]