From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59125C433DF for ; Wed, 1 Jul 2020 08:22:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 25C5B20775 for ; Wed, 1 Jul 2020 08:22:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25C5B20775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ABC828D001C; Wed, 1 Jul 2020 04:22:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6CA98D0012; Wed, 1 Jul 2020 04:22:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95DF98D001C; Wed, 1 Jul 2020 04:22:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 831BF8D0012 for ; Wed, 1 Jul 2020 04:22:14 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4EB4B2DFC for ; Wed, 1 Jul 2020 08:22:14 +0000 (UTC) X-FDA: 76988814588.21.coil17_2401d8b26e7f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 1D049180442C0 for ; Wed, 1 Jul 2020 08:22:14 +0000 (UTC) X-HE-Tag: coil17_2401d8b26e7f X-Filterd-Recvd-Size: 2444 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Jul 2020 08:22:13 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ED795AF21; Wed, 1 Jul 2020 08:22:11 +0000 (UTC) Message-ID: <1593591727.3586.2.camel@suse.de> Subject: Re: [PATCH v3 00/15] HWPOISON: soft offline rework From: Oscar Salvador To: Qian Cai , nao.horiguchi@gmail.com Cc: linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, tony.luck@intel.com, david@redhat.com, aneesh.kumar@linux.vnet.ibm.com, zeil@yandex-team.ru, naoya.horiguchi@nec.com, linux-kernel@vger.kernel.org Date: Wed, 01 Jul 2020 10:22:07 +0200 In-Reply-To: <1593498910.3046.2.camel@suse.de> References: <20200624150137.7052-1-nao.horiguchi@gmail.com> <20200630050803.GA2747@lca.pw> <1593498910.3046.2.camel@suse.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1D049180442C0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2020-06-30 at 08:35 +0200, Oscar Salvador wrote: > > Even after applied the compling fix, > > > > https://lore.kernel.org/linux-mm/20200628065409.GA546944@u2004/ > > > > madvise(MADV_SOFT_OFFLINE) will fail with EIO with hugetlb where it > > would succeed without this series. Steps: > > > > # git clone https://github.com/cailca/linux-mm > > # cd linux-mm; make > > # ./random 1 (Need at least two NUMA memory nodes) > > start: migrate_huge_offline > > - use NUMA nodes 0,4. > > - mmap and free 8388608 bytes hugepages on node 0 > > - mmap and free 8388608 bytes hugepages on node 4 > > madvise: Input/output error > > I think I know why. > It's been a while since I took a look, but I compared the posted > patchset with my newest patchset I had ready and I saw I made some > changes with regard of hugetlb pages. > > I will be taking a look, although it might be better to re-post the > patchset instead of adding a fix on top since the changes are a bit > substantial. Yap, I just confirmed this. Posted version had some flaws wrt. hugetlb pages, that is why I was working on a v3. I am rebasing my v3 on top of the mm with the posted patchset reverted. I expect to post it on Friday. -- Oscar Salvador SUSE L3