From: David Hildenbrand <david@redhat.com>
To: Wupeng Ma <mawupeng1@huawei.com>,
akpm@linux-foundation.org, catalin.marinas@arm.com,
will@kernel.org, corbet@lwn.net
Cc: ardb@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zyccr.com, dvhart@infradead.org, andy@infradead.org,
rppt@kernel.org, paulmck@kernel.org, peterz@infradead.org,
jroedel@suse.de, songmuchun@bytedance.com, macro@orcam.me.uk,
frederic@kernel.org, W_Armin@gmx.de, john.garry@huawei.com,
seanjc@google.com, tsbogend@alpha.franken.de,
anshuman.khandual@arm.com, chenhuacai@kernel.org,
gpiccoli@igalia.com, mark.rutland@arm.com,
wangkefeng.wang@huawei.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org,
linux-ia64@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 7/9] mm: Calc the right pfn if page size is not 4K
Date: Mon, 28 Mar 2022 14:33:44 +0200 [thread overview]
Message-ID: <15e3f11b-1551-a9c2-c348-bbe1ae1d9ef7@redhat.com> (raw)
In-Reply-To: <20220326064632.131637-8-mawupeng1@huawei.com>
On 26.03.22 07:46, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@huawei.com>
>
> Pervious 0x100000 is used to check the 4G limit in
s/Pervious/Previous/
> find_zone_movable_pfns_for_nodes(). This is right in x86 because
> the page size can only be 4K. But 16K and 64K are available in
> arm64. So replate it with SIZE_4G >> PAGE_SHIFT.
s/replate/replace/
>
> Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 6e0b4596cde9..41fd987b5b93 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -7811,7 +7811,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)
>
> usable_startpfn = memblock_region_memory_base_pfn(r);
>
> - if (usable_startpfn < 0x100000) {
> + if (usable_startpfn < (SZ_4G >> PAGE_SHIFT)) {
PHYS_PFN(SZ_4G)
?
> mem_below_4gb_not_mirrored = true;
> continue;
> }
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-03-28 12:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 6:46 [PATCH 0/9] introduce mirrored memory support for arm64 Wupeng Ma
2022-03-26 6:46 ` [PATCH 1/9] efi: Make efi_print_memmap() public Wupeng Ma
2022-03-26 6:46 ` [PATCH 2/9] arm64: efi: Add fake memory support Wupeng Ma
2022-03-26 6:46 ` [PATCH 3/9] efi: Make efi_find_mirror() public Wupeng Ma
2022-03-26 6:46 ` [PATCH 4/9] arm64/mirror: arm64 enabling - find mirrored memory ranges Wupeng Ma
2022-03-26 6:46 ` [PATCH 5/9] mm: Ratelimited mirrored memory related warning messages Wupeng Ma
2022-03-26 6:46 ` [PATCH 6/9] mm: Demote warning message in vmemmap_verify() to debug level Wupeng Ma
2022-03-26 6:46 ` [PATCH 7/9] mm: Calc the right pfn if page size is not 4K Wupeng Ma
2022-03-28 12:33 ` David Hildenbrand [this message]
2022-03-29 1:14 ` mawupeng
2022-03-26 6:46 ` [PATCH 8/9] efi: Disable mirror feature if kernelcore is not specified Wupeng Ma
2022-03-26 6:46 ` [PATCH 9/9] ia64/efi: Code simplification in efi_init Wupeng Ma
2022-03-29 8:26 ` [PATCH 0/9] introduce mirrored memory support for arm64 Ard Biesheuvel
2022-03-29 11:03 ` mawupeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15e3f11b-1551-a9c2-c348-bbe1ae1d9ef7@redhat.com \
--to=david@redhat.com \
--cc=W_Armin@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=andy@infradead.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=frederic@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=hpa@zyccr.com \
--cc=john.garry@huawei.com \
--cc=jroedel@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=macro@orcam.me.uk \
--cc=mark.rutland@arm.com \
--cc=mawupeng1@huawei.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).