From: Jerome Marchand <jmarchan@redhat.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] mm: allow to set overcommit ratio more precisely
Date: Thu, 7 Nov 2013 05:43:48 -0500 (EST) [thread overview]
Message-ID: <1605509214.19935074.1383821028439.JavaMail.root@redhat.com> (raw)
In-Reply-To: <527AD5A2.70902@intel.com>
----- Original Message -----
> From: "Dave Hansen" <dave.hansen@intel.com>
> To: "Andrew Morton" <akpm@linux-foundation.org>, "Jerome Marchand" <jmarchan@redhat.com>
> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
> Sent: Thursday, November 7, 2013 12:49:54 AM
> Subject: Re: [PATCH v4 2/2] mm: allow to set overcommit ratio more precisely
>
> On 11/06/2013 02:33 PM, Andrew Morton wrote:
> > On Wed, 6 Nov 2013 03:42:20 -0500 (EST) Jerome Marchand
> > <jmarchan@redhat.com> wrote:
> >> That was my first version of this patch (actually "kbytes" to avoid
> >> overflow).
> >> Dave raised the issue that it silently breaks the user interface:
> >> overcommit_ratio is zero while the system behaves differently.
> >
> > I don't understand that at all. We keep overcommit_ratio as-is, with
> > the same default values and add a different way of altering it. That
> > should be back-compatible?
>
> Reading the old thread, I think my main point was that we shouldn't
> output overcommit_ratio=0 when overcommit_bytes>0. We need to round up
> for numbers less than 1 so that folks don't think overcommit_ratio is _off_.
This is not how current *bytes work. Also the *ratio and *bytes value
would diverge if the amount of memory changes (e.g. memory hotplug).
>
> I was really just trying to talk you in to cramming the extra precision
> in to the _existing_ sysctl. :) I don't think bytes vs. ratio is really
> that big of a deal.
>
If everybody agrees on overcommit_kbytes, I can resend my original patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-11-07 10:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 12:56 [PATCH v4 1/2] mm: factor commit limit calculation Jerome Marchand
2013-10-18 12:56 ` [PATCH v4 2/2] mm: allow to set overcommit ratio more precisely Jerome Marchand
2013-11-05 23:53 ` Andrew Morton
2013-11-06 8:42 ` Jerome Marchand
2013-11-06 22:33 ` Andrew Morton
2013-11-06 23:49 ` Dave Hansen
2013-11-07 10:43 ` Jerome Marchand [this message]
2013-12-03 13:33 ` [PATCH v5] mm: add overcommit_kbytes sysctl variable Jerome Marchand
2013-12-03 22:14 ` Andrew Morton
2013-12-19 7:36 ` Olof Johansson
2013-11-05 23:51 ` [PATCH v4 1/2] mm: factor commit limit calculation Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605509214.19935074.1383821028439.JavaMail.root@redhat.com \
--to=jmarchan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).