linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Liu Xiang <liu.xiang@zlingsmart.com>
To: linux-mm@kvack.org
Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, liuxiang_1999@126.com,
	Liu Xiang <liu.xiang@zlingsmart.com>,
	Pan Jiagen <pan.jiagen@zlingsmart.com>
Subject: [PATCH v2] mm: hugetlb: fix type of delta parameter and related local variables in gather_surplus_pages()
Date: Thu, 19 Nov 2020 21:48:53 +0800	[thread overview]
Message-ID: <1605793733-3573-1-git-send-email-liu.xiang@zlingsmart.com> (raw)

On 64-bit machine, delta variable in hugetlb_acct_memory() may be larger
than 0xffffffff, but gather_surplus_pages() can only use the low 32-bit
value now. So we need to fix type of delta parameter and related local
variables in gather_surplus_pages().

Reported-by: Ma Chenggong <ma.chenggong@zlingsmart.com>
Signed-off-by: Liu Xiang <liu.xiang@zlingsmart.com>
Signed-off-by: Pan Jiagen <pan.jiagen@zlingsmart.com>

---
Changes in v2:
  as suggested by Mike, apply the same fix to the related local
  variables in gather_surplus_pages().
---
---
 mm/hugetlb.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 37f15c3..3797401 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1943,13 +1943,14 @@ struct page *alloc_huge_page_vma(struct hstate *h, struct vm_area_struct *vma,
  * Increase the hugetlb pool such that it can accommodate a reservation
  * of size 'delta'.
  */
-static int gather_surplus_pages(struct hstate *h, int delta)
+static int gather_surplus_pages(struct hstate *h, long delta)
 	__must_hold(&hugetlb_lock)
 {
 	struct list_head surplus_list;
 	struct page *page, *tmp;
-	int ret, i;
-	int needed, allocated;
+	int ret;
+	long i;
+	long needed, allocated;
 	bool alloc_ok = true;
 
 	needed = (h->resv_huge_pages + delta) - h->free_huge_pages;
-- 
1.9.1



             reply	other threads:[~2020-11-19 13:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 13:48 Liu Xiang [this message]
2020-11-19 18:34 ` [PATCH v2] mm: hugetlb: fix type of delta parameter and related local variables in gather_surplus_pages() Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1605793733-3573-1-git-send-email-liu.xiang@zlingsmart.com \
    --to=liu.xiang@zlingsmart.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuxiang_1999@126.com \
    --cc=mike.kravetz@oracle.com \
    --cc=pan.jiagen@zlingsmart.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).