From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18DE9C4345F for ; Mon, 6 May 2024 07:25:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5ED716B0083; Mon, 6 May 2024 03:25:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CD956B0085; Mon, 6 May 2024 03:25:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48BA96B0087; Mon, 6 May 2024 03:25:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2A5F36B0083 for ; Mon, 6 May 2024 03:25:12 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 91F67160846 for ; Mon, 6 May 2024 07:25:11 +0000 (UTC) X-FDA: 82087134822.02.A2C2F77 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf14.hostedemail.com (Postfix) with ESMTP id 9EF6F100007 for ; Mon, 6 May 2024 07:25:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=nZznPeyz; spf=pass (imf14.hostedemail.com: domain of yanjun.zhu@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=yanjun.zhu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714980310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VNICsQwAZLEIq4FagMWJtT9l3ne94Q3HOggFLnvinbw=; b=fAH7WHh+TYYKitl2Po7DNmeMnCqgptoHi9xhbdXdj367EuYHlLRFCVuB6YvFh7zF5wCiDI Ddl+j3apjRI7JaDO/Cm0YoLMjYdd7B5+FOJWxf+8BK7MGzNcx7QU2F7hNHtIeYq/gROBds wZ63uKfASz/j08DibjVdySeNi9+DbU0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=nZznPeyz; spf=pass (imf14.hostedemail.com: domain of yanjun.zhu@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=yanjun.zhu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714980310; a=rsa-sha256; cv=none; b=3S9CSO1FYyFE42WN1ktVfIXzqI9V5dXJjf6YmAFngr17UUsN6GGHO+I0EgkN7PtnPNE53p BCyNDm0EjTeHdWI2lJmClQ9is9oEMZcEZRpelPpWiMTGKLtY9ogU/2kh0XRnhy+iorivQp fLc9dmHgWyxsJfDhH+M6Rf16EhUWndM= Message-ID: <1615fe92-d4ff-4ef2-9bd0-199aa9e3a426@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714980307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VNICsQwAZLEIq4FagMWJtT9l3ne94Q3HOggFLnvinbw=; b=nZznPeyzXvBnkwuymZAd7H5uP6FsRpvl2JfkIEHhVLGTRXN2z1loonY6p/619WY28zpwEl Bogs2+q+8zcc500vR6DNiQHdd+mPtphq8OjqAyhbN7IEoPG5hcFcOxw9uMk2A927K9UGj9 Kf4xW9Sd1i3DF1NmDYSRbBRBNofkxMI= Date: Mon, 6 May 2024 09:25:01 +0200 MIME-Version: 1.0 Subject: Re: [RFC RESEND 16/16] nvme-pci: use blk_rq_dma_map() for NVMe SGL To: Leon Romanovsky Cc: Christoph Hellwig , Robin Murphy , Marek Szyprowski , Joerg Roedel , Will Deacon , Jason Gunthorpe , Chaitanya Kulkarni , Chaitanya Kulkarni , Jonathan Corbet , Jens Axboe , Keith Busch , Sagi Grimberg , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, kvm@vger.kernel.org, linux-mm@kvack.org, Bart Van Assche , Damien Le Moal , Amir Goldstein , "josef@toxicpanda.com" , "Martin K. Petersen" , "daniel@iogearbox.net" , Dan Williams , "jack@suse.com" References: <016fc02cbfa9be3c156a6f74df38def1e09c08f1.1709635535.git.leon@kernel.org> <20240505132314.GC68202@unreal> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <20240505132314.GC68202@unreal> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: td34ib5xbozcjmr1yz3hhctb1pc5ojxk X-Rspamd-Queue-Id: 9EF6F100007 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714980309-723370 X-HE-Meta: U2FsdGVkX1+ryd1pusB43K2A1RGXJJ6+/82UoXWR4o/uPov5f+5p8iogacVL0k5g20zq/2AjvVM7NJDAPO36qvlDrk+yOKYkZtX1jFmq2arIW9o3IGAzy25vMG9HeCSvQ74z1JRrannpbhNgc0EaOtU/FXgq9gfFcJEI0M3PFMvr+Qmpo32wa4LLUF7KCGucljvBTAwqQ0rDSRdP0HRFmsiy+cAsA9HSV3l0gSd9kXIOnj7Q+N5hY89zn+Ho8UH3mGXkz2EdaBoJf5TlJiTg0er65XKYbtsW96Ri2U3oXOumj8WQNtD8x0BFHSATIohDZhBreQyzrFd62TRnCXMTUi2ONUP3rLM58ER567cRDnAM6Fb94N6QauYQtLNWenJ/5q3fyjz7kbpldvQG0c347FmP1XLfL8ia1r/34ClD4c+2IMhWsRPdPS4SwK4yxRSPZYjI9xb9n+nr0QpWmA1Qt03i7MiW944Fy6wNn21DYbvekXvP/LwVnb4hbrOceuj27XdWcIA8+gInFMF7XSG12eq7xBI6fLY07kXSBXMtKYzgfqSIvj+uENq4c7UClrlocNSxKGezw70AAXt3obQbxzbtg86vRoQwkSbAwPTXLs6VjXpQKGLXGlE/YXbIIYcl/WUSbopkx1kIFpVVyCNQZcUrVnGllKMpZf11bXuBFOoNpyvNJMZAG9Rcr7nw7Gb5i+9ha6kMEq+9nQseuaCm5eDWY7xjClop8eghI669ZzWHuPZWX63BI3eLD03MWPBYSrRGlVmZkJspoUOVpVOFg/yL4owFzfyw5rbfIywU4Tt75WfFKJl6JKRGgS13NO8VLHWAvKcCwXzWM3cgXdfHAzvrxS2qALV8s4DqNZBfc/o8NSvgg2DcnHkhIB+awv9BAKzmIGufPaEPybX7hFl2TLUSnHdwAUqKi5/x0Kta3AjAhaDLpKbmpsD4snClMNLGIqroTd7Y2alFlnuZ5nn SEBvQA2O GQrItIFyu5zNBQV980aL3gTZt9b+vHY370xUg2Tfb6u3L0v6Y3U9InhxetxBvgVD5xgE7CAEG5lj3+dRIDZFiaIclDWBeTvYQzEKFjLTSRTA5mNrE1nofb74/6wOKK4b7qAEgH4MonT4hwbYs9zD+axLrbGlmae9lqA1XMNjXA7DMia4+hIl0EoqOBci95wck7iYJE0JahiYXSvg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.05.24 15:23, Leon Romanovsky wrote: > On Fri, May 03, 2024 at 04:41:21PM +0200, Zhu Yanjun wrote: >> On 05.03.24 12:18, Leon Romanovsky wrote: >>> From: Chaitanya Kulkarni > <...> > >>> This is an RFC to demonstrate the newly added DMA APIs can be used to >>> map/unmap bvecs without the use of sg list, hence I've modified the pci >>> code to only handle SGLs for now. Once we have some agreement on the >>> structure of new DMA API I'll add support for PRPs along with all the >>> optimization that I've removed from the code for this RFC for NVMe SGLs >>> and PRPs. >>> > <...> > >>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c >>> index e6267a6aa380..140939228409 100644 >>> --- a/drivers/nvme/host/pci.c >>> +++ b/drivers/nvme/host/pci.c >>> @@ -236,7 +236,9 @@ struct nvme_iod { >>> unsigned int dma_len; /* length of single DMA segment mapping */ >>> dma_addr_t first_dma; >>> dma_addr_t meta_dma; >>> - struct sg_table sgt; >>> + struct dma_iova_attrs iova; >>> + dma_addr_t dma_link_address[128]; >> Why the length of this array is 128? Can we increase this length of the >> array? > It is combination of two things: > * Good enough value for this nvme RFC to pass simple test, which Chaitanya did. > * Output of various NVME_CTRL_* defines Thanks a lot. I enlarged this number to 512. It seems that it can work. Hope this will increase the performance. Best Regards, Zhu Yanjun > > Thanks -- Best Regards, Yanjun.Zhu