From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C126CD18130 for ; Mon, 14 Oct 2024 16:39:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52B896B008C; Mon, 14 Oct 2024 12:39:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DBC26B0092; Mon, 14 Oct 2024 12:39:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CB196B0093; Mon, 14 Oct 2024 12:39:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1F6406B008C for ; Mon, 14 Oct 2024 12:39:18 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5910AA1094 for ; Mon, 14 Oct 2024 16:39:03 +0000 (UTC) X-FDA: 82672767660.09.51BC6A4 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf30.hostedemail.com (Postfix) with ESMTP id D236480002 for ; Mon, 14 Oct 2024 16:39:03 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728923813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TKp0K5deGQniwtZgadaErbrosyMYrpeZO+p+zExxq5Q=; b=046uzTEgxS5FCe3Atq48o4uqcimEePQ63Mi6peozOW5eYfx6ebY9ZdcPlKjN23/PYuX/65 Y8u6uRuLasSChHciYsxy20xTORK3Q0gRg/mxBs/FxmCjjYC5XCtBTaAcXqMW0AOhmMwAHx l9LSVa9F+hh2y/QfvOCk/Z2H1UgbOdo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728923813; a=rsa-sha256; cv=none; b=trEtiRrkX8x3B2D9d3JxY7DgECoE8Ne+RCSqP8KvlopOba4Ore7YoOy4QVyfdY7vkfGhCX vCUK/YsyWsBJdIUYjE4wIx/jIbnUoRt/4Lw0Yg6TetR6DUFTaHKYFe1gSKZ3ltD8hGOa6L T3zBLvi9suDVQi8UDVBcgd935Bd4oX0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XS2rP6cbKz6H7Nq; Tue, 15 Oct 2024 00:34:45 +0800 (CST) Received: from frapeml100008.china.huawei.com (unknown [7.182.85.131]) by mail.maildlp.com (Postfix) with ESMTPS id 4B781140A34; Tue, 15 Oct 2024 00:39:13 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100008.china.huawei.com (7.182.85.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Oct 2024 18:39:12 +0200 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Mon, 14 Oct 2024 18:39:12 +0200 From: Shiju Jose To: Jonathan Cameron CC: "linux-edac@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , "Roberto Sassu" , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: RE: [PATCH v13 15/18] EDAC: Add memory repair control feature Thread-Topic: [PATCH v13 15/18] EDAC: Add memory repair control feature Thread-Index: AQHbGkjfMMgmWsWuUEKGOWnMNVqj8LKGVKEAgAAkG7A= Date: Mon, 14 Oct 2024 16:39:12 +0000 Message-ID: <162f5e44507b46029eebb007dedef0d5@huawei.com> References: <20241009124120.1124-1-shiju.jose@huawei.com> <20241009124120.1124-16-shiju.jose@huawei.com> <20241014172312.00007034@Huawei.com> In-Reply-To: <20241014172312.00007034@Huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.169.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Stat-Signature: 7pibcegngt6zwzh6woir5uuf65qsm8ut X-Rspamd-Queue-Id: D236480002 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728923943-212336 X-HE-Meta: U2FsdGVkX19NmLzy/1QhJb1H1qJ8nYaHHwdQHfIpt+lH+MQDv2fL1qaK1UyeUiEf037Aj91sdueByyUUIfL85XUv9qFi0w/FcjPQ0WeU0vfbzHeBLYQIbKVPgaoVUWr/BdcjX5MP3a469RNgn/vZHF+OIGBPktZlKhXKHYBRDleVO+o8vJbSusGksnCmV+1mlZyMi08Q3E6enJi49YS3HkFSPjTNiZjwGder2hN+Ab3JQDX3voo98KKYShR0qPFIcb8iPorUR6mI25I6W/K4KClAC1e7VjCS1DOzLztoVUCBuwAQo3y+pYwsvXvmL/nZSc5YOn9OsWUZ5FK6vnRjwaqNNbVpwkulWz4Ge9qiuFLH/tYHIALCOifEXKv9WbpgJaa9swVTQuW14bSptS0+sURYmrG7BUIAiY9IrhdH+PfoZSmniJSv3REwWXqtr7zP4iZ4Du4ee8YWDcOhTc0TLxyStkj79bx2aMCpkacQmkX9EQZxMV/V/JfB8/2AWRaVUrMkGeLGRCNdCil+EFdkcV1C0jh85lp/B3Lbd7wtBQ1xPM0HaDGIgFA8ACpebggjRV2mBhXQPvgR40NiSNsy2GfoMXLBlYGdQymFG4BMFaKlbkHSWEScsEyU+yZ8Kk8aoDo6Ld9+7JNkIYtIpB4wNtNW608iSZpS7ryNJXafDV8g+CYpMqgvhcaRYbQ4UiNCt2ivr/q0dtR+Gmup8RjnAhQXDPni1+kF6W0hiCdTYhLH75GH9gsiBEkg4OhYIJuONZQfwk6yuTboW3lWNLAvHGhBnWa4lF7eGgxboXcRbuzQvTo0vRQMZxaKL6uLH4UFYwaPhtnwSYIWqILIPKtR0q+WBaICw1a9v0Xw8HR2f0phjV9Ma5q4AqtzmEHVLS/q966B6JSadN5qY1Vm1lbu7pkYa2e3zfgoSPIZs38WkKU5fKM4ax/WeuCiQWqShvBDkb6gnL3pX7DBFgIErVR 7BGUanfK vaXhg76anrdUuPKDzSr+OCPVDZOY/M9i31ktVYuxRezatVzztPecqh15VQV8txXDBtJvkfdXQ5a8TTh9E1pSaArPjjP01aK5maSt5WhLcPy2OoCttcLRcSzNxMGQoe7fAxes7KWGvVPqYXEodAj+LIqXOnRXkCWBqBME2a834sDruyEc/d1wjqbVac57QxE1jZjvKV/RAe8OQ9/VnpqrbvpQRNeaP1d2gs5USgBRUExJb1eZEPyoUzFOfXWVC6y2vLmcMbxFLjRrn8eVXUA2lIdqRYzJV5Ydp6Fki6NDczW6QOM2WlIpE3bdE0QjdGMJkYHk9p4+Q3Qirxj90WTw92GclfQIlpglkGEWUtXTqnegdIrap0Xz9B4BLWSqxdf4hyi1pgfpT9ezJhsK4/xUHnG4B6qt0fg6eC0Xs0uQlC7QFkkefG7Ryc5pmgcsxx9Qs8SPvH1YZWdHF2LXyJDuaI+h1r8VyBTD8mT80SUecFsA/NBX0fnTVcMkotO4jzS6ixDRV7qjhUaYaVw7RYc8Aww0OE6Ni5f6CFQtaQlP+ZjAxmGS8TbvfT+Y6RYsEQNTwAB74t81CHAN8O0JwZBNbEnqNqPE2tWTWBQDP96QINmhim3iV6L/yuoFmN9gubBYzs0ni/AXzQ0xFqmjHWGWeqLteg7naFd9BrFK7Wx3xv1kRFmYxX5qP7xOVFJ0CZbaHVrCrZAU7lnqje2JpHv3LbrOiEVlR7JUYsoNF3/sz4xLExT7wTk0a52QgCEVOFQkDGCgMf2bApS9tYzuuCn3aVAe1zVk41fwxt/BbcqBIT3/xexCXXtSuA5MBuIBH8nuvADq75q3dz0rkkL8vMHs5jzqFOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >-----Original Message----- >From: Jonathan Cameron >Sent: 14 October 2024 17:23 >To: Shiju Jose >Cc: linux-edac@vger.kernel.org; linux-cxl@vger.kernel.org; linux- >acpi@vger.kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; >bp@alien8.de; tony.luck@intel.com; rafael@kernel.org; lenb@kernel.org; >mchehab@kernel.org; dan.j.williams@intel.com; dave@stgolabs.net; >dave.jiang@intel.com; alison.schofield@intel.com; vishal.l.verma@intel.com= ; >ira.weiny@intel.com; david@redhat.com; Vilas.Sridharan@amd.com; >leo.duran@amd.com; Yazen.Ghannam@amd.com; rientjes@google.com; >jiaqiyan@google.com; Jon.Grimm@amd.com; dave.hansen@linux.intel.com; >naoya.horiguchi@nec.com; james.morse@arm.com; jthoughton@google.com; >somasundaram.a@hpe.com; erdemaktas@google.com; pgonda@google.com; >duenwen@google.com; gthelen@google.com; >wschwartz@amperecomputing.com; dferguson@amperecomputing.com; >wbs@os.amperecomputing.com; nifan.cxl@gmail.com; tanxiaofei >; Zengtao (B) ; Roberto >Sassu ; kangkang.shen@futurewei.com; >wanghuiqiang ; Linuxarm > >Subject: Re: [PATCH v13 15/18] EDAC: Add memory repair control feature > >On Wed, 9 Oct 2024 13:41:16 +0100 > wrote: > >> From: Shiju Jose >> >> Add generic EDAC memory repair control, eg. PPR(Post Package Repair), >> memory sparing etc, control driver in order to control memory repairs >> in the system. Supports sPPR(soft PPR), hPPR(hard PPR), soft/hard >> memory sparing, memory sparing at cacheline/row/bank/rank granularity et= c. >> Device with memory repair features registers with EDAC device driver, >> which retrieves memory repair descriptor from EDAC memory repair >> driver and exposes the sysfs repair control attributes to userspace in >> /sys/bus/edac/devices//mem_repairX/. >> >> The common memory repair control interface abstracts the control of an >> arbitrary memory repair functionality to a common set of functions. >> The sysfs memory repair attribute nodes would be present only if the >> client driver has implemented the corresponding attribute callback >> function and passed in ops to the EDAC device driver during registration= . >> >> Signed-off-by: Shiju Jose [...] > >> + >> +What: /sys/bus/edac/devices//mem_repairX/hpa >> +Date: Oct 2024 >> +KernelVersion: 6.12 >> +Contact: linux-edac@vger.kernel.org >> +Description: >> + (WO) Set HPA (Host Physical Address) for memory repair. > >Can we not just read back what was written? Seems like userspace might ex= pect >that? I am fine to add read back. I did not add read back for controls because there was no such requirement= from the client driver and also tried to reduce the number of callbacks in the initial version.=20 Thanks, Shiju