Re: [RFC][PATCH] Rename PageChecked as PageMiscFS

David Howells
2005-08-11T09:31:12Z

Daniel Phillips <phillips@arcor.de> wrote:

> Note: I have not fully audited the NFS-related colliding use of page flags
> bit 8,

Nor will you be able to until the NFS caching patches are released.

> to verify that it really does not escape into VFS or MM from NFS, in fact I
> have misgivings about end_page_fs_misc which uses this flag

end_page_fs_misc() simply makes use of the same waitqueues as other page
flags. This is surely preferable to instituting a whole new table of
waitqueues just for this flag.

> but has no in-tree users to show how it is used

It did have one: fs/afs/. But the patch has been temporarily removed. Look
back into, say, 2.6.13-rc2-mm1.

> and, hmm, isn't even _GPL. What is up?

EXPORT_SYMBOL_GPL() is a bad idea. It should die as it gives the wrong
impression.

David