From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F17CECAAD6 for ; Fri, 26 Aug 2022 08:31:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3832D6B0075; Fri, 26 Aug 2022 04:31:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E54F6B0078; Fri, 26 Aug 2022 04:31:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15DD9940007; Fri, 26 Aug 2022 04:31:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 009496B0075 for ; Fri, 26 Aug 2022 04:31:58 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D001F1601B4 for ; Fri, 26 Aug 2022 08:31:58 +0000 (UTC) X-FDA: 79841075916.31.7BF5270 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf13.hostedemail.com (Postfix) with ESMTP id 7CD1C20021 for ; Fri, 26 Aug 2022 08:31:58 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id s31-20020a17090a2f2200b001faaf9d92easo7393963pjd.3 for ; Fri, 26 Aug 2022 01:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc; bh=ejcX4jVEjPdrkU9dU00T+efoVTYJPy0kG3uinoXmHSo=; b=qmSn+U7UOMfTh5bJbldCWYQMzI8jk/xzz6l13VdM0yIJu1bSu8OsRNo2qulPeCCNAE Y00MCO5PftrGLKUObBZ/e7EznloXzjELQF0h0VjTIlYi+yLgKcMbBbp2uSsGziQqoJ5U DW7IzctU9Lg3yglf2WxCdGP9mXZvjKHwhF7R7lk4xyKZ1T+giTLS6f8ZDlnyhG2fRQIA Y0trohdcerSE6/8mrUQ2cFRqMqTBokAtcP0r8rLA6pCqnfWR6R3oJ1ToIjsUYux7coTo oP8+1qk4szSRMwEHcYN8CPpOvOuoJlAnh62wTWL+Aa891nAF0k7zVoSKxY6VWVjRynnT NZ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc; bh=ejcX4jVEjPdrkU9dU00T+efoVTYJPy0kG3uinoXmHSo=; b=1XZ0DJrxljVubbubA+4DVafpnEi4/aHEq7GrtY5D1cAP2WIApkR2bxpFE5zSsklWtf mbot94X4maJI/xT+CkOdC85gyfKVPbOEswRvpUsrgq2NYa2Mqq0i4s+XwBsLnxSC6JVy OaaQFuu8QoHh6HdQX1qdonH42e6qHNAAms9Zj1A+7pc80fzlZpSFFQyLgvcrnow3KR6D jRW3W5Sc1hq3/UGzlyqXptOk0k8158CWD//zOVtAGbrPHB1tvpr/P5UD8IumI0bZgMR/ rDx4Xn9YWq27pElAjInhdiVrz1ZrdPAgGqgpvER2mlKtNJsHtrzkH6K/+fKzAGhYzrfY QLQg== X-Gm-Message-State: ACgBeo2rJcti/g+eLhXZAqVuMPSDc8EKYWOVGeJcPPXi5e10hjvF7Cpw aLo02d3MrzcMcZ3x2mPO1g== X-Google-Smtp-Source: AA6agR6IsHxv+NS3WcRPeGsCLiGaj9g0DHrOHdXBhcNVEf8r/Z+LHIF4VAngJkDr1WU/jvOjrx+44Q== X-Received: by 2002:a17:902:cf43:b0:172:86f3:586a with SMTP id e3-20020a170902cf4300b0017286f3586amr2703089plg.71.1661502717626; Fri, 26 Aug 2022 01:31:57 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id u2-20020a170902714200b0016f1ef2cd44sm934953plm.154.2022.08.26.01.31.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Aug 2022 01:31:56 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH 1/2] mm/damon: simplify the parameter passing for 'check_accesses' Date: Fri, 26 Aug 2022 16:31:17 +0800 Message-Id: <1661502678-19336-2-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1661502678-19336-1-git-send-email-kaixuxia@tencent.com> References: <1661502678-19336-1-git-send-email-kaixuxia@tencent.com> ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qmSn+U7U; spf=pass (imf13.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661502718; a=rsa-sha256; cv=none; b=UbDynpmz7p/ZzL0ovtZOLBLfu7NDag4J4IgV1zQQ4vnFlaMKKKe0SuOSxhpikMbpOUgjmM IyAOw+k3g4Zxjgzb/tHQ88LoHf7CX3JLJLvKqkSOZHY0HthkJ14oquqAVnHlgg+k47rFqC MxPJ3GlY6OUMXYDnEGwahbmbzsjZxss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661502718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=ejcX4jVEjPdrkU9dU00T+efoVTYJPy0kG3uinoXmHSo=; b=XKdzgKIUYKIaWnERp+l6OaTGHYDgt6OUZIGlx5oALKRC6qx4jVw5Q5hePj0fs11/pIFBfR EPdLOBhhR9BVCc7KMRBlOlzBeyeeBYnnpKNQStqi7g6zaNRqfeV26+m7rMFG3F4iNydDF2 YU4V/3/SlyXa8WlJv46jPOy/ErQVz70= Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qmSn+U7U; spf=pass (imf13.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Stat-Signature: 7tqzg97nx7xa8y4rwjhjtbzodq14zxy5 X-Rspamd-Queue-Id: 7CD1C20021 X-Rspamd-Server: rspam04 X-HE-Tag: 1661502718-747771 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia The parameter 'struct damon_ctx *ctx' is unnecessary in damon 'check_accesses' callback operation, so we can remove it. Signed-off-by: Kaixu Xia --- mm/damon/paddr.c | 5 ++--- mm/damon/vaddr.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index dc131c6a5403..6b0d9e6aa677 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -166,8 +166,7 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *page_sz) return result.accessed; } -static void __damon_pa_check_access(struct damon_ctx *ctx, - struct damon_region *r) +static void __damon_pa_check_access(struct damon_region *r) { static unsigned long last_addr; static unsigned long last_page_sz = PAGE_SIZE; @@ -196,7 +195,7 @@ static unsigned int damon_pa_check_accesses(struct damon_ctx *ctx) damon_for_each_target(t, ctx) { damon_for_each_region(r, t) { - __damon_pa_check_access(ctx, r); + __damon_pa_check_access(r); max_nr_accesses = max(r->nr_accesses, max_nr_accesses); } } diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 3c7b9d6dca95..c8c2f306bb6d 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -532,8 +532,7 @@ static bool damon_va_young(struct mm_struct *mm, unsigned long addr, * mm 'mm_struct' for the given virtual address space * r the region to be checked */ -static void __damon_va_check_access(struct damon_ctx *ctx, - struct mm_struct *mm, struct damon_region *r) +static void __damon_va_check_access(struct mm_struct *mm, struct damon_region *r) { static struct mm_struct *last_mm; static unsigned long last_addr; @@ -568,7 +567,7 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx) if (!mm) continue; damon_for_each_region(r, t) { - __damon_va_check_access(ctx, mm, r); + __damon_va_check_access(mm, r); max_nr_accesses = max(r->nr_accesses, max_nr_accesses); } mmput(mm); -- 2.27.0