From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC81ECAAD2 for ; Fri, 26 Aug 2022 08:32:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A87F26B0078; Fri, 26 Aug 2022 04:32:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A10EA940007; Fri, 26 Aug 2022 04:32:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 863126B007D; Fri, 26 Aug 2022 04:32:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7481C6B0078 for ; Fri, 26 Aug 2022 04:32:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 51B8B160457 for ; Fri, 26 Aug 2022 08:32:01 +0000 (UTC) X-FDA: 79841076042.23.8B12010 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf01.hostedemail.com (Postfix) with ESMTP id F068B40005 for ; Fri, 26 Aug 2022 08:32:00 +0000 (UTC) Received: by mail-pg1-f181.google.com with SMTP id v4so782068pgi.10 for ; Fri, 26 Aug 2022 01:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc; bh=HGwS3OwkfwDxERtuzQGvNMSPhF82bFpGx5C7eTjqwZo=; b=EPsyWypD33QcVW4SCyLjAm9PAiP16Aj8PplboIwAG/F66l5bvFtyXub0S7WHdAx3EH N9PCD+XOwb/KBcvxL1uy4doXAtRsIDC7ueYEzzMtjBcXDUuHksCdFVskFESSOvWsgpWt vCs/zq0HAtll3C4ovMN8CXWmai49o6E6h+sZLygFGpeKpuWEVP2AMUjBiMMqeT4Yssoo 68zWlRK3v3lAg9jc5xGgIZQ7YA3sE4ctnU34tTk7TS5PDC3IbOo1Hw/R1nj8PthFLidU RdLRci6dShTBBs+h3TWCGOr3Dwl2af/URPZbiP0bg7mewFQ557XGTouLcE27U/3NE7XH jyjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc; bh=HGwS3OwkfwDxERtuzQGvNMSPhF82bFpGx5C7eTjqwZo=; b=y9O0Zaas3tId48TlaGDWuD6KMyMEAUj7kayStly1YQu5SA098zgr6/lxEbw4r5b/j1 jxYDS54bXn+Hf3+gTYMfYFsFq+3ZDKT93iHzZ4k4K5fWlNMseOUJ1LFe5btP20LTfSDy 3PncGtVpf153kGDdSfDH5yp+Ho59ngnyGWXfKBaL0jImHvXgdHBtgaV45dy5hINj+3Er SIg5ZpG00QUC+RwNTprWX7xvoyxjxBr3/ye4L8Jrrbi1Plvss9f19fh+EQKfhUjvJ6zY Tlvmx0AoDYLD1voqrKhBx5PukxDY152uOFBcfKLqlsvFgP+9X4jmc6vi9WciNxAdYQqU OMGw== X-Gm-Message-State: ACgBeo15MNluGF5fmEF4nvB5Y74QNbGqtaMbn/Ly0ArK/6M7Bddvdvtc 6jipttS1eIzCQxrjR25q507aJiX4gA== X-Google-Smtp-Source: AA6agR5e26Dd4o1ct1Xh53Ya1Lc3TsdTH+bpgF9eqipht0V/Vb1I+zPgvR7uzY7+6zK5KFDxUqDtfQ== X-Received: by 2002:a63:1e1b:0:b0:42b:5561:529e with SMTP id e27-20020a631e1b000000b0042b5561529emr2435166pge.514.1661502720074; Fri, 26 Aug 2022 01:32:00 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id u2-20020a170902714200b0016f1ef2cd44sm934953plm.154.2022.08.26.01.31.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Aug 2022 01:31:59 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH 2/2] mm/damon/vaddr: remove comparison between mm and last_mm when checking region accesses Date: Fri, 26 Aug 2022 16:31:18 +0800 Message-Id: <1661502678-19336-3-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1661502678-19336-1-git-send-email-kaixuxia@tencent.com> References: <1661502678-19336-1-git-send-email-kaixuxia@tencent.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661502720; a=rsa-sha256; cv=none; b=F41XkVjppxPDfPzLGJlxaslGt3ssg1I7FZ7VmCOFG5ds1MvPml4oUYUqymVePDuV+WYaDV 4pSbwyilluiLri4EMZ0zgIGjIvTTuZ+g3qM8BI5fq8msQR0f718y5k/VdyDy0YmZIfWXL9 1pNH4kBlndb54E+VEPlPWeB4nB7rVdw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EPsyWypD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661502720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=HGwS3OwkfwDxERtuzQGvNMSPhF82bFpGx5C7eTjqwZo=; b=HhdBr9jcG6nrAzZNnYv4YnqrmPLU1BqgzvHzOJyPhh744H9/d6a90jvFTndGvnk9yORRvM fDlgt2LgsZxxSUm2bTgX9fyb0RIPugwwVEfEj16Md67FuSFnfHI/qpbTpvxygl+etuJqa+ uQLK/yBOf6m0uFQYd1boGkb8eCRGWsA= X-Stat-Signature: ra83napxbm1e6dyy9n8cdj85w55u69k6 X-Rspamd-Queue-Id: F068B40005 X-Rspam-User: X-Rspamd-Server: rspam11 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EPsyWypD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com X-HE-Tag: 1661502720-979407 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia The damon regions that belong to the same damon target have the same 'struct mm_struct *mm', so it's unnecessary to compare the mm and last_mm objects among the damon regions in one damon target when checking accesses. Signed-off-by: Kaixu Xia --- mm/damon/vaddr.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index c8c2f306bb6d..db9d0ab37a52 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -534,14 +534,13 @@ static bool damon_va_young(struct mm_struct *mm, unsigned long addr, */ static void __damon_va_check_access(struct mm_struct *mm, struct damon_region *r) { - static struct mm_struct *last_mm; static unsigned long last_addr; static unsigned long last_page_sz = PAGE_SIZE; static bool last_accessed; /* If the region is in the last checked page, reuse the result */ - if (mm == last_mm && (ALIGN_DOWN(last_addr, last_page_sz) == - ALIGN_DOWN(r->sampling_addr, last_page_sz))) { + if (ALIGN_DOWN(last_addr, last_page_sz) == + ALIGN_DOWN(r->sampling_addr, last_page_sz)) { if (last_accessed) r->nr_accesses++; return; @@ -551,7 +550,6 @@ static void __damon_va_check_access(struct mm_struct *mm, struct damon_region *r if (last_accessed) r->nr_accesses++; - last_mm = mm; last_addr = r->sampling_addr; } -- 2.27.0