From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 166F7ECAAD2 for ; Sat, 27 Aug 2022 09:03:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F0606B0075; Sat, 27 Aug 2022 05:03:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A337940008; Sat, 27 Aug 2022 05:03:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81AAA940007; Sat, 27 Aug 2022 05:03:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6B0596B0075 for ; Sat, 27 Aug 2022 05:03:19 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3E7BCABD3E for ; Sat, 27 Aug 2022 09:03:19 +0000 (UTC) X-FDA: 79844783718.03.445B593 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf21.hostedemail.com (Postfix) with ESMTP id 00F6B1C0028 for ; Sat, 27 Aug 2022 09:03:18 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id m10-20020a17090a730a00b001fa986fd8eeso10181894pjk.0 for ; Sat, 27 Aug 2022 02:03:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc; bh=BnthDXQwip9Q9g75mHYulJV0YY03kw/VBBFjsliYM+A=; b=oJYgfkP4CP3NNgASktL4x7ODjcR3+HD3vZEwb07NsH609p1YZorhMYaw3uBuhLsaSu LZl0QJbmhi0jUukkNquR9EvRQwgy1orz6Qlv9WmSDCJ2x/HAt8SuOhGRRAclg8A068o0 H6cfWJZSar0AKRZ3vshQt11x9r00U0mbpgkpZSeMSS1XYqBpesH0f5xFjODDp+uhyaJ0 wXCO8cvU6XjxJ3rp9P2CjOjUN1KMdy5Uu2ZDItMGzCzspltNns3YcHzTAc1sFYUDEM2c 7UXykdPmR0Y8hi+57sQCVryu7P2/zquX1LjrNBhpnUvGRqEkT+xapyZkXJm6wZ35As4O X0Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc; bh=BnthDXQwip9Q9g75mHYulJV0YY03kw/VBBFjsliYM+A=; b=KSJxZppl+7GH0ypTieb3luPI0Zt0oWuK1YUWTMEx4S8jWM4Xt0p7JGWn/rCnD4R1k+ ydbcwfhpJMYsdSbDq33Xqt6YNJCdAru2IhGRvmpqNxwIv3FwRi8YNVLgNOknTsff3hWC XEDULbKzIbv+dqyGtMTtXqjyCy5EOaJfSKXcTIJrRBWUcLFW4TGPBKxpxEccMdFqWwQq uXqRvJd2inH0I2O9KCM930sSVrxW+jgQayd4f3aT/Ermx2OxVlrtvxWBHL80KsJHSJXV jXSNTTxRgeDtQ9I4T2n45kkWA5Rr65BYxhT2Rr1wIuSjUwj9c6hzGNAJhJhqf7lE7xIT oQDQ== X-Gm-Message-State: ACgBeo06sNHdCJh62sC9WqB2K5e3B3yNDH5TXbp412We7+75lzd+/VJy nd7lJPJDlR0nEqOWluf9jw== X-Google-Smtp-Source: AA6agR5cNMunEZrg1m2YWRxKj5/mEUiiHmC6GSFb8/9x4IAe9RfU9EnhJkNT4Z4v232c7q5+3WCBeQ== X-Received: by 2002:a17:90b:1644:b0:1fb:ab0c:c5bf with SMTP id il4-20020a17090b164400b001fbab0cc5bfmr8493090pjb.27.1661590998059; Sat, 27 Aug 2022 02:03:18 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id s88-20020a17090a69e100b001fb09316a26sm2943332pjj.43.2022.08.27.02.03.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Aug 2022 02:03:17 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH v2 2/2] mm/damon/vaddr: remove comparison between mm and last_mm when checking region accesses Date: Sat, 27 Aug 2022 17:02:51 +0800 Message-Id: <1661590971-20893-3-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1661590971-20893-1-git-send-email-kaixuxia@tencent.com> References: <1661590971-20893-1-git-send-email-kaixuxia@tencent.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661590999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=BnthDXQwip9Q9g75mHYulJV0YY03kw/VBBFjsliYM+A=; b=VXL+3+qk2iizgwnKgqE+7Jjs1agjl8kCvb+KSKjoC2kuTgsduyO9IkWUeL2CAOP+1fC+zR LAhnq4neeXM/rhVwyNKoWqGu3SfO1IpEyZQXlBwj6ZEV/J7pzhiT+zAPVKOF6Dw7oh0OdS KqBo0oRQAyuAFs89jU/JZtOdd05hvx8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oJYgfkP4; spf=pass (imf21.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661590999; a=rsa-sha256; cv=none; b=4Z83s/QoB3VQQ9kIpSQqKVz480SR0SDM1E/B4hbiIn+I6FZZeurc3Z3m8XcwcFzoPYI6jp d8AlAk9QZylXBtR8tEOPrdP/Z9tqX9ZXiKPesiyEXz9IvXc/WEUuEqQ7nZtU0S+fiqE0Xy Ipr2vf8Yc21Xio4ENMWzRXiNzEv+20E= X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oJYgfkP4; spf=pass (imf21.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Stat-Signature: 9st8eoxd41nx1ta9io4isrnhfihni5bt X-Rspamd-Queue-Id: 00F6B1C0028 X-HE-Tag: 1661590998-243494 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia The damon regions that belong to the same damon target have the same 'struct mm_struct *mm', so it's unnecessary to compare the mm and last_mm objects among the damon regions in one damon target when checking accesses. But the check is necessary when the target changed in '__damon_va_check_accesses()', so we can simplify the whole operation by using the bool 'same_target' to indicate whether the target changed. Signed-off-by: Kaixu Xia --- mm/damon/vaddr.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index e481f81c3efb..5f66c826ee3a 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -533,15 +533,14 @@ static bool damon_va_young(struct mm_struct *mm, unsigned long addr, * r the region to be checked */ static void __damon_va_check_access(struct mm_struct *mm, - struct damon_region *r) + struct damon_region *r, bool same_target) { - static struct mm_struct *last_mm; static unsigned long last_addr; static unsigned long last_page_sz = PAGE_SIZE; static bool last_accessed; /* If the region is in the last checked page, reuse the result */ - if (mm == last_mm && (ALIGN_DOWN(last_addr, last_page_sz) == + if (same_target && (ALIGN_DOWN(last_addr, last_page_sz) == ALIGN_DOWN(r->sampling_addr, last_page_sz))) { if (last_accessed) r->nr_accesses++; @@ -552,7 +551,6 @@ static void __damon_va_check_access(struct mm_struct *mm, if (last_accessed) r->nr_accesses++; - last_mm = mm; last_addr = r->sampling_addr; } @@ -562,14 +560,17 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx) struct mm_struct *mm; struct damon_region *r; unsigned int max_nr_accesses = 0; + bool same_target; damon_for_each_target(t, ctx) { mm = damon_get_mm(t); if (!mm) continue; + same_target = false; damon_for_each_region(r, t) { - __damon_va_check_access(mm, r); + __damon_va_check_access(mm, r, same_target); max_nr_accesses = max(r->nr_accesses, max_nr_accesses); + same_target = true; } mmput(mm); } -- 2.27.0