From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A998DC6FA82 for ; Tue, 13 Sep 2022 09:12:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BC876B0073; Tue, 13 Sep 2022 05:12:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CC626B0074; Tue, 13 Sep 2022 05:12:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB22F8D0001; Tue, 13 Sep 2022 05:12:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DC23F6B0073 for ; Tue, 13 Sep 2022 05:12:30 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BF72A12020F for ; Tue, 13 Sep 2022 09:12:30 +0000 (UTC) X-FDA: 79906496460.14.69D3522 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf20.hostedemail.com (Postfix) with ESMTP id 772EF1C00BC for ; Tue, 13 Sep 2022 09:12:30 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id k21so636485pls.11 for ; Tue, 13 Sep 2022 02:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date; bh=EMAhRQenL2hUdqt4UEMSUYn6VhBs6usk5YM+b/UiubY=; b=QR4h9rBbXfMXwSfowuM29Txd3PECeQyRU2zLkwirxu6Xu2abQFq5FtiBLdiUVEddii +8A5gWBwuLdtY9/rQSRIdnxCGqq1RncDjqrwQFgQaM4jQp5e+M+amJh53VGIK2l2wmbG WOD3z7A+y5uJMimOycIJqQ+zbL03kHZSc8BkgNyjh/PPa0RcIneNj0IMPEfoY0/cHbBL nz0vVzqbxGqoO41lcKrh7cZYZWJRPU535kszr+rvh+Q15W4gTBRCS9bgyi+zeHnNlyfH 4dG1O1MXN/VO2WYWptHTfHKe+EpupAHhZJl/0MnGquj1wi+eJ8nds4FKPXGNcUtR0EtO s45Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=EMAhRQenL2hUdqt4UEMSUYn6VhBs6usk5YM+b/UiubY=; b=ooFhIGved5FWpHTBZ24B0eGr2wDddKDClVOcSG29RRSF2sICjwA6YE52ahcvwgNMgX EvWDkYsKoq2ZHLN8v0Jus9K2C2fnsllmtG0sRM68zgYWCT/1ltWucnljwQLlp0Gbb52h 9Gs6TyUhsJuZpzZnEbqwhQrlqTT7tz7AeqkNmzZ4vVN4KutUABAGUKAuy7rs4aHuLPc0 7GXMW3tvuRkTxC8BOfkMuIQ1Bus/7o5XeZ1z2YtD7D2HHKQe/B6rmZ9i0zwy08STr43h GC6yoKfoaxIrRtGjv87DHQ0KEo8tj4cGJKeKohxOpDDF9ET9iYNL9TRfJ9YO72c3XXIH NVVQ== X-Gm-Message-State: ACgBeo3zH2VKXb8nhYTLn3KEumLPwcI/zENJIPjeadE7WV3T/wWOIQB0 b5Gm9KhO5kPX4HAoyLw1HQ== X-Google-Smtp-Source: AA6agR5DxXSkOSzxyXwhhv9jgg+SwSheGvcNYeAQI3G+qRh9y7ZtRQmO490kndDSfsv/LAIvKJD3Fw== X-Received: by 2002:a17:90b:3ec2:b0:202:b123:29cc with SMTP id rm2-20020a17090b3ec200b00202b12329ccmr2974074pjb.167.1663060349560; Tue, 13 Sep 2022 02:12:29 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.3]) by smtp.gmail.com with ESMTPSA id h10-20020a170902680a00b0015e8d4eb1d5sm7804661plk.31.2022.09.13.02.12.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2022 02:12:28 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH 1/4] mm/damon: simplify the parameter passing for 'prepare_access_checks' Date: Tue, 13 Sep 2022 17:11:24 +0800 Message-Id: <1663060287-30201-2-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> References: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QR4h9rBb; spf=pass (imf20.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663060350; a=rsa-sha256; cv=none; b=CtjqBeMGjK/2aGDT916oV5mCdgMQL0fY8FCZ12spmRHXdheLCi6uptFYUAgz50LOthIJph F7SzNQ8QdP/DwFmu18UR/e0+X4QO2UewaSnSlwFRtN3Lmcbv1rnnomu/mPO9+lpZnW2Zaq Tz5lrZySJx56EO8X3d1W86VMVFMsITw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663060350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=EMAhRQenL2hUdqt4UEMSUYn6VhBs6usk5YM+b/UiubY=; b=LmH1ST4SYwrjojDFUD9LM5QoM4eY6Bn4kG7KyA7j6E23VktONJNW60DOjCIlzwQNKvvpKV tFceiu/EcbuJqa1PMpobuywfSlTNvX2lvWCM7FC/9L9PkFr+wGv3Io9NIDLa8KelC3Tqbf 8AdzV3ar1CkMJkwYlJ8zJIHXEQNgVZM= Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QR4h9rBb; spf=pass (imf20.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Queue-Id: 772EF1C00BC X-Rspamd-Server: rspam04 X-Stat-Signature: uc9957j6ngjuhr3dhjur4zqmmq9gocys X-HE-Tag: 1663060350-298516 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia The parameter 'struct damon_ctx *ctx' isn't used in the functions __damon_{p,v}a_prepare_access_check(), so we can remove it and simplify the parameter passing. Signed-off-by: Kaixu Xia --- mm/damon/paddr.c | 5 ++--- mm/damon/vaddr.c | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index 6b0d9e6aa677..f00cbe74a00e 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -63,8 +63,7 @@ static void damon_pa_mkold(unsigned long paddr) folio_put(folio); } -static void __damon_pa_prepare_access_check(struct damon_ctx *ctx, - struct damon_region *r) +static void __damon_pa_prepare_access_check(struct damon_region *r) { r->sampling_addr = damon_rand(r->ar.start, r->ar.end); @@ -78,7 +77,7 @@ static void damon_pa_prepare_access_checks(struct damon_ctx *ctx) damon_for_each_target(t, ctx) { damon_for_each_region(r, t) - __damon_pa_prepare_access_check(ctx, r); + __damon_pa_prepare_access_check(r); } } diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index c2c08c1b316b..39ea48d9cc15 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -397,8 +397,8 @@ static void damon_va_mkold(struct mm_struct *mm, unsigned long addr) * Functions for the access checking of the regions */ -static void __damon_va_prepare_access_check(struct damon_ctx *ctx, - struct mm_struct *mm, struct damon_region *r) +static void __damon_va_prepare_access_check(struct mm_struct *mm, + struct damon_region *r) { r->sampling_addr = damon_rand(r->ar.start, r->ar.end); @@ -416,7 +416,7 @@ static void damon_va_prepare_access_checks(struct damon_ctx *ctx) if (!mm) continue; damon_for_each_region(r, t) - __damon_va_prepare_access_check(ctx, mm, r); + __damon_va_prepare_access_check(mm, r); mmput(mm); } } -- 2.27.0