From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12646C6FA82 for ; Tue, 13 Sep 2022 09:12:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 714046B0074; Tue, 13 Sep 2022 05:12:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 650078D0001; Tue, 13 Sep 2022 05:12:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A0C26B0078; Tue, 13 Sep 2022 05:12:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3CFE56B0074 for ; Tue, 13 Sep 2022 05:12:33 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 14D36808B0 for ; Tue, 13 Sep 2022 09:12:33 +0000 (UTC) X-FDA: 79906496586.08.DC6E110 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf03.hostedemail.com (Postfix) with ESMTP id BE81F20088 for ; Tue, 13 Sep 2022 09:12:32 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id d82so11123148pfd.10 for ; Tue, 13 Sep 2022 02:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date; bh=d7BK1Sg/tQCQogt0rSecDlpjX+Yo/gtbxqyxdutICMQ=; b=F5EDu9R9IR0UvjFC7OdCUSJ/Po9JehilOSlp9+qm7VVdD2J1hV+psz6iqpAEFlT+Di iD30oZ7chQAvufHgLDNkrlCALvHSS9mx8LGhOPJwLjL+zVPwGaU1UvVtnavr5pfALoP1 KdU3CPHKbbNmehmOHD9iHUFmJtmk902qR164d3RXk2cqJlMnKHvXpdstz7uai0FfWTMO POou7hnMoIaF2tAgIzD17jkVHYzmBIfo0FyysmCPdcS1T98HqV/EkRJItxexF/L0hrp+ S9o+RtrEmojFyEQZtNlKIcgFLW4FRAgn6BILbJfplteXGBe9u7aSsdDAVfJcJYQc5pD1 JX2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=d7BK1Sg/tQCQogt0rSecDlpjX+Yo/gtbxqyxdutICMQ=; b=UB+eUy4V7wusqNgDqFgMjWBTy0Ws+mW0DXRcO/xT8Jpli1FYn/j3P/vMvssIFKKkMQ fynSHHyjwPvseTCtu6ZmexuxN6z9TnmTmQ/OshK0uDMrpcSWGhG/H1IWUt9O8InmcoR+ xUvAihXU8IbdT1YZ/JOabfvzUv8IiF4HOwYcpGxVXpytH6ZwxhXBrfuPrxlKUORuqGdE GhVB3+/NVzHn2h+G4s5xZ5nNnoUZ4KKQ/YaQweTbxMOeScAsvZ+ymRXmtzGOjfeV4aVD QtdaaIfGUyfyvnLEeYBRmJcrTqJkoykkWcnvoOWLY8h8MNyA5cZTMlkL5wHCajcX3tZX jgaA== X-Gm-Message-State: ACgBeo3YwvDVVj/Jqel+b1fOicXRrKh2LxG1lkVANgrkhQSQyeL3YVKf raGlk3PDU2XqqIvBWNzSeQ== X-Google-Smtp-Source: AA6agR7lkGJ1RnSR3/Tv86EzHnFrYiMd6dvnhbaaQpCNJSHgcCYv8ERsl4HSdAP0dChPa9EOLQ9v2A== X-Received: by 2002:a05:6a00:1704:b0:53b:b450:a51d with SMTP id h4-20020a056a00170400b0053bb450a51dmr31817498pfc.79.1663060351722; Tue, 13 Sep 2022 02:12:31 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.3]) by smtp.gmail.com with ESMTPSA id h10-20020a170902680a00b0015e8d4eb1d5sm7804661plk.31.2022.09.13.02.12.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2022 02:12:31 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH 2/4] mm/damon/sysfs: simplify the variable 'pid' assignment operation Date: Tue, 13 Sep 2022 17:11:25 +0800 Message-Id: <1663060287-30201-3-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> References: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663060352; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=d7BK1Sg/tQCQogt0rSecDlpjX+Yo/gtbxqyxdutICMQ=; b=YcPH607yMbokvEV6ToRrPniJNehiwJ7iJvq+0zmroNFCOqbL5reSIpfIEMcDRhe0qK/Jay Mhjt3Q5Tmq78Z2hcgVRUgBaxoocx1+bsrtwj2tainCKeYe7nU6ADcBTrz/MfFlhLbdxWsR FqU93WIp2YiiLtMWt6qxefsL2HGFQhM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=F5EDu9R9; spf=pass (imf03.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663060352; a=rsa-sha256; cv=none; b=bn2Uz5TcDHHh09nnNu2fTcIfhneNE6/RA8znQm7UFbSo3ZJqF83nxZ3PaZdEP+EFuEdZd3 K+5i4/fsLkR+5o6jnYq2HRDpKJGJzsDBn0BFWtu90NOGg9Pn+omsvkqhvezo2+1sWUskbF k3wJyhB4WkQl14Jq/Ox+aVQUlO1+uBo= X-Stat-Signature: rbuts551joz7fgutafqc1defqe447am1 X-Rspamd-Queue-Id: BE81F20088 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=F5EDu9R9; spf=pass (imf03.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1663060352-926939 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia We can initialize the variable 'pid' with '-1' in pid_show() to simplify the variable assignment operation and make the code more readable. Signed-off-by: Kaixu Xia --- mm/damon/sysfs.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index da01befae8bd..3606eec9b65d 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -2588,19 +2588,16 @@ static ssize_t pid_show(struct kobject *kobj, struct damon_sysfs_kdamond *kdamond = container_of(kobj, struct damon_sysfs_kdamond, kobj); struct damon_ctx *ctx; - int pid; + int pid = -1; if (!mutex_trylock(&damon_sysfs_lock)) return -EBUSY; ctx = kdamond->damon_ctx; - if (!ctx) { - pid = -1; + if (!ctx) goto out; - } + mutex_lock(&ctx->kdamond_lock); - if (!ctx->kdamond) - pid = -1; - else + if (ctx->kdamond) pid = ctx->kdamond->pid; mutex_unlock(&ctx->kdamond_lock); out: -- 2.27.0